fix(geocoder): update implementation and adjust replace script#444
Merged
DennisOSRM merged 2 commits intogh-pagesfrom May 3, 2026
Merged
fix(geocoder): update implementation and adjust replace script#444DennisOSRM merged 2 commits intogh-pagesfrom
DennisOSRM merged 2 commits intogh-pagesfrom
Conversation
This PR updates the geocoder implementation, adjusts scripts/replace.js, and fixes geocoder tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the geocoder integration to preserve Leaflet-Control-Geocoder defaults when no Nominatim URL is configured, and adjusts the build-time replacement script accordingly, along with test updates.
Changes:
- Update
geocoder.coordPreserving()to callL.Control.Geocoder.nominatim()with no args whennominatimUrlis omitted/blank. - Expand
scripts/replace.jsto replace Nominatim endpoints more flexibly (http/https, optional trailing slash). - Add a Jest test to validate the no-args Nominatim factory call path.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/geocoder.test.js | Adds coverage for the “no nominatimUrl provided” factory invocation behavior. |
| src/geocoder.js | Makes coordPreserving() select between {serviceUrl} vs default nominatim factory call. |
| scripts/replace.js | Updates endpoint replacement to match more URL variants via regex. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
37
to
39
| } | ||
| if (NOMINATIM_ENDPOINT) options = options.replace('https://nominatim.openstreetmap.org/', NOMINATIM_ENDPOINT) | ||
| if (NOMINATIM_ENDPOINT) options = options.replace(/https?:\/\/nominatim\.openstreetmap\.org\/?/g, function() { return NOMINATIM_ENDPOINT; }) | ||
|
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the geocoder implementation, adjusts scripts/replace.js, and fixes geocoder tests.