fix(docker): ensure index.html is world-readable in entrypoint#445
Merged
DennisOSRM merged 5 commits intogh-pagesfrom May 3, 2026
Merged
fix(docker): ensure index.html is world-readable in entrypoint#445DennisOSRM merged 5 commits intogh-pagesfrom
DennisOSRM merged 5 commits intogh-pagesfrom
Conversation
chmod 644 tmp file before moving to /usr/share/nginx/html to avoid nginx 403 (permission denied) on index.html Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
DennisOSRM
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Docker container startup script to avoid nginx 403 (permission denied) by ensuring the runtime-modified index.html ends up world-readable after the entrypoint injects the osrm-environment meta tag.
Changes:
- Add
chmod 644to the temporaryindex.htmlgenerated indocker/entrypoint.shbefore moving it into/usr/share/nginx/html/index.html.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| }' /usr/share/nginx/html/index.html > "$TMPFILE" && mv "$TMPFILE" /usr/share/nginx/html/index.html || true | ||
| }' /usr/share/nginx/html/index.html > "$TMPFILE" && chmod 644 "$TMPFILE" && mv "$TMPFILE" /usr/share/nginx/html/index.html || true |
Don't silently swallow awk/chmod/mv failures; emit warnings and remove temp file instead of ignoring errors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…age serves a page (skipped by default) Run with RUN_DOCKER_TESTS=1 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove RUN_DOCKER_TESTS gating so the integration test runs by default. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure index.html is world-readable to avoid nginx 403 (permission denied).\n\nThis change sets chmod 644 on the temporary file before moving it into /usr/share/nginx/html in docker/entrypoint.sh.\n\nCo-authored-by: Copilot 223556219+Copilot@users.noreply.github.com