fix(i18n): translate profile selector labels on language change#446
Merged
DennisOSRM merged 2 commits intogh-pagesfrom May 3, 2026
Merged
fix(i18n): translate profile selector labels on language change#446DennisOSRM merged 2 commits intogh-pagesfrom
DennisOSRM merged 2 commits intogh-pagesfrom
Conversation
- Add labelKey and default mappings for driving/bike/foot in src/leaflet_options.js - Build and translate services before creating mode selector and use services globally in src/index.js Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures routing profile selector labels are localized and update correctly when the UI language changes, by providing stable translation keys for services/profiles.
Changes:
- Add
labelKey(with defaults) to the services built from runtime modes, enabling consistent lookup in i18n dictionaries. - Translate/prepare
servicesearlier insrc/index.jsso the mode selector and routing control share the same service objects. - Replace direct
leafletOptions.servicesaccesses with a singleservicesreference for consistency.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/leaflet_options.js | Adds labelKey (with default mappings) to service objects produced from OSRM_MODES/defaults. |
| src/index.js | Prepares/translates services earlier and uses the shared services array throughout router/control/profile switching code. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+30
to
+37
| // Build and translate services early so modeSelector can use translated labels | ||
| var services = leafletOptions.services; | ||
| for (var i = 0, len = services.length; i < len; i++) { | ||
| var profileLabelKey = services[i].labelKey || services[i].label; | ||
| services[i].labelKey = profileLabelKey; | ||
| services[i].label = localization.t(language, profileLabelKey) || profileLabelKey; | ||
| } | ||
| var modeSelector = modeSelectorModule.createModeSelector(localization.get(language), services); |
Comment on lines
+323
to
+327
| var label = mode.label || name; | ||
| var labelKey = mode.labelKey || defaultLabelMapping[name] || label; | ||
| return { | ||
| label: mode.name, | ||
| label: label, | ||
| labelKey: labelKey, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures the profile selector uses translated labels when the language changes.
Files changed:
Tests: Ran locally; all tests passed.