Skip to content

Commit 46e201a

Browse files
authored
raise a ValueError when user tries to delete an unexisting transform (#377)
1 parent 06f88fe commit 46e201a

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

src/osekit/public/project.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -744,6 +744,10 @@ def delete_transform_with_outputs(self, transform_name: str) -> None:
744744
Name of the transform whose output to delete.
745745
746746
"""
747+
if transform_name not in self.transforms:
748+
message = f"Transform '{transform_name}' not found."
749+
raise ValueError(message)
750+
747751
for dataset_to_delete in self.get_output_by_transform_name(
748752
transform_name,
749753
):

tests/test_public_api.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1397,6 +1397,10 @@ def test_delete_output(
13971397
assert all(ds.name in proj.outputs.keys() for ds in datasets_to_keep)
13981398
assert not any(ds.name in proj.outputs.keys() for ds in datasets_to_delete)
13991399

1400+
# Trying to delete an unexisting transform should raise:
1401+
with pytest.raises(ValueError, match="'FrankieCosmos'"):
1402+
project.delete_transform_with_outputs("FrankieCosmos")
1403+
14001404

14011405
def test_existing_output_warning(
14021406
tmp_path: pytest.fixture,

0 commit comments

Comments
 (0)