Refactor code structure and remove redundant sections for improved readability and maintainability

Author: Sopwit

.clang-format

@@ -1,7 +1,7 @@
 ---
 # ro-Control clang-format configuration
-# CI bu dosyayı kullanır; değişirse tüm C++ kaynakları yeniden formatlanmalıdır.
-# Kullanım:
+# CI uses this file. When it changes, reformat the full C++ source tree.
+# Usage:
 #   find src \( -name "*.cpp" -o -name "*.h" \) -print0 | xargs -0 clang-format -i
 
 BasedOnStyle: LLVM

.github/ISSUE_TEMPLATE/bug_report.md

@@ -23,9 +23,14 @@ Describe the bug clearly.
 ## Environment
 
 - Distribution:
+- Distribution version:
 - Desktop session:
 - GPU:
 - Driver version:
 - ro-Control version:
 
 ## Logs or screenshots
+
+## Regression?
+
+- [ ] This worked in an earlier ro-Control build

.github/ISSUE_TEMPLATE/feature_request.md

@@ -8,8 +8,12 @@ assignees: ''
 
 ## Problem
 
+Describe the current limitation or workflow pain clearly.
+
 ## Proposed change
 
+Describe the expected user-facing behavior.
+
 ## Alternatives considered
 
 ## Additional context

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,7 +1,10 @@
 ## Summary
 
+State the user-facing outcome in 1-3 sentences.
+
 ## What Changed
 
+- 
 - 
 
 ## Validation
@@ -10,5 +13,8 @@
 - [ ] Tests passed
 - [ ] UI checked if applicable
 - [ ] Translations updated if applicable
+- [ ] Packaging and metadata checked if applicable
 
 ## Notes
+
+Mention follow-up work, risk, or anything intentionally left out.

.github/workflows/ci.yml

@@ -157,10 +157,13 @@ jobs:
             exit 1
           fi
 
+          cp "${MAIN_RPM}" /tmp/ro-control-x86_64.rpm
+          cp "${COMMON_RPM}" /tmp/ro-control-common-noarch.rpm
+
       - name: Install and smoke-test RPMs
         run: |
-          MAIN_RPM="$(find ~/rpmbuild/RPMS -maxdepth 2 -type f -name 'ro-control-*.x86_64.rpm' | head -n1)"
-          COMMON_RPM="$(find ~/rpmbuild/RPMS -maxdepth 2 -type f -name 'ro-control-common-*.noarch.rpm' | head -n1)"
+          MAIN_RPM=/tmp/ro-control-x86_64.rpm
+          COMMON_RPM=/tmp/ro-control-common-noarch.rpm
 
           dnf clean all
           dnf -y --refresh --setopt=install_weak_deps=False install "${MAIN_RPM}" "${COMMON_RPM}"

.github/workflows/release.yml

@@ -168,8 +168,17 @@ jobs:
             --define "upstream_version ${VERSION}" \
             --define "dist .fc${FEDORA_VERSION}"
 
-          find ~/rpmbuild/RPMS -maxdepth 2 -type f -name "${MAIN_RPM_PATTERN}" -exec cp {} dist/rpm/ \;
-          find ~/rpmbuild/RPMS -maxdepth 2 -type f -name "${COMMON_RPM_PATTERN}" -exec cp {} dist/rpm/ \;
+          MAIN_RPM_FILE="$(find ~/rpmbuild/RPMS -maxdepth 2 -type f -name "${MAIN_RPM_PATTERN}" | head -n1)"
+          if [[ -z "${MAIN_RPM_FILE}" ]]; then
+            echo "Failed to find built ${RPM_ARCH} main RPM." >&2
+            exit 1
+          fi
+          cp "${MAIN_RPM_FILE}" "dist/rpm/ro-control-${RPM_ARCH}.rpm"
+
+          COMMON_RPM_FILE="$(find ~/rpmbuild/RPMS -maxdepth 2 -type f -name "${COMMON_RPM_PATTERN}" | head -n1)"
+          if [[ -n "${COMMON_RPM_FILE}" ]]; then
+            cp "${COMMON_RPM_FILE}" "dist/rpm/ro-control-common-noarch.rpm"
+          fi
 
           if [[ "${RPM_ARCH}" == "x86_64" ]]; then
             cp ~/rpmbuild/SRPMS/*.src.rpm dist/rpm/
@@ -180,9 +189,8 @@ jobs:
           VERSION: ${{ needs.metadata.outputs.version }}
           RPM_ARCH: ${{ matrix.arch }}
         run: |
-          RPM_PATTERN="*.${RPM_ARCH}.rpm"
-          RPM_FILE="$(find dist/rpm -maxdepth 1 -type f -name "${RPM_PATTERN}" | head -n1)"
-          if [[ -z "${RPM_FILE}" ]]; then
+          RPM_FILE="dist/rpm/ro-control-${RPM_ARCH}.rpm"
+          if [[ ! -f "${RPM_FILE}" ]]; then
             echo "Failed to locate built ${RPM_ARCH} RPM." >&2
             exit 1
           fi
@@ -200,15 +208,15 @@ jobs:
         env:
           RPM_ARCH: ${{ matrix.arch }}
         run: |
-          MAIN_RPM_FILE="$(find dist/rpm -maxdepth 1 -type f -name "ro-control-*.${RPM_ARCH}.rpm" | head -n1)"
-          COMMON_RPM_FILE="$(find dist/rpm -maxdepth 1 -type f -name 'ro-control-common-*.noarch.rpm' | head -n1)"
+          MAIN_RPM_FILE="dist/rpm/ro-control-${RPM_ARCH}.rpm"
+          COMMON_RPM_FILE="dist/rpm/ro-control-common-noarch.rpm"
 
-          if [[ -z "${MAIN_RPM_FILE}" ]]; then
+          if [[ ! -f "${MAIN_RPM_FILE}" ]]; then
             echo "Main ro-control RPM is missing." >&2
             exit 1
           fi
 
-          if [[ -z "${COMMON_RPM_FILE}" ]]; then
+          if [[ ! -f "${COMMON_RPM_FILE}" ]]; then
             echo "ro-control-common noarch RPM is missing." >&2
             exit 1
           fi
@@ -229,17 +237,15 @@ jobs:
           VERSION: ${{ needs.metadata.outputs.version }}
           RPM_ARCH: ${{ matrix.arch }}
         run: |
-          RPM_PATTERN="*.${RPM_ARCH}.rpm"
-          NOARCH_PATTERN="*.noarch.rpm"
-          RPM_FILE="$(find dist/rpm -maxdepth 1 -type f -name "${RPM_PATTERN}" | head -n1)"
-          NOARCH_FILE="$(find dist/rpm -maxdepth 1 -type f -name "${NOARCH_PATTERN}" | head -n1)"
+          RPM_FILE="dist/rpm/ro-control-${RPM_ARCH}.rpm"
+          NOARCH_FILE="dist/rpm/ro-control-common-noarch.rpm"
 
-          if [[ -z "${RPM_FILE}" ]]; then
+          if [[ ! -f "${RPM_FILE}" ]]; then
             echo "Failed to locate built ${RPM_ARCH} RPM for smoke testing." >&2
             exit 1
           fi
 
-          if [[ -z "${NOARCH_FILE}" ]]; then
+          if [[ ! -f "${NOARCH_FILE}" ]]; then
             echo "Failed to locate ro-control-common noarch RPM for smoke testing." >&2
             exit 1
           fi

.github/workflows/rpm-artifacts.yml

@@ -131,11 +131,11 @@ jobs:
             exit 1
           fi
 
-          cp "${MAIN_RPM_FILE}" dist/rpm/
+          cp "${MAIN_RPM_FILE}" "dist/rpm/ro-control-${RPM_ARCH}.rpm"
 
           COMMON_RPM_FILE="$(find ~/rpmbuild/RPMS -maxdepth 2 -type f -name "${COMMON_RPM_PATTERN}" | head -n1)"
           if [[ -n "${COMMON_RPM_FILE}" ]]; then
-            cp "${COMMON_RPM_FILE}" dist/rpm/
+            cp "${COMMON_RPM_FILE}" "dist/rpm/ro-control-common-noarch.rpm"
           fi
 
       - name: Validate metadata and RPM dependency surface
@@ -145,8 +145,8 @@ jobs:
           desktop-file-validate data/icons/io.github.projectroasd.rocontrol.desktop
           appstreamcli validate --no-net data/icons/io.github.projectroasd.rocontrol.metainfo.xml
 
-          MAIN_RPM_FILE="$(find dist/rpm -maxdepth 1 -type f -name "ro-control-*.${RPM_ARCH}.rpm" | head -n1)"
-          COMMON_RPM_FILE="$(find dist/rpm -maxdepth 1 -type f -name 'ro-control-common-*.noarch.rpm' | head -n1)"
+          MAIN_RPM_FILE="dist/rpm/ro-control-${RPM_ARCH}.rpm"
+          COMMON_RPM_FILE="dist/rpm/ro-control-common-noarch.rpm"
 
           rpm -qpR "${MAIN_RPM_FILE}" | tee /tmp/ro-control.requires
           if grep -E 'Qt_6\.10|PRIVATE_API' /tmp/ro-control.requires; then
@@ -155,7 +155,7 @@ jobs:
           fi
 
           rpm -qpl "${MAIN_RPM_FILE}" | grep -Fx '/usr/bin/ro-control'
-          if [[ -n "${COMMON_RPM_FILE}" ]] && rpm -qpl "${COMMON_RPM_FILE}" | grep -Fx '/usr/bin/ro-control'; then
+          if [[ -f "${COMMON_RPM_FILE}" ]] && rpm -qpl "${COMMON_RPM_FILE}" | grep -Fx '/usr/bin/ro-control'; then
             echo "/usr/bin/ro-control must only be shipped by the main RPM." >&2
             exit 1
           fi

CONTRIBUTING.md

@@ -29,6 +29,12 @@ cmake --build build --parallel
 ctest --test-dir build --output-on-failure
 ```
 
+Fedora contributors can use:
+
+```bash
+./scripts/fedora-bootstrap.sh
+```
+
 ## Style
 
 - keep English as the source language in code

README.md

@@ -2,6 +2,11 @@
 
 Native Qt6/QML desktop application for NVIDIA driver management and Linux system monitoring.
 
+Primary packaging target:
+
+- Fedora 43 KDE Plasma
+- x86_64 and aarch64
+
 ## Overview
 
 ro-Control focuses on three things:
@@ -35,6 +40,12 @@ cmake --build build --parallel
 ctest --test-dir build --output-on-failure
 ```
 
+On Fedora development hosts, you can also bootstrap dependencies with:
+
+```bash
+./scripts/fedora-bootstrap.sh
+```
+
 ## Packaging
 
 The repository includes:

data/helpers/ro-control-helper.sh.in

@@ -63,11 +63,13 @@ run_allowed_command() {
 if [ "$#" -ge 1 ] && [ "$1" = "--batch" ]; then
   tab="$(printf '\t')"
 
+  # Each batch line is tab-separated: command<TAB>arg1<TAB>arg2...
   while IFS= read -r command_line || [ -n "${command_line}" ]; do
     [ -z "${command_line}" ] && continue
 
     old_ifs="${IFS}"
     IFS="${tab}"
+    # shellcheck disable=SC2086
     set -- ${command_line}
     IFS="${old_ifs}"