pagination all citizens#542
Open
bobatari wants to merge 2 commits intoProject-Sloth:mainfrom
Open
Conversation
citizens.lua pulls all players from db now. can only get players online with ps.getAllPlayers() but think it's bad idea?
now returns pages + data from db for citizens.
Epixx1337
added a commit
to Epixx1337/ps-mdt
that referenced
this pull request
Apr 14, 2026
- Return { data, total, totalPages, page, limit } from getCitizens callback
- Add total count query and ORDER BY lastname, firstname
- Fix v.id = _ bug (use ipairs index i instead)
- Client passes page number and re-fetches on page change
- Match server default perPage of 20
- Use total from server for accurate Pagination range display
Based on upstream PR Project-Sloth#542
| page: citizenPage | ||
| }); // this shit makes the whole world go round | ||
|
|
||
| citizens = Array.isArray(result) ? result : []; // this shit shows you the world spinning |
| citizens = Array.isArray(result) ? result : []; | ||
| const result = await fetchNui(NUI_EVENTS.CITIZEN.GET_CITIZENS, { | ||
| page: citizenPage | ||
| }); // this shit makes the whole world go round |
| local result = safeQuery(query, { limit, offset }) | ||
| if not result or #result == 0 then return {} end | ||
| if not result or #result == 0 then | ||
| return { --same shit different row |
| end | ||
|
|
||
| -- getCitizens - pulls citizens from database with pagination support | ||
| -- getCitizens - pulls citizens from database with pagination support - this shit is broken |
|
|
||
| -- getCitizens - pulls citizens from database with pagination support | ||
| -- getCitizens - pulls citizens from database with pagination support - this shit is broken | ||
| -- this shit is now fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pagination wasnt pulling all citizens, this should update that.