Potential fix for code scanning alert no. 2: Workflow does not contain permissions#125
Merged
Project516 merged 1 commit intomasterfrom Feb 23, 2026
Merged
Potential fix for code scanning alert no. 2: Workflow does not contain permissions#125Project516 merged 1 commit intomasterfrom
Project516 merged 1 commit intomasterfrom
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Owner
Author
|
@copilot will the uploading of assets work after this change? |
Contributor
|
@Project516 I've opened a new pull request, #126, to work on those changes. Once the pull request is ready, I'll request review from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Project516/NumberGuessingGame/security/code-scanning/2
To fix the problem, explicitly restrict the
GITHUB_TOKENpermissions for thebuild-assetsjob. Since this job only needs to clone the repository and upload artifacts to the workflow run, it does not need any write permissions to the repository;contents: readis sufficient.actions/upload-artifactoperates on the workflow run and does not require repository write scopes.The best minimal fix without changing existing functionality is to add a
permissionsblock to thebuild-assetsjob, at the same indentation level asruns-onandstrategy. Setcontents: readso thatactions/checkoutcan read the repository, while avoiding unnecessary write scopes. Thecreate-releasejob already haspermissions: contents: write, which is appropriate to upload release assets, so no change is needed there.Concretely: edit
.github/workflows/release.yml, in thebuild-assetsjob definition betweenruns-on: ubuntu-latest(line 13) andstrategy:(line 14), and insert:No imports or other definitions are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.