feat: #4 upgrade 11ty v3 and adopt ESM#17
Merged
Conversation
thescientist13
added
documentation
✅ Deploy Preview for legendary-starlight-75451b ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
thescientist13
changed the title
This was referenced Dec 17, 2025
Closed
KaiPrince
approved these changes
Dec 19, 2025
KaiPrince
left a comment
KaiPrince
left a comment
Contributor
There was a problem hiding this comment.
I notice the CI still hasn’t run
|
|
||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - uses: actions/checkout@v4 |
Contributor
There was a problem hiding this comment.
The latest version for this and setup-node is actually v6
| delete require.cache[require.resolve(file)]; | ||
| // naive cache busting solution for ESM | ||
| // https://github.com/nodejs/help/issues/2806 | ||
| await import(`${file}?t=${Date.now()}`); |
Member
Author
Ah, yeah. Two od those are branch protections setting detection job checks which don't apply anymore now after this PR, the rest are still valid. Let me remove those out of date checks, and update checkout verison. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #4
Summary of Changes
Did a big dependency overhaul since the deps here were extremely outdated
3.x(breaking)0.18.0(could be breaking)So it looks like this upgrade kind of resolves #8 too? The custom element in the demo directory now correctly renders (I can't remember if it did before, but it wasn't working for me locally)
however, there are still wrapping
<p>tags? 🤔TODO