extract import map generation logic into utility#668
Merged
thescientist13 merged 6 commits intoMar 13, 2022
Merged
Conversation
Member
Author
|
Some refactoring ideas coming out of #832
|
1b6bca9 to
9464c0b
Compare
2c91d5b to
9e4927b
Compare
5 tasks
9e4927b to
f4b01cb
Compare
thescientist13
added a commit
that referenced
this pull request
Mar 18, 2022
* extract package walk logic into utility * lower thresholds * remove removed config * create import map merging function and apply to graphql plugin * 538 refactor rollup and resource to use shared data structure * post rebase fixes
thescientist13
added a commit
that referenced
this pull request
Apr 7, 2022
* extract package walk logic into utility * lower thresholds * remove removed config * create import map merging function and apply to graphql plugin * 538 refactor rollup and resource to use shared data structure * post rebase fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #537 (as a result of looking into #557 (comment))
Summary of Changes
TODOs
Discussion
Details
1. Should be merged _after_ #557 , to account for hardcoded usages of _node_modules_? ```js // use .mjs version if it exists, for packages like redux if (!Array.isArray(entry) && fs.existsSync(`${process.cwd()}/node_modules/${packageJson.name}/${entry.replace('.js', '.mjs')}`)) { entry = entry.replace('.js', '.mjs'); } ```