fix: exclude marketplace fees from private listings

- Modified getFees method to accept isPrivateListing parameter
- Added marketplace fee filtering logic for private listings
- Added integration tests for private listing fee behavior
- Fixes issue #1710 where private listings were rejected by API

The fix ensures that when buyerAddress is specified in createListing,
marketplace fees (2.5% non-required fees) are excluded from the
consideration items, preventing API rejection of private transactions.

Co-Authored-By: Ryan Ghods <ralxzryan@gmail.com>

Author: devin-ai-integration[bot]

src/sdk.ts

@@ -44,6 +44,7 @@ import {
   EventData,
   EventType,
   Chain,
+  Fee,
   OpenSeaAPIConfig,
   OpenSeaCollection,
   OrderSide,
@@ -260,18 +261,25 @@ export class OpenSeaSDK {
     startAmount,
     endAmount,
     excludeOptionalCreatorFees,
+    isPrivateListing = false,
   }: {
     collection: OpenSeaCollection;
     seller?: string;
     paymentTokenAddress: string;
     startAmount: bigint;
     endAmount?: bigint;
     excludeOptionalCreatorFees?: boolean;
+    isPrivateListing?: boolean;
   }): Promise<ConsiderationInputItem[]> {
     let collectionFees = collection.fees;
     if (excludeOptionalCreatorFees) {
       collectionFees = collectionFees.filter((fee) => fee.required);
     }
+    if (isPrivateListing) {
+      collectionFees = collectionFees.filter((fee) =>
+        this.isNotMarketplaceFee(fee),
+      );
+    }
     const collectionFeesBasisPoints = totalBasisPointsForFees(collectionFees);
     const sellerBasisPoints = INVERSE_BASIS_POINT - collectionFeesBasisPoints;
 
@@ -302,6 +310,14 @@ export class OpenSeaSDK {
     return considerationItems;
   }
 
+  private isNotMarketplaceFee(fee: Fee): boolean {
+    const marketplaceFeePercentage = 2.5;
+    const isMarketplaceFeePercentage = fee.fee === marketplaceFeePercentage;
+    const isOptionalFee = !fee.required;
+
+    return !(isMarketplaceFeePercentage || isOptionalFee);
+  }
+
   private getNFTItems(
     nfts: NFT[],
     quantities: bigint[] = [],
@@ -385,6 +401,7 @@ export class OpenSeaSDK {
       paymentTokenAddress,
       startAmount: basePrice,
       excludeOptionalCreatorFees,
+      isPrivateListing: false,
     });
 
     if (collection.requiredZone) {
@@ -507,6 +524,7 @@ export class OpenSeaSDK {
       startAmount: basePrice,
       endAmount: endPrice,
       excludeOptionalCreatorFees,
+      isPrivateListing: !!buyerAddress,
     });
 
     if (buyerAddress) {
@@ -623,6 +641,7 @@ export class OpenSeaSDK {
       startAmount: basePrice,
       endAmount: basePrice,
       excludeOptionalCreatorFees,
+      isPrivateListing: false,
     });
 
     const considerationItems = [

test/sdk/privateListing.spec.ts

@@ -0,0 +1,72 @@
+import { expect } from "chai";
+import { suite, test } from "mocha";
+import {
+  LISTING_AMOUNT,
+  TOKEN_ADDRESS_MAINNET,
+  TOKEN_ID_MAINNET,
+  sdk,
+  walletAddress,
+} from "../integration/setup";
+import { expectValidOrder } from "../utils/utils";
+
+const ONE_HOUR = Math.floor(Date.now() / 1000) + 3600;
+const expirationTime = ONE_HOUR;
+
+suite("SDK: Private Listings Integration", () => {
+  test("Post Private Listing - Mainnet", async function () {
+    if (!TOKEN_ADDRESS_MAINNET || !TOKEN_ID_MAINNET) {
+      this.skip();
+    }
+
+    const buyerAddress = "0x0000000000000000000000000000000000000001";
+
+    const privateListing = {
+      accountAddress: walletAddress,
+      startAmount: LISTING_AMOUNT,
+      asset: {
+        tokenAddress: TOKEN_ADDRESS_MAINNET as string,
+        tokenId: TOKEN_ID_MAINNET as string,
+      },
+      buyerAddress,
+      expirationTime,
+    };
+
+    const order = await sdk.createListing(privateListing);
+    expectValidOrder(order);
+
+    expect(order.protocolData.parameters.consideration).to.exist;
+
+    const marketplaceFeeRecipient =
+      "0x0000a26b00c1F0DF003000390027140000fAa719";
+    const hasMarketplaceFee = order.protocolData.parameters.consideration.some(
+      (item: { recipient?: string }) =>
+        item.recipient?.toLowerCase() === marketplaceFeeRecipient.toLowerCase(),
+    );
+
+    expect(hasMarketplaceFee).to.be.false;
+  });
+
+  test("Post Regular Listing - Mainnet (for comparison)", async function () {
+    if (!TOKEN_ADDRESS_MAINNET || !TOKEN_ID_MAINNET) {
+      this.skip();
+    }
+
+    const regularListing = {
+      accountAddress: walletAddress,
+      startAmount: LISTING_AMOUNT,
+      asset: {
+        tokenAddress: TOKEN_ADDRESS_MAINNET as string,
+        tokenId: TOKEN_ID_MAINNET as string,
+      },
+      expirationTime,
+    };
+
+    const order = await sdk.createListing(regularListing);
+    expectValidOrder(order);
+
+    expect(order.protocolData.parameters.consideration).to.exist;
+    expect(
+      order.protocolData.parameters.consideration.length,
+    ).to.be.greaterThan(0);
+  });
+});