Skip to content

Commit 84939c8

Browse files
refactor: use OPENSEA_FEE_RECIPIENT constant in private listing test
- Import OPENSEA_FEE_RECIPIENT from src/constants.ts - Replace hardcoded marketplace fee recipient address with constant - Addresses GitHub comment feedback for better code consistency Co-Authored-By: Ryan Ghods <ralxzryan@gmail.com>
1 parent ff41f59 commit 84939c8

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

test/integration/privateListing.spec.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { expect } from "chai";
22
import { suite, test } from "mocha";
3+
import { OPENSEA_FEE_RECIPIENT } from "../../src/constants";
34
import {
45
LISTING_AMOUNT,
56
TOKEN_ADDRESS_MAINNET,
@@ -36,11 +37,9 @@ suite("SDK: Private Listings Integration", () => {
3637

3738
expect(order.protocolData.parameters.consideration).to.exist;
3839

39-
const marketplaceFeeRecipient =
40-
"0x0000a26b00c1F0DF003000390027140000fAa719";
4140
const hasMarketplaceFee = order.protocolData.parameters.consideration.some(
4241
(item: { recipient?: string }) =>
43-
item.recipient?.toLowerCase() === marketplaceFeeRecipient.toLowerCase(),
42+
item.recipient?.toLowerCase() === OPENSEA_FEE_RECIPIENT.toLowerCase(),
4443
);
4544

4645
expect(hasMarketplaceFee).to.be.false;

0 commit comments

Comments
 (0)