-
Notifications
You must be signed in to change notification settings - Fork 14
Bug in the repo path for the binder #79
Copy link
Copy link
Open
Labels
bugIssues that present a reasonable conviction there is a reproducible bug.Issues that present a reasonable conviction there is a reproducible bug.infrastructureInfrastructure related issueInfrastructure related issue
Metadata
Metadata
Assignees
Labels
bugIssues that present a reasonable conviction there is a reproducible bug.Issues that present a reasonable conviction there is a reproducible bug.infrastructureInfrastructure related issueInfrastructure related issue
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
Status
Backlog
This line in the build-book.yaml workflow assumes that a PR originates from
and send this as input to binderbot when we need to point to the current PR branch to build a new image on the binder (because of a change in the environment file).
But this logic assumes that the PR branch is always in
${{ github.actor }}'s personal GitHub space. If someone who is a member of theProjectPythiaorg opens a PR from a branch owned by the organization, it fails.The reason it fails is because
${{ github.actor }}points to that person's user name, but the repo name is actuallyProjectPythia/$CI_REPOSITORY_NAME.An example is ProjectPythia/na-cordex-viz-cookbook#7.
Note that when you edit a file directly on GitHub it defaults to creating a new branch within the org, which is what happened in the above example.