Add snow-observations-cookbook to gallery#29
Conversation
|
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
|
The build seems to be choking on the thumbnail image. I'm not immediately sure why. Reference: this build log which is producing |
|
The build seems to be looking for the thumbnail image at |
|
@aaarendt the build failure is because the thumbnail image is in a subdirectory The reason for this inconsistency seems to originate in our Cookbook Template, so this needs to be fixed upstream. But the solution here is to do either:
Either one should work fine, and it's just a matter of taste for how you keep your repo organized. |
|
Thanks @brian-rose, I moved the thumbnail to the root directory as suggested. |
|
Gallery build is passing now. I will make some suggestions over at https://github.com/ProjectPythia/snow-observations-cookbook to resolve some current build issues for the cookbook. |
|
Thanks @brian-rose. Is this to do with the nightly builds failing? I've tried to fix but couldn't figure it out. Let me know if I can assist. |
On closer inspection, the nightly builds are passing, it's just that the badge on the README page is still pointing to the Cookbook Template (which is currently broken). I will open a PR to fix that. |
|
Thanks @brian-rose ! I approved and merged ProjectPythia/snow-observations-cookbook#14 |
|
@brian-rose I think this is ready to merge? |
@aaarendt Sorry about the delay. I am spending some time today reviewing the cookbooks contents, which is part of the process for merging new cookbooks onto the gallery. I will open a PR on the source repo with some minor formatting improvements to bring it more in line with some cookbook best practices. Once we get that stuff merged, this is good to go. |
brian-rose
left a comment
There was a problem hiding this comment.
I have reviewed the cookbook and worked with @aaarendt to resolve a few issues. Happy to merge this excellent new content into the Pythia Gallery.
This PR is to request the inclusion of the snow observations cookbook to the Project Pythia gallery.