Skip to content

DRAFT: Revisions #2

Merged
erogluorhan merged 2 commits into
ProjectPythia:mainfrom
philipc2:main
May 5, 2025
Merged

DRAFT: Revisions #2
erogluorhan merged 2 commits into
ProjectPythia:mainfrom
philipc2:main

Conversation

@philipc2
Copy link
Copy Markdown
Collaborator

@philipc2 philipc2 commented May 5, 2025

Overview

  • Revisions

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: e5ec66e
✅ Deployment Preview URL: https://ProjectPythia.github.io/healpix-cookbook/_preview/2

@philipc2
Copy link
Copy Markdown
Collaborator Author

philipc2 commented May 5, 2025

@erogluorhan

I've made some changes to the Grid Topology section to better highlight the HEALPix structure.

We can still use the Geodetic source projection, and it allows us to showcase how our internal grid representation works (i.e. pixels are defined by their great circle arcs, which is required by the UGRID conventions)

image image

We can also better visualuze HEALPix data at a coarse resolution

image

We can still highlight this without merging UXARRAY/uxarray#1231

@philipc2
Copy link
Copy Markdown
Collaborator Author

philipc2 commented May 5, 2025

I'll be making a few more revisions & suggestions, I'll make the PR as ready for review and ping you once it's ready.

However, I'm extremely impressed by the work you've put together thus far. The notebooks look excellent and this'll be an invaluable learning materials for the hackathon.

Copy link
Copy Markdown
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for catching typos and also all the suggestions!

@erogluorhan erogluorhan marked this pull request as ready for review May 5, 2025 16:59
@erogluorhan erogluorhan merged commit 8f172b3 into ProjectPythia:main May 5, 2025
2 checks passed
github-actions Bot pushed a commit that referenced this pull request May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants