[Breaking] Hash values of label indexes

Author: Tpt

src/MongoDB/MongoDBDocumentBuilder.php

@@ -140,7 +140,7 @@ public function cleanTextForSearch( $text ) {
 		$text = mb_strtolower( $text, 'UTF-8' ); //TODO: said to be very slow
 		$text = trim( $text );
 
-		return new MongoBinData( $text, MongoBinData::GENERIC );
+		return new MongoBinData( md5( $text, true ), MongoBinData::GENERIC );
 	}
 
 	private function buildSearchClaimsForEntity( array $serialization ) {
@@ -198,11 +198,11 @@ private function buildSearchedDataValue( array $dataValue ) {
 	 * @return string
 	 */
 	public function buildSearchedStringValue( $value ) {
-		if( strlen( $value ) <= 128 ) {
+		if( strlen( $value ) <= 32 ) {
 			return $value;
 		}
 
-		return hash( 'md5', $value );
+		return md5( $value );
 	}
 
 	private function buildSearchedEntityIdValue( array $value ) {

tests/unit/MongoDB/MongoDBDocumentBuilderTest.php

@@ -27,9 +27,9 @@ public function testBuildDocumentForEntity() {
 		$item = new Item(
 			new ItemId( 'Q1' ),
 			new Fingerprint(
-				new TermList( [ new Term( 'en', 'foo' ) ] ),
+				new TermList( [ new Term( 'en', 'foo ' ) ] ),
 				new TermList( [ new Term( 'en', 'bar' ) ] ),
-				new AliasGroupList( [ new AliasGroup( 'fr', [ 'bÊz', 'bat' ] ) ] )
+				new AliasGroupList( [ new AliasGroup( 'fr', [ 'BAZée', 'bat' ] ) ] )
 			)
 		);
 
@@ -41,14 +41,14 @@ public function testBuildDocumentForEntity() {
 				'type' => 'item',
 				'id' => 'Q1',
 				'labels' => [
-					'en' => [ 'language' => 'en', 'value' => 'foo' ]
+					'en' => [ 'language' => 'en', 'value' => 'foo ' ]
 				],
 				'descriptions' => [
 					'en' => [ 'language' => 'en', 'value' => 'bar' ],
 				],
 				'aliases' => [
 					'fr' => [
-						[ 'language' => 'fr', 'value' => 'baz' ],
+						[ 'language' => 'fr', 'value' => 'BAZée' ],
 						[ 'language' => 'fr', 'value' => 'bat' ]
 					]
 				],
@@ -135,14 +135,14 @@ public function testBuildDocumentForEntity() {
 				'type' => 'item',
 				'id' => 'Q1',
 				'labels' => [
-					'en' => [ 'language' => 'en', 'value' => 'foo' ],
+					'en' => [ 'language' => 'en', 'value' => 'foo ' ],
 				],
 				'descriptions' => [
 					'en' => [ 'language' => 'en', 'value' => 'bar' ],
 				],
 				'aliases' => [
 					'fr' => [
-						[ 'language' => 'fr', 'value' => 'baz' ],
+						[ 'language' => 'fr', 'value' => 'BAZée' ],
 						[ 'language' => 'fr', 'value' => 'bat' ]
 					]
 				],
@@ -213,10 +213,10 @@ public function testBuildDocumentForEntity() {
 					]
 				],
 				'sterms' => [
-					'en' => [ new MongoBinData( 'foo', MongoBinData::GENERIC ) ],
+					'en' => [ new MongoBinData( md5( 'foo', true ), MongoBinData::GENERIC ) ],
 					'fr' => [
-						new MongoBinData( 'baz', MongoBinData::GENERIC ),
-						new MongoBinData( 'bat', MongoBinData::GENERIC )
+						new MongoBinData( md5( 'bazée', true ), MongoBinData::GENERIC ),
+						new MongoBinData( md5( 'bat', true ), MongoBinData::GENERIC )
 					]
 				],
 				'sclaims' => [
@@ -250,15 +250,15 @@ public function testBuildDocumentForEntityWithLanguageOption() {
 				'type' => 'item',
 				'id' => 'Q1',
 				'labels' => [
-					'en' => [ 'language' => 'en', 'value' => 'foo' ],
+					'en' => [ 'language' => 'en', 'value' => 'foo ' ],
 					'de' => [ 'language' => 'en', 'value' => 'bar' ],
 				],
 				'descriptions' => [
 					'en' => [ 'language' => 'en', 'value' => 'bar' ],
 				],
 				'aliases' => [
 					'fr' => [
-						[ 'language' => 'fr', 'value' => 'baz' ],
+						[ 'language' => 'fr', 'value' => 'BAzée' ],
 						[ 'language' => 'fr', 'value' => 'bat' ]
 					],
 					'it' => [ [ 'language' => 'it', 'value' => 'goo' ] ]
@@ -280,22 +280,22 @@ public function testBuildDocumentForEntityWithLanguageOption() {
 				'id' => 'Q1',
 				'type' => 'item',
 				'labels' => [
-					'en' => [ 'language' => 'en', 'value' => 'foo' ],
+					'en' => [ 'language' => 'en', 'value' => 'foo ' ],
 				],
 				'descriptions' => [
 					'en' => [ 'language' => 'en', 'value' => 'bar' ],
 				],
 				'aliases' => [
 					'fr' => [
-						[ 'language' => 'fr', 'value' => 'baz' ],
+						[ 'language' => 'fr', 'value' => 'BAzée' ],
 						[ 'language' => 'fr', 'value' => 'bat' ]
 					]
 				],
 				'sterms' => [
-					'en' => [ new MongoBinData( 'foo', MongoBinData::GENERIC ) ],
+					'en' => [ new MongoBinData( md5( 'foo', true ), MongoBinData::GENERIC ) ],
 					'fr' => [
-						new MongoBinData( 'baz', MongoBinData::GENERIC ),
-						new MongoBinData( 'bat', MongoBinData::GENERIC )
+						new MongoBinData( md5( 'bazée', true ), MongoBinData::GENERIC ),
+						new MongoBinData( md5( 'bat', true ), MongoBinData::GENERIC )
 					]
 				],
 				'sclaims' => []
@@ -373,15 +373,15 @@ public function cleanTextForSearchProvider() {
 		return [
 			[
 				'test',
-				new MongoBinData( 'test', MongoBinData::GENERIC )
+				new MongoBinData( md5( 'test', true ), MongoBinData::GENERIC )
 			],
 			[
 				'TODO',
-				new MongoBinData( 'todo', MongoBinData::GENERIC )
+				new MongoBinData( md5( 'todo', true ), MongoBinData::GENERIC )
 			],
 			[
 				'Être',
-				new MongoBinData( 'être', MongoBinData::GENERIC )
+				new MongoBinData( md5( 'être', true ), MongoBinData::GENERIC )
 			],
 		];
 	}