fix(ci): resolve clippy errors and warnings blocking CI

- Add `json` feature to reqwest dep (fixes E0599 compile error under --all-features)
- Gate blake3_file fn and its test under cfg(windows + self-update)
- Use cfg_attr to suppress unused_mut on meta only on non-Windows
- Convert module doc from /// to //! in plugin_info
- Replace iter().any() with slice::contains() in tool_names_for
- Use matches! macro in transition_allowed
- Use fn pointer instead of redundant closure in ingest handler
- Swap #![allow(unexpected_cfgs)] before #![cfg] in phase6 test
- Replace &[x.clone()] with slice::from_ref(&x) in ledger-core tests

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: Claude Sonnet (coordinator)

crates/ledger-core/tests/phase2_ingest.rs

@@ -26,7 +26,7 @@ fn reingest_is_idempotent() {
     };
 
     let mut ledger = IngestedLedger::default();
-    let first = ledger.ingest(&[tx.clone()]);
+    let first = ledger.ingest(std::slice::from_ref(&tx));
     let second = ledger.ingest(&[tx]);
 
     assert_eq!(first.len(), 1);

crates/ledger-core/tests/phase2_ingest_pipeline_remaining.rs

@@ -42,7 +42,7 @@ fn ing_02_reingest_has_no_duplicate_journal_or_tx_rows() {
 
     let mut ledger = IngestedLedger::default();
     let first = ledger
-        .ingest_to_journal_and_workbook(&[row.clone()], &journal, &workbook)
+        .ingest_to_journal_and_workbook(std::slice::from_ref(&row), &journal, &workbook)
         .unwrap();
     let second = ledger
         .ingest_to_journal_and_workbook(&[row], &journal, &workbook)

crates/ledger-core/tests/phase2_rustledger_journal.rs

@@ -36,7 +36,7 @@ fn ingest_to_journal_is_replay_safe() {
 
     let mut ledger = IngestedLedger::default();
 
-    let first = ledger.ingest_to_journal(&[tx.clone()], &journal_path).unwrap();
+    let first = ledger.ingest_to_journal(std::slice::from_ref(&tx), &journal_path).unwrap();
     let second = ledger.ingest_to_journal(&[tx], &journal_path).unwrap();
 
     assert_eq!(first.len(), 1);

crates/ledgerr-mcp/Cargo.toml

@@ -17,7 +17,7 @@ thiserror = "2"
 sysinfo = { version = "0.33", default-features = false, features = ["system"] }
 
 # self-update feature deps — only compiled when the feature is active
-reqwest = { version = "0.12", features = ["blocking", "rustls-tls"], default-features = false, optional = true }
+reqwest = { version = "0.12", features = ["blocking", "json", "rustls-tls"], default-features = false, optional = true }
 semver = { version = "1", optional = true }
 
 # winreg — Windows-only, safe registry wrapper; gated at the cfg level in code

crates/ledgerr-mcp/src/events.rs

@@ -283,13 +283,13 @@ pub fn reconstruct_lifecycle(events: &[LifecycleEvent]) -> ReplayProjection {
 }
 
 fn transition_allowed(previous: Option<&str>, next: &str) -> bool {
-    match (previous, next) {
-        (None, "ingest") => true,
-        (Some("ingest"), "classification") => true,
-        (Some("classification"), "reconciliation") => true,
-        (Some("classification"), "adjustment") => true,
-        (Some("reconciliation"), "adjustment") => true,
-        (Some("adjustment"), "adjustment") => true,
-        _ => false,
-    }
+    matches!(
+        (previous, next),
+        (None, "ingest")
+            | (Some("ingest"), "classification")
+            | (Some("classification"), "reconciliation")
+            | (Some("classification"), "adjustment")
+            | (Some("reconciliation"), "adjustment")
+            | (Some("adjustment"), "adjustment")
+    )
 }

crates/ledgerr-mcp/src/mcp_adapter.rs

@@ -79,6 +79,7 @@ pub const TOOL_GROUP_AUDIT: &[&str] = &[QUERY_AUDIT_LOG_TOOL];
 pub const TOOL_GROUP_ONTOLOGY_WRITE: &[&str] =
     &[ONTOLOGY_UPSERT_ENTITIES_TOOL, ONTOLOGY_UPSERT_EDGES_TOOL];
 
+#[allow(clippy::vec_init_then_push)]
 pub fn tool_names() -> Vec<String> {
     let mut features = Vec::new();
 
@@ -109,31 +110,31 @@ pub fn tool_names() -> Vec<String> {
 pub fn tool_names_for(features: &[&str]) -> Vec<String> {
     let mut tools = Vec::new();
 
-    if features.iter().any(|f| *f == "core") {
+    if features.contains(&"core") {
         tools.extend(TOOL_GROUP_CORE.iter().map(|s| s.to_string()));
     }
-    if features.iter().any(|f| *f == "ontology") || features.iter().any(|f| *f == "tax") {
+    if features.contains(&"ontology") || features.contains(&"tax") {
         tools.extend(TOOL_GROUP_ONTOLOGY.iter().map(|s| s.to_string()));
     }
-    if features.iter().any(|f| *f == "reconciliation") || features.iter().any(|f| *f == "tax") {
+    if features.contains(&"reconciliation") || features.contains(&"tax") {
         tools.extend(TOOL_GROUP_RECONCILIATION.iter().map(|s| s.to_string()));
     }
-    if features.iter().any(|f| *f == "hsm") || features.iter().any(|f| *f == "tax") {
+    if features.contains(&"hsm") || features.contains(&"tax") {
         tools.extend(TOOL_GROUP_HSM.iter().map(|s| s.to_string()));
     }
-    if features.iter().any(|f| *f == "events") || features.iter().any(|f| *f == "tax") {
+    if features.contains(&"events") || features.contains(&"tax") {
         tools.extend(TOOL_GROUP_EVENTS.iter().map(|s| s.to_string()));
     }
-    if features.iter().any(|f| *f == "classification") {
+    if features.contains(&"classification") {
         tools.extend(TOOL_GROUP_CLASSIFICATION.iter().map(|s| s.to_string()));
     }
-    if features.iter().any(|f| *f == "tax") {
+    if features.contains(&"tax") {
         tools.extend(TOOL_GROUP_TAX.iter().map(|s| s.to_string()));
     }
-    if features.iter().any(|f| *f == "audit") {
+    if features.contains(&"audit") {
         tools.extend(TOOL_GROUP_AUDIT.iter().map(|s| s.to_string()));
     }
-    if features.iter().any(|f| *f == "ontology") {
+    if features.contains(&"ontology") {
         tools.extend(TOOL_GROUP_ONTOLOGY_WRITE.iter().map(|s| s.to_string()));
     }
 
@@ -653,7 +654,7 @@ pub fn handle_ingest_pdf<T: TurboLedgerTools>(
                 request
                     .extracted_rows
                     .iter()
-                    .map(|row| deterministic_tx_id(row))
+                    .map(deterministic_tx_id)
                     .collect::<Vec<_>>()
             } else {
                 response.tx_ids

crates/ledgerr-mcp/src/plugin_info.rs

@@ -1,16 +1,16 @@
-/// plugin_info — version check, host metadata, decision log, and (Windows-only) self-update.
-///
-/// The `plugin_info` MCP tool is always available and returns:
-///   - current embedded version
-///   - latest GitHub release version (when reachable)
-///   - whether an update is available
-///   - host system metadata
-///   - path to the decision/update log
-///
-/// Subcommands (passed as the optional `subcommand` argument):
-///   - `"check"` (default) — version info + host metadata
-///   - `"upgrade"` — Windows-only; downloads and applies the latest release
-///   - `"cleanup"` — removes `*.old.exe` and `*.new.exe` backup files
+//! plugin_info — version check, host metadata, decision log, and (Windows-only) self-update.
+//!
+//! The `plugin_info` MCP tool is always available and returns:
+//!   - current embedded version
+//!   - latest GitHub release version (when reachable)
+//!   - whether an update is available
+//!   - host system metadata
+//!   - path to the decision/update log
+//!
+//! Subcommands (passed as the optional `subcommand` argument):
+//!   - `"check"` (default) — version info + host metadata
+//!   - `"upgrade"` — Windows-only; downloads and applies the latest release
+//!   - `"cleanup"` — removes `*.old.exe` and `*.new.exe` backup files
 
 use std::path::PathBuf;
 use std::time::{SystemTime, UNIX_EPOCH};
@@ -108,6 +108,7 @@ pub fn host_metadata() -> Value {
         .map(|n| n.get())
         .unwrap_or(0);
 
+    #[cfg_attr(not(target_os = "windows"), allow(unused_mut))]
     let mut meta = json!({
         "os": std::env::consts::OS,
         "arch": std::env::consts::ARCH,
@@ -386,6 +387,7 @@ fn strip_zone_identifier(path: &std::path::Path) {
 }
 
 /// BLAKE3 hex digest of a file's contents; returns `""` on any I/O error.
+#[cfg(all(target_os = "windows", feature = "self-update"))]
 fn blake3_file(path: &std::path::Path) -> String {
     std::fs::read(path)
         .map(|bytes| blake3::hash(&bytes).to_hex().to_string())
@@ -557,6 +559,7 @@ mod tests {
         assert!(schema["properties"]["subcommand"]["enum"].is_array());
     }
 
+    #[cfg(all(target_os = "windows", feature = "self-update"))]
     #[test]
     fn blake3_file_empty_for_missing_path() {
         assert_eq!(blake3_file(std::path::Path::new("/no/such/file.bin")), "");

crates/ledgerr-mcp/tests/phase6_mcp_exposure_gaps.rs

@@ -1,5 +1,5 @@
-#![cfg(phase6_gap_tests)]
 #![allow(unexpected_cfgs)]
+#![cfg(phase6_gap_tests)]
 
 /// Phase 6: MCP Exposure Gaps — Failing Test Suite
 ///