fix: apply review feedback - doc comment, workbook headers, verify test

- parser.rs: convert outer doc comment to inner module doc (//!) and move before use statements
- ledger_ops.rs: fix write_sheet to use correct headers matching TxProjectionRow fields (tx_id, account_id, date, amount, description, source_ref) and write all field values
- verify.rs: make test_verification_rejected_low_confidence actually invoke verifier.verify() and assert !is_approved()

Agent-Logs-Url: https://github.com/PromptExecution/l3dg3rr/sessions/b1a08908-ae43-4870-9678-d6b9ef09c136

Co-authored-by: elasticdotventures <35611074+elasticdotventures@users.noreply.github.com>

Author: Copilot

crates/ledger-core/src/ledger_ops.rs

@@ -456,15 +456,29 @@ impl LedgerOperation for ExportWorkbookOp {
                 .map_err(|e| LedgerOpError::Workbook(e.to_string()))?;
             ws.write_string(0, 0, "tx_id")
                 .map_err(|e| LedgerOpError::Workbook(e.to_string()))?;
-            ws.write_string(0, 1, "category")
+            ws.write_string(0, 1, "account_id")
                 .map_err(|e| LedgerOpError::Workbook(e.to_string()))?;
-            ws.write_string(0, 2, "reason")
+            ws.write_string(0, 2, "date")
+                .map_err(|e| LedgerOpError::Workbook(e.to_string()))?;
+            ws.write_string(0, 3, "amount")
+                .map_err(|e| LedgerOpError::Workbook(e.to_string()))?;
+            ws.write_string(0, 4, "description")
+                .map_err(|e| LedgerOpError::Workbook(e.to_string()))?;
+            ws.write_string(0, 5, "source_ref")
                 .map_err(|e| LedgerOpError::Workbook(e.to_string()))?;
             for (idx, row) in rows.iter().enumerate() {
                 let r = (idx + 1) as u32;
                 ws.write_string(r, 0, &row.tx_id)
                     .map_err(|e| LedgerOpError::Workbook(e.to_string()))?;
-                ws.write_string(r, 2, &row.source_ref)
+                ws.write_string(r, 1, &row.account_id)
+                    .map_err(|e| LedgerOpError::Workbook(e.to_string()))?;
+                ws.write_string(r, 2, &row.date)
+                    .map_err(|e| LedgerOpError::Workbook(e.to_string()))?;
+                ws.write_string(r, 3, &row.amount)
+                    .map_err(|e| LedgerOpError::Workbook(e.to_string()))?;
+                ws.write_string(r, 4, &row.description)
+                    .map_err(|e| LedgerOpError::Workbook(e.to_string()))?;
+                ws.write_string(r, 5, &row.source_ref)
                     .map_err(|e| LedgerOpError::Workbook(e.to_string()))?;
             }
             Ok(())

crates/ledger-core/src/verify.rs

@@ -247,20 +247,18 @@ mod tests {
     fn test_verification_rejected_low_confidence() {
         let proposer_json =
             r#"{"rule_id":"test","proposed_fix":"x","reasoning":"y","confidence":0.5}"#;
+        // Reviewer confidence 0.6 is below the 0.80 threshold → must force rejection
         let reviewer_json =
             r#"{"approved":false,"concerns":["too risky"],"suggestions":[],"confidence":0.6}"#;
 
         let proposer = MockModelClient::default().with_response(proposer_json);
         let reviewer = MockModelClient::default().with_response(reviewer_json);
 
-        // Use higher threshold to force rejection
         let config = MultiModelConfig::default().with_threshold(0.80);
-        let _verifier = MultiModelVerifier::new(proposer, reviewer, config);
+        let verifier = MultiModelVerifier::new(proposer, reviewer, config);
 
-        // Override with mocked threshold test - manually check
-        // In real code, reviewer_json confidence 0.6 < 0.80 threshold
-        // This test shows the logic path
-        assert!(true); // Placeholder - confidence check happens in review()
+        let outcome = verifier.verify("test", "[]", "context").unwrap();
+        assert!(!outcome.is_approved());
     }
 
     #[test]

crates/mdbook-rhai-mermaid/src/parser.rs

@@ -1,13 +1,14 @@
+//! Graph-based AST for the rhai pseudo-DSL.
+//!
+//! Two statement forms are supported:
+//!   - Pipeline step:    `fn name() -> target`
+//!   - Conditional:      `if expr -> target`   where expr is e.g. `confidence > 0.8`
+//!   - Match arm:        `match expr => Arm -> target`
+//!
+//! The syntax is stable — richer identity and placement semantics are encoded
+//! in the parser output, not in a second incompatible syntax.
+
 use indexmap::IndexMap;
-/// Graph-based AST for the rhai pseudo-DSL.
-///
-/// Two statement forms are supported:
-///   - Pipeline step:    `fn name() -> target`
-///   - Conditional:      `if expr -> target`   where expr is e.g. `confidence > 0.8`
-///   - Match arm:        `match expr => Arm -> target`
-///
-/// The syntax is stable — richer identity and placement semantics are encoded
-/// in the parser output, not in a second incompatible syntax.
 use std::collections::HashMap;
 
 // ---------------------------------------------------------------------------