refactor: inline syncSubPreferences into master change handler

The syncSubPreferences helper was only invoked from the master
checkbox's change handler (disable branch) and never on init, where
initial visibility is already set server-side via Jinja. Inlining it
removes the indirection and the asymmetry between the enable and
disable paths while preserving behavior: enabling reveals the
sub-preferences and checks updates; disabling hides them and clears
both sub-preferences.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: chriscarrollsmith

templates/partials/communication_preferences_fields.html

@@ -54,23 +54,15 @@
                 return;
             }
 
-            function syncSubPreferences() {
+            master.addEventListener('change', function () {
                 if (master.checked) {
                     subPrefs.style.display = '';
+                    updates.checked = true;
                 } else {
                     subPrefs.style.display = 'none';
                     updates.checked = false;
                     marketing.checked = false;
                 }
-            }
-
-            master.addEventListener('change', function () {
-                if (master.checked) {
-                    subPrefs.style.display = '';
-                    updates.checked = true;
-                } else {
-                    syncSubPreferences();
-                }
             });
         });
     })();