refactor: inline syncSubPreferences into master change handler#198
Closed
chriscarrollsmith wants to merge 1 commit into
Closed
refactor: inline syncSubPreferences into master change handler#198chriscarrollsmith wants to merge 1 commit into
chriscarrollsmith wants to merge 1 commit into
Conversation
The syncSubPreferences helper was only invoked from the master checkbox's change handler (disable branch) and never on init, where initial visibility is already set server-side via Jinja. Inlining it removes the indirection and the asymmetry between the enable and disable paths while preserving behavior: enabling reveals the sub-preferences and checks updates; disabling hides them and clears both sub-preferences. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Consolidated into #197 to avoid a second CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
syncSubPreferenceshelper incommunication_preferences_fields.htmlwas only ever called from the master checkbox'schangehandler (the disable branch) and was never invoked on page load — initial sub-preference visibility is already set server-side via the Jinjastyle="display: none;"guard.comm_updates; disabling hides them and clears bothcomm_updatesandcomm_marketing.Test plan
uv run pytest tests/test_templates.py(30 passed)uv run ty check .cleanMade with Cursor