[Legacy PR #24] Support for displaying a trend line and embedding a right image (by @rahul-deepsource)#20
Open
ashrobertsdragon wants to merge 7 commits into
Open
[Legacy PR #24] Support for displaying a trend line and embedding a right image (by @rahul-deepsource)#20ashrobertsdragon wants to merge 7 commits into
ashrobertsdragon wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Author: @rahul-deepsource
Original PR: google#24
Thanks for the wonderful library!
I wanted to add the functionality to add a trend line which can graphically show how a metric has been varying over time, and thought that this would be a nice addition to this library as well!
Here are a bunch of changes:
show-trendargument which takes in comma-separated list of values (maximum: 10).--right-imagewhich would display an image (110 x 14) between left and right text.--left-colorto--bg-colorbecause this was also the background for theright_image, so it didn't really make sense to call itleft-color.left-colorwhich would add aHere is an example:
which was generated using the command:
There are still a few tests failing (and docs missing). If you give me a green flag that you intend to merge these changes, I'd be happy to provide them as well! :)