Merge branch 'IDTEAM-4850-web-the-edit-vault-button-should-be-hidden-for-the-vault-with-editor-access-same-as-in-i-os' into 'main'

Hide the "Edit Vault" button when the user it was shared with is not an admin.

See merge request web/clients!25566

Author: MargeBot

packages/pass/components/Menu/Vault/VaultMenu.tsx

@@ -49,7 +49,6 @@ export const VaultMenu: FC<Props> = ({ render, onAction = noop }) => {
                         count={vault.count}
                         label={vault.content.name}
                         selected={scope === 'share' && selectedShareId === vault.shareId}
-                        canEdit={isShareManageable(vault)}
                         canMove={isWritableVault(vault) && vault.count > 0}
                         canDelete={vault.owner}
                         canInvite={!vault.shared}

packages/pass/components/Menu/Vault/VaultMenuItem.tsx

@@ -29,7 +29,6 @@ import noop from '@proton/utils/noop';
 
 type Props = {
     canDelete: boolean;
-    canEdit: boolean;
     canInvite: boolean;
     canLeave: boolean;
     canManage: boolean;
@@ -55,19 +54,7 @@ const handleClickEvent = (handler?: () => void) => (evt: React.MouseEvent) => {
 };
 
 export const VaultMenuItem = memo(
-    ({
-        canDelete,
-        canEdit,
-        canInvite,
-        canLeave,
-        canManage,
-        canMove,
-        count,
-        label,
-        selected,
-        vault,
-        onAction = noop,
-    }: Props) => {
+    ({ canDelete, canInvite, canLeave, canManage, canMove, count, label, selected, vault, onAction = noop }: Props) => {
         const vaultActions = useVaultActions();
         const inviteActions = useInviteActions();
         const { moveMany } = useItemsActions();
@@ -76,7 +63,7 @@ export const VaultMenuItem = memo(
         const plan = useSelector(selectPassPlan);
         const access = useSelector(selectAccess(vault.shareId));
 
-        const withActions = canEdit || canDelete || canInvite || canManage || canLeave || canMove;
+        const withActions = canDelete || canInvite || canManage || canLeave || canMove;
 
         const onManage = pipe(() => inviteActions.manageVaultAccess(vault.shareId), onAction);
         const onEdit = pipe(() => vaultActions.edit(vault), onAction);
@@ -176,13 +163,14 @@ export const VaultMenuItem = memo(
                 quickActions={
                     withActions
                         ? [
-                              <DropdownMenuButton
-                                  key="vault-edit"
-                                  disabled={!onEdit}
-                                  label={c('Action').t`Edit vault`}
-                                  icon="pen"
-                                  onClick={handleClickEvent(onEdit)}
-                              />,
+                              canManage && (
+                                  <DropdownMenuButton
+                                      key="vault-edit"
+                                      label={c('Action').t`Edit vault`}
+                                      icon="pen"
+                                      onClick={handleClickEvent(onEdit)}
+                                  />
+                              ),
 
                               vault.shared && (
                                   <DropdownMenuButton