Fix review feedback: correct PrivateKeyCiphertext API, remove non-public estimateDeploymentFee, fix polling pattern and submitTransaction consistency

Author: marshacb

.agents/skills/aleo-sdk-builder/scripts/verify-execution.ts

@@ -30,8 +30,8 @@ function verifyExecution(filePath: string): { valid: boolean; errors: string[];
     }
 
     // Check for DPS without unnecessary initThreadPool
-    if (content.includes("buildAuthorization") && content.includes("initThreadPool")) {
-        warnings.push("initThreadPool() found alongside DPS (buildAuthorization). Thread pool is not needed for delegated proving.");
+    if ((content.includes("buildAuthorization") || content.includes("provingRequest")) && content.includes("initThreadPool")) {
+        warnings.push("initThreadPool() found alongside DPS (buildAuthorization/provingRequest). Thread pool is not needed for delegated proving.");
     }
 
     // Check for key provider setup when doing local proving

docs/sdk-guide/README.md

@@ -96,8 +96,8 @@ Multi-threading is not required for all contexts:
 
 ### Fee Management
 
-- NEVER hardcode fee amounts — always use `estimateExecutionFee()` or `estimateDeploymentFee()`
-  or `estimateFeeForAuthorization()` to get the base fee
+- NEVER hardcode fee amounts — use `estimateExecutionFee()` or `estimateFeeForAuthorization()`
+  to get the base fee. Deployment fees are estimated automatically by `buildDeploymentTransaction`.
 - Always include a `priorityFee` parameter (even if 0)
 - Handle insufficient balance errors before attempting transactions:
   ```ts
@@ -129,8 +129,8 @@ Multi-threading is not required for all contexts:
   for (let i = 0; i < 60; i++) {
       try {
           const result = await client.getTransaction(txId);
-          if (result) { confirmed = true; break; }
-      } catch { /* not confirmed yet */ }
+          confirmed = true; break;  // if getTransaction succeeds, the tx is confirmed
+      } catch { /* throws when not found — not confirmed yet */ }
       await new Promise(r => setTimeout(r, 2000));
   }
   ```

docs/sdk-guide/delegated-proving.md

@@ -105,7 +105,7 @@ const tx = await pm.buildTransactionFromAuthorization({
     feeAuthorization,
 });
 
-const txId = await pm.networkClient.submitTransaction(tx.toString());
+const txId = await pm.networkClient.submitTransaction(tx);
 ```
 
 > **Note:** `buildTransactionFromAuthorization` performs **local proving** via

docs/sdk-guide/deployment.md

@@ -31,6 +31,7 @@ const txId = await pm.networkClient.submitTransaction(tx);
 
 ```bash
 cargo install leo-lang
+# Standard devnet-only key — not used on mainnet
 leo devnode start --private-key APrivateKey1zkp8CZNn3yeCseEtxuVPbDCwSyhGW6yZKUYKfgXmcpoGPWH
 ```
 
@@ -52,7 +53,7 @@ const execTx = await pm.buildDevnodeExecutionTransaction({
     priorityFee: 0,
     privateFee: false,
 });
-await pm.networkClient.submitTransaction(execTx.toString());
+await pm.networkClient.submitTransaction(execTx);
 ```
 
 Note: `buildDevnodeExecutionTransaction` takes an `ExecuteOptions` object (same shape

docs/sdk-guide/keys-and-crypto.md

@@ -43,16 +43,18 @@ pm.setKeyStore(keyStore);
 Never store plaintext private keys. Use `PrivateKeyCiphertext`:
 
 ```ts
-import { PrivateKeyCiphertext } from "@provablehq/sdk/testnet.js";
+import { PrivateKey, PrivateKeyCiphertext } from "@provablehq/sdk/testnet.js";
 
 // Encrypt for storage
-const encrypted = PrivateKeyCiphertext.encryptPrivateKey(privateKey, password);
+const encrypted = privateKey.toCiphertext(password);
 const encryptedString = encrypted.toString();
 // Store encryptedString safely (file, database, env var)
 
 // Decrypt when needed
-const restored = PrivateKeyCiphertext.fromString(encryptedString)
-    .decryptToPrivateKey(password);
+const restored = PrivateKey.fromPrivateKeyCiphertext(
+    PrivateKeyCiphertext.fromString(encryptedString),
+    password,
+);
 ```
 
 ## Custom Cryptography (libsodium)