Fixing wasm-opt#1160
Open
Pauan wants to merge 1 commit into
Open
Conversation
Member
iamalwaysuncomfortable
left a comment
iamalwaysuncomfortable
left a comment
There was a problem hiding this comment.
It seems like the wasm tests failed here, but once we that's solved we'll bench this against previous large function proving benchmarks to see what the speed improvement wasm-opt provides. With any luck it should speed up proving times.
Collaborator
Author
|
@iamalwaysuncomfortable Yeah, I'm still investigating that, wasm-opt is very finicky sometimes. |
iamalwaysuncomfortable
added this to the
v0.10.2 - Proving Performance Speedups + AI Agent Tooling milestone
iamalwaysuncomfortable
added
rust
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7b6afbc. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Medium risk because it changes the WASM build optimization flags and
wasm-packtest invocation, which can affect produced artifacts and CI behavior; the rest is mostly dependency and GitHub Actions version bumps.Overview
Updates CI and build tooling across the repo. GitHub Actions workflows/actions are bumped to newer major versions (checkout/setup-node/cache/artifact/github-script) and most jobs switch to
ubuntu-latestrunners.Adjusts WASM packaging/testing and modernizes dependencies.
wasm/build.jsdrops somewasm-optflags andwasm/test.jsnow runswasm-pack testin release mode with--no-default-featuresand explicitbrowser,<network>features. The PR also updates the Rust nightly, upgrades TypeScript (and various JS build/lint deps) acrosssdk,wasm,website, andcreate-leo-apptemplates, and tweaks TS configs/imports for Node ESM compatibility (e.g.,node:builtins,types: ["node"], bundler module resolution).Reviewed by Cursor Bugbot for commit d231490. Bugbot is set up for automated code reviews on this repo. Configure here.