Skip to content

Commit 741ced4

Browse files
committed
search bar theming close enough
Signed-off-by: Joseph Mattiello <git@joemattiello.com> update todods Signed-off-by: Joseph Mattiello <git@joemattiello.com>
1 parent 3f86849 commit 741ced4

2 files changed

Lines changed: 21 additions & 27 deletions

File tree

PVThemes/Sources/PVThemes/ThemeApplier.swift

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ public extension ThemeManager {
6565
configureTabBar(palette)
6666
configureTableViews(palette)
6767
configureTextInputs(palette)
68+
configureUISearchBar(palette)
6869
configureUIView(palette)
6970
configureUIWindow(palette)
7071

@@ -182,8 +183,26 @@ public extension ThemeManager {
182183
private class func configureTextInputs(_ palette: any UXThemePalette) {
183184
UITextField.appearance().keyboardAppearance = palette.keyboardAppearance
184185
UISearchBar.appearance().keyboardAppearance = palette.keyboardAppearance
186+
187+
UITextField.appearance().backgroundColor = palette.gameLibraryBackground
188+
UITextField.appearance().textColor = palette.gameLibraryText
189+
185190
DLOG("Text inputs - keyboardAppearance: \(palette.keyboardAppearance)")
186191
}
192+
193+
@MainActor
194+
private class func configureUISearchBar(_ palette: any UXThemePalette) {
195+
UISearchBar.appearance().backgroundColor = palette.menuBackground
196+
UISearchBar.appearance().tintColor = palette.menuText
197+
UISearchBar.appearance().barTintColor = palette.menuBackground
198+
UISearchBar.appearance().searchTextField.textColor = palette.menuText
199+
UISearchTextField.appearance().tokenBackgroundColor = palette.menuHeaderBackground
200+
UISearchTextField.appearance().tintColor = palette.menuIconTint
201+
UISearchTextField.appearance().textColor = palette.menuText
202+
203+
DLOG("UISearchBar - backgroundColor: \(palette.settingsCellBackground?.debugDescription ?? "nil"), tintColor: \(palette.gameLibraryText.debugDescription)")
204+
}
205+
187206

188207
@MainActor
189208
private class func configureActionSheets(_ palette: any UXThemePalette) {

TODO.md

Lines changed: 2 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -3,33 +3,7 @@ _My personal TODO notes_
33

44
## Show stoppers
55

6-
- [X] RetroArch GLES cores are crashing?
7-
- [X] moveable button joystick and dpad move at the same time
8-
- [X] Delete isn't deleting
9-
- [X] throw an error on file manager error
10-
- [X] audio is fucked
11-
- [X] 4X multisampling crashes Mupen on iPad, (iphone?)
12-
- [X] Refresh library and conflicts on new UI not working
13-
- [X] UI is unresponsive after closing emulator
14-
- [X] wrap advanced settings in freemiumview
15-
- [X] fix launching webserver from swiftui menu
16-
- [X] iCloud sync isn't working, remove or fix
17-
- [X] Swift UI long press on roms menu missing actions {rename, ~~share~~}
18-
- [X] Progress hud on unzips isn't hiding
19-
- [X] Themes setting doesn't work
20-
- [X] Conflicts folder is weird
21-
- [X] SwiftUI not seeing conflicts
22-
- [X] Copy the framework loader from old branch, fix it too!
23-
- [X] emuThreeDS and other metal based cores have wrong layout contraints
24-
- [X] Possible race condition in importer
25-
- [X] Gambatte swift module not done
26-
- [X] PVmGBA swift module is not done
27-
- [X] Fix Repo submodules
28-
- [X] Audio broken
29-
- [X] Loading save states crashes realm
30-
- [X] Creating save states crashes realm
31-
- [X] SwiftUI not importing roms correctly
32-
- [X] compiling with Mupen+Rumble.swift breaks device release builds
6+
- [ ] Shared documents : return FileManager.default.containerURL(forSecurityApplicationGroupIdentifier: PVAppGroupId)
337

348
## Major bugs
359

@@ -90,6 +64,7 @@ _My personal TODO notes_
9064
- [ ] Game text not themed
9165
- [ ] New import indicator not themed
9266
- [ ] Make GameMoreInfoVC and it's equivlant PageViewController into native swifttUI with editing of properties
67+
- [ ] App Group containers in Catalyst "public class var appGroupContainer"
9368

9469
## Cores to translate
9570

0 commit comments

Comments
 (0)