Skip to content

Commit 8e570a9

Browse files
fix: address Copilot review — pin commit hash in changelog, document submodule update workflow
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 178040a commit 8e570a9

2 files changed

Lines changed: 22 additions & 1 deletion

File tree

.changelog/3447.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
### Changed
2-
- **DuckStation submodule** — Switched submodule URL from upstream `stenzek/duckstation` to the Provenance-Emu fork and updated to latest master (2026-03-20).
2+
- **DuckStation submodule** — Switched submodule URL from upstream `stenzek/duckstation` to the Provenance-Emu fork and updated to commit `125c3ec70fd1b4fdcf61d52500e5afad72be17e5` on `master` (as of 2026-03-20).

DEVELOPER.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,27 @@ auto-enable them once JIT is successfully acquired:
103103
The app layer (#2794) will query `EmulatorCoreInfoPlist.jitDisabledWithoutJIT` to find
104104
these cores and toggle them on when a JIT entitlement is obtained.
105105

106+
## Submodule Management
107+
108+
Provenance uses git submodules for emulator cores. Each core submodule is pinned to a specific commit (the gitlink in the tree). Some submodules also specify a `branch` in `.gitmodules`; this affects `git submodule update --remote` but **not** normal checkouts, which always use the pinned commit.
109+
110+
### Updating a Core Submodule to Fork HEAD
111+
112+
When a Provenance-Emu fork submodule has a `branch = <name>` entry and you want to advance it:
113+
114+
```bash
115+
# Sync just that submodule to the remote branch HEAD
116+
git submodule update --remote --merge Cores/<CoreName>/<submodule-dir>
117+
118+
# Review the new commit, then stage and commit
119+
git add Cores/<CoreName>/<submodule-dir>
120+
git commit -m "chore(<corename>): update submodule to <short-sha>"
121+
```
122+
123+
Record the resulting commit hash in the changelog entry for traceability.
124+
125+
> **Note:** `git submodule update` (without `--remote`) always checks out the pinned gitlink commit, ignoring `branch`. Only `--remote` advances to the branch tip.
126+
106127
## Building
107128

108129
### Setup Code Signing

0 commit comments

Comments
 (0)