[Agent] feat(mupen64plus): add XcodeGen project.yml for dual SPM+Xcode builds by github-actions[bot] · Pull Request #3465 · Provenance-Emu/Provenance

github-actions · 2026-03-24T22:55:34Z

Summary

Adds an XcodeGen project.yml for the Mupen64Plus core package so both SPM and XcodeGen-generated Xcode build paths are supported side-by-side.

What's included

Cores/Mupen64Plus/project.yml — XcodeGen spec that mirrors the existing Package.swift
All 11 targets mapped: PVMupen, PVMupenBridge, PVMupen64PlusCore, PVRSPCXD4, PVMupen64PlusRspHLE, SDL, libpng, glidenhq, gliden_osd, PVMupen64PlusVideoGlideN64, PVMupen64PlusVideoRice
Build settings from Config.xcconfig and Package.swift merged into project.yml
iOS + tvOS targets with platform-appropriate GLES defines

How to use

SPM build (existing, unchanged):

cd Cores/Mupen64Plus
swift build

XcodeGen build (new):

cd Cores/Mupen64Plus
xcodegen generate   # regenerates PVMupen64Plus.xcodeproj from project.yml
open PVMupen64Plus.xcodeproj

Once the project.yml is validated and the XcodeGen-generated project confirmed to build, the hand-crafted project.pbxproj can be replaced with the generated one and future changes go through project.yml only.

What still needs human validation

Run xcodegen generate locally and confirm the project opens/builds in Xcode
The includes: filter in XcodeGen is informational — XcodeGen may not honour explicit file lists; may need to use excludes: instead for files that shouldn't compile
Confirm NEON/non-NEON source selection works on simulator vs device
Validate PVMupen64PlusVideoRice path (Sources/Plugins/Video/rice/rice/src) is correct

Notes

Does not remove or modify the existing project.pbxproj — this PR is additive only
The PVMupen64PlusVideoRice and PVMupen64PlusRspHLE targets are defined in project.yml but are currently commented out in Package.swift (disabled in the main product) — they're preserved here for future use

Part of #2856

Test plan

cd Cores/Mupen64Plus && xcodegen generate — no errors
Generated .xcodeproj opens in Xcode 16+ without errors
iOS simulator build compiles cleanly
tvOS simulator build compiles cleanly
swift build still works (SPM path unchanged)

🤖 Generated with Claude Code

github-actions · 2026-03-24T22:55:52Z

🤖 PR created. AI review starting automatically.

Copilot

Pull request overview

Adds an XcodeGen spec for the Mupen64Plus core package to support generating an Xcode project alongside the existing SwiftPM build, plus a changelog fragment documenting the addition.

Changes:

Introduces Cores/Mupen64Plus/project.yml defining 11 XcodeGen targets intended to mirror Package.swift.
Adds a .changelog/2856.md fragment describing the new XcodeGen support.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.

File	Description
`Cores/Mupen64Plus/project.yml`	New XcodeGen project spec for dual SPM + generated-Xcode builds of Mupen64Plus and plugins
`.changelog/2856.md`	Changelog entry for adding XcodeGen support

Copilot · 2026-03-25T00:27:35Z

+settings:
+  base:
+    ALLOW_TARGET_PLATFORM_SPECIALIZATION: YES
+    SUPPORTED_PLATFORMS: "iphoneos iphonesimulator appletvos appletvsimulator"
+    SWIFT_VERSION: "5.0"
+    CLANG_CXX_LANGUAGE_STANDARD: "gnu++11"
+    GCC_C_LANGUAGE_STANDARD: "gnu99"
+    # Common preprocessor defines (all platforms)
+    GCC_PREPROCESSOR_DEFINITIONS:
+      - "$(inherited)"
+      - "__unix__=1"
+      - "GCC=1"
+      - "GLES_SILENCE_DEPRECATION=1"
+      - "GL_SILENCE_DEPRECATION=1"
+      - "M64P_PLUGIN_PROTOTYPES=1"
+      - "MUPENPLUSAPI=1"
+      - "M64P_PLUGIN_API=1"
+      - "IN_OPENEMU=1"
+      - "PIC=1"
+      - "M64P_PARALLEL=1"
+      - "NO_ASM=1"
+      - "PROVENANCE=1"
+      - "TXFILTER_LIB=1"
+      - "VFP_HARD=1"
+    OTHER_CFLAGS: "$(inherited) -fno-strict-aliasing -fvisibility=hidden -fomit-frame-pointer -fvisibility-inlines-hidden -fPIC"


settings.base is described as mirroring sharedCSettings from Package.swift, but it omits several SDK-specific build settings currently provided by Config.xcconfig (e.g. GCC_PREPROCESSOR_DEFINITIONS[sdk=iphoneos*] for OS_IOS/GLESX/USE_GLES/NEON, and the tvOS simulator EXCLUDED_SOURCE_FILE_NAMES/INCLUDED_SOURCE_FILE_NAMES rules). Without pulling in Config.xcconfig (via XcodeGen configFiles) or re-expressing those as conditional build settings in YAML, the generated project will compile with different flags and likely fail or behave differently on sim/device.

Copilot · 2026-03-25T00:27:36Z

+    dependencies:
+      - target: PVMupenBridge
+      - target: PVMupen64PlusCore
+      - target: PVRSPCXD4
+    settings:


PVMupen depends on several external package products in Package.swift (PVAudio, PVCoreBridge, PVEmulatorCore, PVSupport, PVLogging, PVPlists, PVCoreObjCBridge, etc.), but this XcodeGen spec only lists intra-project target dependencies and does not define any packages: entries. As-is, the generated project won’t build because those modules won’t be resolvable; add the local package references and declare them as target dependencies.

Copilot · 2026-03-25T00:27:36Z

+      linkerFlags:
+        - "-lz"


linkerFlags: is not a supported XcodeGen key under settings (XcodeGen expects build setting names like OTHER_LDFLAGS or dependencies: - sdk: libz.tbd). This will be ignored or cause spec validation errors, and -lz may not be linked as intended.

Copilot · 2026-03-25T00:27:36Z

+      linkerFlags:
+        - "-lz"
+      sdk:
+        iOS:
+          OTHER_LDFLAGS: "-framework OpenGLES"


linkerFlags: and settings.sdk: are not valid in XcodeGen’s settings schema. If you need -lz / OpenGLES linkage, express it via supported build settings (e.g. OTHER_LDFLAGS with [sdk=...] conditionals) and/or dependencies: - sdk: .... As written, XcodeGen will ignore or reject these keys and the target may fail to link.

Copilot · 2026-03-25T00:27:36Z

+      linkerFlags:
+        - "-lz"


linkerFlags: is not a supported XcodeGen key under settings (same issue as other targets). Use a supported approach like dependencies: - sdk: libz.tbd or set OTHER_LDFLAGS in settings.base.

Copilot · 2026-03-25T00:27:36Z

@@ -0,0 +1,2 @@
+### Added
+- **Mupen64Plus XcodeGen support** — Added `project.yml` for the Mupen64Plus core package, enabling Xcode project regeneration via `xcodegen generate` alongside the existing SPM `Package.swift` build path. Both build paths are now supported side-by-side.


Changelog fragment entries should be plain English with no trailing period (see .changelog/README.md). This bullet ends with a period and is multiple sentences; please trim to a single sentence and drop the trailing punctuation to match consolidation style.

Suggested change

- **Mupen64Plus XcodeGen support** — Added `project.yml` for the Mupen64Plus core package, enabling Xcode project regeneration via `xcodegen generate` alongside the existing SPM `Package.swift` build path. Both build paths are now supported side-by-side.

- **Mupen64Plus XcodeGen support** — Added `project.yml` for the Mupen64Plus core package to enable Xcode project regeneration via `xcodegen generate` alongside the existing SPM `Package.swift` build path, supporting both build paths side-by-side

Copilot · 2026-03-25T00:27:37Z

+      linkerFlags:
+        - "-lz"


linkerFlags: is not a supported XcodeGen key under settings (same schema issue as in other targets). Use supported build settings (e.g. OTHER_LDFLAGS) or an SDK dependency (libz.tbd) to ensure zlib is linked.

Copilot · 2026-03-25T00:27:37Z

+  # glidenhq — GlideN64 texture enhancement library
+  # ===========================================================================
+  glidenhq:
+    type: framework


glidenhq is declared as type: framework, but the existing PVMupen64Plus.xcodeproj builds it as a static library (com.apple.product-type.library.static). If the goal is a drop-in replacement for the current project, consider type: library.static here as well to keep linking/embedding consistent.

Suggested change

type: framework

type: library.static

Copilot · 2026-03-25T00:27:37Z

+  base:
+    ALLOW_TARGET_PLATFORM_SPECIALIZATION: YES
+    SUPPORTED_PLATFORMS: "iphoneos iphonesimulator appletvos appletvsimulator"
+    SWIFT_VERSION: "5.0"


This spec sets SWIFT_VERSION to 5.0, but the package uses // swift-tools-version: 6.0 in Package.swift. For consistency with the package toolchain, consider removing this override (inherit Xcode’s default) or updating it to Swift 6; forcing Swift 5 language mode here can cause the XcodeGen build to diverge from the SPM build.

Suggested change

SWIFT_VERSION: "5.0"

SWIFT_VERSION: "6.0"

Copilot · 2026-03-25T00:27:37Z

+  # libpng — PNG library (bundled)
+  # ===========================================================================
+  libpng:
+    type: framework


libpng is declared as type: framework, but the existing PVMupen64Plus.xcodeproj builds libpng as a static library (com.apple.product-type.library.static). If this XcodeGen project is intended to replace/align with the current project output, consider switching this target to type: library.static to avoid changing the artifact type and embedding/linking behavior.

Suggested change

type: framework

type: library.static

JoeMatt · 2026-03-25T00:56:57Z

@claude please validate copilot review issues, improve, fix and then self-re review and mark copilot for re-review

github-actions · 2026-03-25T00:57:18Z

Fixes applied - see PR comment for details. Awaiting Copilot re-review.

github-actions · 2026-03-25T01:01:08Z

✅ Fixes pushed — addressed all 10 Copilot review comments:

SWIFT_VERSION updated from 5.0 → 6.0 to match Package.swift toolchain
packages: section added with all PV* local dependencies (PVAudio, PVCoreBridge, PVCoreObjCBridge, PVEmulatorCore, PVLogging, PVObjCUtils, PVPlists, PVSupport)
Package products wired as dependencies in PVMupen and PVMupenBridge targets
SDK-specific GCC_PREPROCESSOR_DEFINITIONS[sdk=...] added for iOS/tvOS GLES/NEON/OS_IOS/USE_GLES* defines (mirrors sharedCSettings .when(platforms:) from Package.swift)
linkerFlags: replaced with OTHER_LDFLAGS in settings.base for libpng, glidenhq, PVMupen64PlusVideoGlideN64, PVMupen64PlusVideoRice
Invalid sdk: key in PVMupen64PlusVideoGlideN64 replaced with OTHER_LDFLAGS: -framework OpenGLES in settings.base
libpng and glidenhq changed from type: framework → type: library.static to match existing project.pbxproj artifact type
Changelog entry fixed: single sentence, no trailing period

github-actions · 2026-03-25T01:09:25Z

✅ Fixes pushed — addressed all remaining Copilot review issues

Changes made in this round:

Added SDK-conditional OTHER_CFLAGS for iphoneos/iphonesimulator/appletvos/appletvsimulator (mirrors Config.xcconfig)
Added EXCLUDED_SOURCE_FILE_NAMES[sdk=appletvos*] to exclude non-NEON sources on tvOS device
Added EXCLUDED/INCLUDED_SOURCE_FILE_NAMES[sdk=appletvsimulator*] for tvOS simulator stub builds
Added GCC_PREPROCESSOR_DEFINITIONS[sdk=macosx*] for macOS/Catalyst builds
Converted OTHER_LDFLAGS: -lz to dependencies: sdk: libz.tbd (XcodeGen-idiomatic)
Converted OTHER_LDFLAGS: -framework OpenGLES to dependencies: sdk: OpenGLES.framework

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Copilot · 2026-03-25T01:26:32Z

+          - "osal_dynamiclib_unix.c"
+          - "osal_files_unix.c"
+    dependencies:
+      - target: libpng


PVMupen64PlusVideoRice is missing the SDL target dependency, but in Package.swift it depends on SDL and the Rice sources include/use SDL APIs. Without linking SDLStubs.m, the XcodeGen build is likely to fail with undefined SDL symbols. Add - target: SDL to this target’s dependencies (or otherwise ensure SDL stubs are linked).

Suggested change

- target: libpng

- target: libpng

- target: SDL

Copilot · 2026-03-25T01:26:32Z

+  # Allow multi-platform targets
+  allowedOverridesForPlatformSpecialization: true


options.allowedOverridesForPlatformSpecialization is not a valid XcodeGen project spec key (XcodeGen 2.36+). This will cause xcodegen generate to fail or ignore the intended behavior. Remove this option; multi-platform targets are already covered by platform: [iOS, tvOS] (or use supportedDestinations if you adopt a newer XcodeGen).

Suggested change

# Allow multi-platform targets

allowedOverridesForPlatformSpecialization: true

Copilot · 2026-03-25T01:26:32Z

+        excludes:
+          - "CorePlist-Generated.swift"
+    dependencies:
+      - target: PVMupenBridge
+      - target: PVMupen64PlusCore


PVMupen excludes CorePlist-Generated.swift, but CorePlist.swift references the generated CorePlist enum. With this exclusion the XcodeGen-generated project will fail to compile unless you add a build script to generate and include that file from Derived Sources. Either include CorePlist-Generated.swift in sources, or add a SwiftGen build step and point its output to a compiled sources directory.

Suggested change

excludes:

- "CorePlist-Generated.swift"

dependencies:

- target: PVMupenBridge

- target: PVMupen64PlusCore

dependencies:

- target: PVMupenBridge

- target: PVMupen64PlusCore

- target: PVMupenBridge

- target: PVMupen64PlusCore

JoeMatt · 2026-03-25T01:36:12Z

@claude please validate copilot review issues, improve, fix and then self-re review and mark copilot for re-review

github-actions · 2026-03-25T01:40:07Z

✅ Fixes pushed — addressed all actionable Copilot review issues

Changes made to Cores/Mupen64Plus/project.yml:

Removed invalid allowedOverridesForPlatformSpecialization: true options key (not a valid XcodeGen spec key; ALLOW_TARGET_PLATFORM_SPECIALIZATION in settings.base already covers this)
Removed CorePlist-Generated.swift from PVMupen excludes — file is already committed to the source tree, not dynamically generated at build time
Added - target: SDL dependency to PVMupen64PlusVideoRice — Rice sources include SDL APIs and need the stub linked

Pre-existing / already-correct items (no changes needed):

settings.base already has all SDK-specific GCC_PREPROCESSOR_DEFINITIONS conditionals (lines 66–141)
packages: section already declares all PV* SPM dependencies
linkerFlags: was never present — dependencies: - sdk: pattern used correctly throughout
libpng and glidenhq are already type: library.static
SWIFT_VERSION is already "6.0" (Swift tools version matches Package.swift)

github-actions · 2026-03-25T01:46:05Z

✅ Fixes pushed — addressed all 3 Copilot review comments from second review:

allowedOverridesForPlatformSpecialization — removed invalid XcodeGen options key (not needed; multi-platform covered by platform: [iOS, tvOS])
CorePlist-Generated.swift — removed exclusion from PVMupen sources (file is committed, not build-generated)
SDL dependency for PVMupen64PlusVideoRice — added - target: SDL dependency to prevent undefined SDL symbols

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Copilot · 2026-03-25T02:26:31Z

+    OTHER_CFLAGS: "$(inherited) -fno-strict-aliasing -fvisibility=hidden -fomit-frame-pointer -fvisibility-inlines-hidden -fPIC"
+    # SDK-specific OTHER_CFLAGS (mirrors Config.xcconfig)
+    "OTHER_CFLAGS[sdk=iphoneos*]": "$(inherited) -DOS_IOS -D__VEC4_OPT -D__NEON_OPT"
+    "OTHER_CFLAGS[sdk=iphonesimulator*]": "$(inherited) -DOS_IOS"
+    "OTHER_CFLAGS[sdk=appletvos*]": "$(inherited) -DOS_IOS -D__VEC4_OPT -D__NEON_OPT"
+    "OTHER_CFLAGS[sdk=appletvsimulator*]": "$(inherited) -DOS_IOS"


Config.xcconfig sets -pthread (and other arch-level flags) in OTHER_CFLAGS[arch=*], but this XcodeGen spec never adds -pthread anywhere. That makes the XcodeGen-generated build flags materially different from the existing Xcode project and may affect compilation in code that relies on pthread-related defines.

Copilot · 2026-03-25T02:26:32Z

+          - "-fvisibility=hidden"
+          - "-fomit-frame-pointer"
+          - "-fvisibility-inlines-hidden"
+          - "-fPIC"


In Package.swift, the gliden_osd target adds additional C flags including -flto and -pthread, but this XcodeGen target's OTHER_CFLAGS list omits them. If the goal is to mirror the SPM build, consider bringing those flags across (or documenting why they are intentionally excluded for the XcodeGen path).

Suggested change

- "-fPIC"

- "-fPIC"

- "-flto"

- "-pthread"

Copilot · 2026-03-25T02:26:32Z

@@ -0,0 +1,2 @@
+### Added


This fragment describes a developer-facing build-system change. Per .changelog/README.md, these changes generally belong under ### CI / Infrastructure rather than ### Added (which is intended for user-visible features/new APIs).

Suggested change

### Added

### CI / Infrastructure

github-actions · 2026-03-26T00:13:59Z

✅ Fixes pushed — addressed all valid Copilot review comments on project.yml

Copilot Review Audit

Already fixed in prior commits (dismissed)

packages: section with all external SPM dependencies ✅
linkerFlags: removed, replaced with proper dependencies: - sdk: libz.tbd ✅
glidenhq and libpng are library.static ✅
SWIFT_VERSION: "6.0" ✅
options.allowedOverridesForPlatformSpecialization removed ✅
Target/module name PVMupen64PlusBridge (not PVMupenBridge) ✅
PVSettings and PVLoggingObjC dependencies in bridge target ✅
Core.plist resource listed in PVMupen target ✅
SDL dependency in PVMupen64PlusVideoRice ✅
VALIDATE_WORKSPACE_SKIPPED_SDK_FRAMEWORKS: OpenGLES at project level ✅
-flto and -pthread in gliden_osd target ✅
ARM-only flags scoped to [arch=arm64] ✅
Changelog format (### CI / Infrastructure, no trailing period) ✅

Fixed in this commit

gliden_osd header path — Sources/Plugins/Video/rice/src → Sources/Plugins/Video/rice/rice/src (the outer rice/src directory does not exist)
OTHER_CFLAGS composition — Xcode resolves only one conditionalized variant per build setting, so [arch=arm64] and [sdk=iphoneos*] overrides could not both apply. Introduced M64_ARCH_CFLAGS and M64_SDK_CFLAGS helper variables both referenced from the unconditional OTHER_CFLAGS entry, ensuring all flags are composed correctly.
Misleading comment — Removed reference to a non-existent "dedicated Debug target" for tvOS simulator stub sourcing.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

JoeMatt · 2026-05-19T03:24:48Z

👋 Triage pass — this [Agent] PR has been open ~50-60 days and develop has moved significantly since (controller-mapping refactor, thin-wrapper turbo/lightgun, Metal viewport fix, Sentry filter, MAME button suppression). It will almost certainly need a rebase before it can merge.

Please react on this comment so I know what to do:

👍 — still wanted, please rebase against develop and resolve conflicts (I can run @claude rebase if you tag me)
👎 — close as superseded / no longer needed
🚀 — high priority, I'll pick up the rebase myself this week
👀 — leave open, you'll come back to it

No reaction within 7 days → I'll close as stale. Re-open any time if you change your mind.

github-actions · 2026-05-19T03:31:14Z

Rebased — still wanted

This PR adds only two new files (Cores/Mupen64Plus/project.yml + .changelog/2856.md) and has zero overlap with the recent develop changes (controller-mapping refactor, lightgun, thin-wrapper turbo, Metal viewport, MAME suppression, SECURITY.md). No conflicts.

What was done

Found merge-base: 8183f823 (mednafen-lightgun commit, ~50 days ago)
Develop added 2 SECURITY.md commits since then — no file overlap with this PR
Rebased all 11 PR commits cleanly onto current develop HEAD (9dd68d223)
Force-pushed to agent/issue-2856

The PR is ready for review. The XcodeGen project.yml for Mupen64Plus is still a valid improvement that lets maintainers regenerate the .xcodeproj via xcodegen generate instead of hand-editing project.pbxproj.

Still needs human validation (per PR body): run xcodegen generate locally and confirm the generated project builds on iOS + tvOS simulators.

Add project.yml for the Mupen64Plus core package so the Xcode project can be regenerated via XcodeGen (xcodegen generate) without manually editing project.pbxproj. - Maps all SPM targets (PVMupen, PVMupenBridge, PVMupen64PlusCore, PVRSPCXD4, PVMupen64PlusRspHLE, SDL, libpng, glidenhq, gliden_osd, PVMupen64PlusVideoGlideN64, PVMupen64PlusVideoRice) to XcodeGen targets - Mirrors build settings from Config.xcconfig and Package.swift - Supports iOS and tvOS with platform-appropriate GLES defines - Both build paths (SPM and XcodeGen-generated .xcodeproj) are now supported side-by-side Part of #2856 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Update SWIFT_VERSION from 5.0 to 6.0 to match Package.swift toolchain - Add packages: section for all PV* local dependencies (PVAudio, PVCoreBridge, PVCoreObjCBridge, PVEmulatorCore, PVLogging, PVObjCUtils, PVPlists, PVSupport) - Wire package products as dependencies in PVMupen and PVMupenBridge targets - Add SDK-specific GCC_PREPROCESSOR_DEFINITIONS[sdk=...] for iOS/tvOS GLES/NEON/OS_IOS/USE_GLES* defines mirroring Package.swift sharedCSettings - Replace invalid linkerFlags: keys with OTHER_LDFLAGS in settings.base for libpng, glidenhq, PVMupen64PlusVideoGlideN64, PVMupen64PlusVideoRice - Replace invalid sdk: key with OTHER_LDFLAGS for OpenGLES linkage in PVMupen64PlusVideoGlideN64 - Change libpng and glidenhq type from framework to library.static to match existing project.pbxproj artifact type - Fix changelog entry: single sentence, no trailing period Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Add SDK-conditional OTHER_CFLAGS for iphoneos/simulator/appletvos/appletvsimulator to mirror Config.xcconfig -DOS_IOS/-D__VEC4_OPT/-D__NEON_OPT flags - Add EXCLUDED_SOURCE_FILE_NAMES[sdk=appletvos*] for non-NEON sources - Add EXCLUDED/INCLUDED_SOURCE_FILE_NAMES[sdk=appletvsimulator*] simulator stub - Add GCC_PREPROCESSOR_DEFINITIONS[sdk=macosx*] for macOS builds - Convert -lz OTHER_LDFLAGS to dependencies: sdk: libz.tbd (XcodeGen-idiomatic) - Convert -framework OpenGLES to dependencies: sdk: OpenGLES.framework Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Remove invalid 'allowedOverridesForPlatformSpecialization' XcodeGen option - Include CorePlist-Generated.swift (already committed, not build-generated) - Add SDL target dependency to PVMupen64PlusVideoRice Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Add -pthread to global OTHER_CFLAGS[arch=*] matching Config.xcconfig - Add -flto and -pthread to gliden_osd target OTHER_CFLAGS (mirrors Package.swift) - Change changelog section from Added to CI / Infrastructure Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Rename PVMupenBridge target → PVMupen64PlusBridge to match module name expected by Swift imports and ObjC generated headers - Add PVSettings to packages section and as a dependency of both PVMupen and PVMupen64PlusBridge (sources use @import PVSettings) - Add PVLoggingObjC product dependency to PVMupen64PlusBridge (ObjC sources use @import PVLoggingObjC) - Add PRODUCT_MODULE_NAME: PVMupen64PlusBridge to bridge target settings - Add Core.plist resource to PVMupen target to prevent runtime crash - Fix tvOS simulator EXCLUDED/INCLUDED_SOURCE_FILE_NAMES to use $(inherited) — XcodeGen resolves sources explicitly so wildcard * would break the build Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ject.yml Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…ve redundant arch=* CFLAGS - Add VALIDATE_WORKSPACE_SKIPPED_SDK_FRAMEWORKS: OpenGLES to project-level settings to suppress Xcode validation warnings (mirrors hand-maintained .xcodeproj) - Remove redundant OTHER_CFLAGS[arch=*] entry; -pthread already in base OTHER_CFLAGS Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Fix gliden_osd header search path: rice/src → rice/rice/src - Compose OTHER_CFLAGS via M64_ARCH_CFLAGS/M64_SDK_CFLAGS helpers so both arch-tuning and SDK-specific defines are applied together (Xcode only resolves one conditionalized variant per setting) - Update misleading tvOS-simulator comment about non-existent Debug target Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions Bot requested a review from JoeMatt as a code owner March 24, 2026 22:55

github-actions Bot enabled auto-merge (squash) March 24, 2026 22:55

github-actions Bot added agent-work PR or issue being worked on by the AI agent ai-reviewing AI code review in progress labels Mar 24, 2026

github-actions Bot mentioned this pull request Mar 24, 2026

[Epic][N64] Migrate Mupen64Plus to SPM/XcodeGen for dynamic plugin management #2856

Open

JoeMatt requested a review from Copilot March 25, 2026 00:16

Copilot started reviewing on behalf of JoeMatt March 25, 2026 00:17 View session

github-actions Bot removed the ai-reviewing AI code review in progress label Mar 25, 2026

Copilot AI reviewed Mar 25, 2026

View reviewed changes

github-actions Bot added the needs-fixes AI review found issues; auto-fixer dispatched label Mar 25, 2026

github-actions Bot added ai-reviewing AI code review in progress and removed needs-fixes AI review found issues; auto-fixer dispatched labels Mar 25, 2026

JoeMatt requested a review from Copilot March 25, 2026 01:16

Copilot started reviewing on behalf of JoeMatt March 25, 2026 01:17 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

github-actions Bot added needs-fixes AI review found issues; auto-fixer dispatched and removed ai-reviewing AI code review in progress labels Mar 25, 2026

github-actions Bot added ai-reviewing AI code review in progress and removed needs-fixes AI review found issues; auto-fixer dispatched labels Mar 25, 2026

JoeMatt requested a review from Copilot March 25, 2026 02:16

Copilot started reviewing on behalf of JoeMatt March 25, 2026 02:18 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

github-actions Bot force-pushed the agent/issue-2856 branch from 65685a0 to 01ac4f0 Compare March 26, 2026 00:17

github-actions Bot removed the ai-reviewing AI code review in progress label Mar 26, 2026

github-actions Bot force-pushed the agent/issue-2856 branch from 01ac4f0 to 2c933bd Compare March 26, 2026 00:28

JoeMatt requested a review from Copilot March 26, 2026 00:55

Copilot started reviewing on behalf of JoeMatt March 26, 2026 00:56 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

Comment thread Cores/Mupen64Plus/project.yml Outdated

github-actions Bot added the ready-for-review AI approved; awaiting human review label Mar 26, 2026

github-actions Bot force-pushed the agent/issue-2856 branch 9 times, most recently from 0fc6860 to c4f74c0 Compare March 28, 2026 23:00

github-actions Bot and others added 11 commits July 13, 2026 03:47

Update Cores/Mupen64Plus/project.yml

f7b4a9d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix(mupen64plus): add missing PVNetplay package and dependency to pro…

fe71b03

…ject.yml Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Update Cores/Mupen64Plus/project.yml

76c57f9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

		@@ -0,0 +1,2 @@
		### Added
		- Mupen64Plus XcodeGen support — Added `project.yml` for the Mupen64Plus core package, enabling Xcode project regeneration via `xcodegen generate` alongside the existing SPM `Package.swift` build path. Both build paths are now supported side-by-side.

		# Allow multi-platform targets
		allowedOverridesForPlatformSpecialization: true

-          - "-fPIC"
+          - "-fPIC"
+          - "-flto"
+          - "-pthread"

Uh oh!

Uh oh!

Conversation

github-actions Bot commented Mar 24, 2026

Summary

What's included

How to use

What still needs human validation

Notes

Test plan

Uh oh!

github-actions Bot commented Mar 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

JoeMatt commented Mar 25, 2026

Uh oh!

github-actions Bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

JoeMatt commented Mar 25, 2026

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented Mar 25, 2026 •

edited

Loading