chore: update to then new eslint version #78 (#79)

regevbr · web-flow · commit eb139f85e97d · 2020-05-30T19:36:36.000+03:00
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -5,7 +5,6 @@
   },
   "extends": [
     "plugin:@typescript-eslint/recommended",
-    "plugin:@typescript-eslint/recommended-requiring-type-checking",
     "plugin:jest/recommended",
     "prettier/@typescript-eslint",
     "plugin:prettier/recommended"
@@ -41,8 +40,17 @@
     "@typescript-eslint/adjacent-overload-signatures": ["error"],
     "@typescript-eslint/ban-types": ["error"],
     "camelcase": "error",
-    "@typescript-eslint/camelcase": ["error"],
-    "@typescript-eslint/class-name-casing": ["error"],
+    "@typescript-eslint/naming-convention": [
+      "error",
+      {
+        "selector": "variable",
+        "format": ["camelCase", "PascalCase", "UPPER_CASE"]
+      },
+      {
+        "selector": "enumMember",
+        "format": ["UPPER_CASE"]
+      }
+    ],
     "@typescript-eslint/consistent-type-assertions": ["error"],
     "@typescript-eslint/explicit-function-return-type": ["warn"],
     "@typescript-eslint/member-delimiter-style": [
@@ -85,7 +93,7 @@
     "@typescript-eslint/prefer-for-of": "error",
     "@typescript-eslint/prefer-function-type": "error",
     "quotes": "off",
-    "@typescript-eslint/ban-ts-ignore": "off",
+    "@typescript-eslint/ban-ts-comment": "off",
     "@typescript-eslint/quotes": ["error", "backtick"],
     "@typescript-eslint/semi": ["error", "always"],
     "@typescript-eslint/unified-signatures": "error",
diff --git a/package.json b/package.json
@@ -79,28 +79,28 @@
     "mutation-test": "yarn run stryker run"
   },
   "devDependencies": {
-    "@commitlint/cli": "^8.3.5",
-    "@commitlint/config-conventional": "^8.3.4",
-    "@stryker-mutator/core": "^3.1.0",
-    "@stryker-mutator/jest-runner": "^3.1.0",
-    "@stryker-mutator/typescript": "^3.1.0",
-    "@types/cross-spawn": "^6.0.1",
-    "@types/jest": "^25.2.1",
+    "@commitlint/cli": "^9.0.1",
+    "@commitlint/config-conventional": "^9.0.1",
+    "@stryker-mutator/core": "^3.2.4",
+    "@stryker-mutator/jest-runner": "^3.2.4",
+    "@stryker-mutator/typescript": "^3.2.4",
+    "@types/cross-spawn": "^6.0.2",
+    "@types/jest": "^25.2.3",
     "@types/jest-when": "^2.7.1",
-    "@types/node": "^13.13.5",
+    "@types/node": "^14.0.6",
     "@types/node-fetch": "^2.5.7",
     "@types/pacote": "^11.1.0",
-    "@types/semver": "^7.1.0",
-    "@types/shell-quote": "^1.6.1",
+    "@types/semver": "^7.2.0",
+    "@types/shell-quote": "^1.6.2",
     "@types/tmp": "^0.2.0",
     "@types/yargs-parser": "^15.0.0",
-    "@typescript-eslint/eslint-plugin": "^2.31.0",
-    "@typescript-eslint/parser": "^2.31.0",
-    "all-contributors-cli": "^6.14.2",
-    "cspell": "^4.0.61",
-    "eslint": "^7.0.0",
+    "@typescript-eslint/eslint-plugin": "^3.0.2",
+    "@typescript-eslint/parser": "^3.0.2",
+    "all-contributors-cli": "^6.15.0",
+    "cspell": "^4.0.63",
+    "eslint": "^7.1.0",
     "eslint-config-prettier": "^6.11.0",
-    "eslint-plugin-jest": "^23.10.0",
+    "eslint-plugin-jest": "^23.13.2",
     "eslint-plugin-prefer-arrow": "^1.2.1",
     "eslint-plugin-prettier": "^3.1.3",
     "expect": "^26.0.1",
@@ -109,36 +109,36 @@
     "jest": "^26.0.1",
     "jest-mock-extended": "^1.0.8",
     "jest-serial-runner": "file:./tools/jest-serial-runner",
-    "jest-when": "^2.7.1",
-    "lint-staged": "^10.2.2",
+    "jest-when": "^2.7.2",
+    "lint-staged": "^10.2.7",
     "mock-spawn": "^0.2.6",
     "node-fetch": "^2.6.0",
-    "npm-check-updates": "^5.0.0",
+    "npm-check-updates": "^6.0.1",
     "prettier": "^2.0.5",
     "semver": "^7.3.2",
-    "ts-jest": "^25.5.1",
-    "ts-node": "^8.10.1",
-    "ts-toolbelt": "^6.7.2",
-    "typescript": "^3.8.3"
+    "ts-jest": "^26.0.0",
+    "ts-node": "^8.10.2",
+    "ts-toolbelt": "^6.9.4",
+    "typescript": "^3.9.4"
   },
   "dependencies": {
     "array-flat-polyfill": "~1.0.1",
     "axios": "~0.19.2",
     "chalk": "~4.0.0",
-    "consola": "~2.12.1",
-    "cross-spawn": "~7.0.2",
+    "consola": "~2.12.2",
+    "cross-spawn": "~7.0.3",
     "figures": "~3.2.0",
     "inversify": "~5.0.1",
-    "moment": "~2.25.3",
-    "pacote": "~11.1.9",
+    "moment": "~2.26.0",
+    "pacote": "~11.1.10",
     "reflect-metadata": "~0.1.13",
     "shell-quote": "~1.7.2",
-    "simple-git": "~2.4.0",
+    "simple-git": "~2.5.0",
     "sqlite3": "~4.2.0",
     "tmp": "~0.2.1",
     "ts-type-guards": "~0.6.1",
-    "typeorm": "~0.2.24",
-    "yaml": "~1.9.2",
+    "typeorm": "~0.2.25",
+    "yaml": "~1.10.0",
     "yargs-parser": "~18.1.3"
   }
 }
diff --git a/src/db/migrations/1587992024382-autoGeneratedMigration.ts b/src/db/migrations/1587992024382-autoGeneratedMigration.ts
@@ -1,6 +1,6 @@
 import { MigrationInterface, QueryRunner } from 'typeorm';
 
-// eslint-disable-next-line @typescript-eslint/class-name-casing
+/* eslint-disable @typescript-eslint/naming-convention */
 export class autoGeneratedMigration1587992024382 implements MigrationInterface {
   name = `autoGeneratedMigration1587992024382`;
 
diff --git a/src/resolvers/ciResolver/impl/resolvers/githubActions/githubActionsConfigParser.ts b/src/resolvers/ciResolver/impl/resolvers/githubActions/githubActionsConfigParser.ts
@@ -60,7 +60,7 @@ const isMatrixNode = (value: unknown, node: INode): value is StringOrNumber[] =>
   );
 };
 
-const isIncludeMatrixNode = (value: unknown, node: INode): value is object[] => {
+const isIncludeMatrixNode = (value: unknown, node: INode): value is Record<string, unknown>[] => {
   const { parent, key } = node;
   return (
     parent.isNonRootNode &&
diff --git a/src/utils/logger/impl/jsonLogReporter.ts b/src/utils/logger/impl/jsonLogReporter.ts
@@ -13,9 +13,7 @@ export class JsonLogReporter extends BasicReporter implements ConsolaReporter {
   }
 
   public log(logObj: ConsolaLogObject): void {
-    // TODO fix that after consola typings are fixed
-    // @ts-ignore
-    const message = this.formatArgs(logObj.args);
+    const message = this.formatArgs(logObj.args || []);
     this.stream.write(
       `${JSON.stringify({
         message,
diff --git a/src/utils/logger/impl/logLevel.ts b/src/utils/logger/impl/logLevel.ts
@@ -8,8 +8,8 @@ const logLevelMap = {
   [LogLevel.INFO]: ConsolaLogLevel.Info,
   [LogLevel.DEBUG]: ConsolaLogLevel.Debug,
   [LogLevel.TRACE]: ConsolaLogLevel.Trace,
-  [LogLevel.SILENT]: -ConsolaLogLevel.Silent, // Hack until the issue in conosla is fixed. Need to also give restrictive type to object
-  [LogLevel.VERBOSE]: ConsolaLogLevel.Silent, // Hack until the issue in conosla is fixed. Need to also give restrictive type to object
+  [LogLevel.SILENT]: ConsolaLogLevel.Silent,
+  [LogLevel.VERBOSE]: ConsolaLogLevel.Verbose,
 };
 
 export const getConoslaLogLevel = (level: LogLevel): ConsolaLogLevel => logLevelMap[level];
diff --git a/src/utils/logger/impl/logReporter.ts b/src/utils/logger/impl/logReporter.ts
@@ -1,7 +1,7 @@
 import {
-  ConsolaLogObject,
   ConsolaReporter,
   ConsolaReporterArgs,
+  ConsolaReporterLogObject,
   FancyReporter,
   FancyReporterOptions,
   LogLevel,
@@ -58,15 +58,15 @@ export class LogReporter extends FancyReporter implements ConsolaReporter {
     this.level = options.level;
   }
 
-  public log(logObj: ConsolaLogObject, args: ConsolaReporterArgs): void {
+  public log(logObj: ConsolaReporterLogObject, args: ConsolaReporterArgs): void {
     // TODO fix that once consola typings are fixed
     if (logObj.level! > this.level) {
       return;
     }
     super.log(logObj, args);
   }
 
-  protected formatType(logObj: ConsolaLogObject): string {
+  protected formatType(logObj: ConsolaReporterLogObject): string {
     const typeColor =
       (logObj.type && TYPE_COLOR_MAP[logObj.type]) ||
       (isNumber(logObj.level) && LEVEL_COLOR_MAP[logObj.level]) ||
diff --git a/src/utils/logger/impl/logger.ts b/src/utils/logger/impl/logger.ts
diff --git a/src/utils/logger/impl/loggerFactory.ts b/src/utils/logger/impl/loggerFactory.ts
@@ -13,9 +13,9 @@ import { FS, TYPES } from '../../../container/nodeModulesContainer';
 import Process = NodeJS.Process;
 
 const fileStreamOptions = {
-  encoding: `utf8`,
+  encoding: `utf-8`,
   flags: `w`,
-};
+} as const;
 
 @injectable()
 export class LoggerFactory extends ILoggerFactory {
diff --git a/test/common/inMemoryDb.ts b/test/common/inMemoryDb.ts
@@ -1,5 +1,6 @@
 import { Connection, createConnection } from 'typeorm';
 
+// eslint-disable-next-line @typescript-eslint/ban-types
 export const getInMemoryDb = async (entity: Function): Promise<Connection> => {
   return createConnection({
     name: Math.random().toString(36).substring(7),
diff --git a/test/common/safeMockFn.ts b/test/common/safeMockFn.ts
@@ -1,5 +1,6 @@
 import { calledWithFn, CalledWithMock } from 'jest-mock-extended';
 
+// eslint-disable-next-line @typescript-eslint/ban-types
 export const mockFn = <T extends Function>(): T extends (...args: infer A) => infer B
   ? CalledWithMock<B, A> & T
   : T => {
diff --git a/test/common/testers/repositoryProviderTester.ts b/test/common/testers/repositoryProviderTester.ts
@@ -8,11 +8,12 @@ import { IConnectionProvider } from '../../../src/db';
 import { IRepositoryProvider } from '../../../src/db/interfaces/IRepositoryProvider';
 
 export const testRepositoryProvider = <E extends IEntity, P extends IRepositoryProvider<E>>(
-  Entity: new () => E,
-  RepositoryProvider: new (connectionProvider: IConnectionProvider) => P
+  entity: new () => E,
+  repositoryProvider: new (connectionProvider: IConnectionProvider) => P
 ): void => {
   const repositoryMock = mock<Repository<E>>();
   const connectionMock = mock<Connection>();
+  // @ts-ignore
   connectionMock.getRepository.mockReturnValue(repositoryMock);
   const connectionProviderMock = mock<IConnectionProvider>();
   connectionProviderMock.getConnection.mockResolvedValue(connectionMock);
@@ -22,7 +23,7 @@ export const testRepositoryProvider = <E extends IEntity, P extends IRepositoryP
     mockClear(connectionProviderMock);
     mockClear(connectionMock);
     mockClear(repositoryMock);
-    dependencyRepositoryProvider = new RepositoryProvider(connectionProviderMock);
+    dependencyRepositoryProvider = new repositoryProvider(connectionProviderMock);
   });
 
   it(`should cache repo`, async () => {
@@ -40,6 +41,6 @@ export const testRepositoryProvider = <E extends IEntity, P extends IRepositoryP
     expect(connectionProviderMock.getConnection).toBeCalledTimes(1);
     expect(connectionMock.getRepository).toBeCalledTimes(1);
     expect(connectionProviderMock.getConnection).toHaveBeenCalledWith();
-    expect(connectionMock.getRepository).toHaveBeenCalledWith(Entity);
+    expect(connectionMock.getRepository).toHaveBeenCalledWith(entity);
   });
 };
diff --git a/test/src/db/impl/connectionProvider.spec.ts b/test/src/db/impl/connectionProvider.spec.ts
@@ -12,10 +12,12 @@ describe(`connection provider`, () => {
     database: `database`,
   };
   const connectionOptionsProviderMock = mock<IConnectionOptionsProvider>();
+  // @ts-ignore
   connectionOptionsProviderMock.getConnectionOptions.mockReturnValue(connectionOptionsPlaceholder);
   const connectionMock = mockDeep<Connection>();
   const typeOrmMock = mock<TypeOrm>();
   const schemaBuilderMock = mock<SchemaBuilder>();
+  // @ts-ignore
   typeOrmMock.createConnection.mockResolvedValue(connectionMock);
   connectionMock.driver.createSchemaBuilder.mockReturnValue(schemaBuilderMock);
 
diff --git a/test/src/dependencyChecker/impl/packageInfoCache.spec.ts b/test/src/dependencyChecker/impl/packageInfoCache.spec.ts
@@ -10,6 +10,7 @@ describe(`package info cache`, () => {
   const packageInfoMock = mock<IPackageInfo>();
   const repositoryMock = mock<Repository<DependencyVersion>>();
   const dependencyVersionRepositoryProviderMock = mock<IDependencyVersionRepositoryProvider>();
+  // @ts-ignore
   dependencyVersionRepositoryProviderMock.getRepository.mockResolvedValue(repositoryMock);
   let packageInfoCache: PackageInfoCache;
 
diff --git a/test/src/resolvers/cacheResolver/impl/cacheResolver.spec.ts b/test/src/resolvers/cacheResolver/impl/cacheResolver.spec.ts
@@ -7,6 +7,7 @@ import { mock, mockReset } from 'jest-mock-extended';
 describe(`cache resolver`, () => {
   const repositoryMock = mock<Repository<Dependency>>();
   const dependencyRepositoryProviderMock = mock<IDependencyRepositoryProvider>();
+  // @ts-ignore
   dependencyRepositoryProviderMock.getRepository.mockResolvedValue(repositoryMock);
   const cacheResolver = new CacheResolver(dependencyRepositoryProviderMock, loggerFactory);
 
diff --git a/test/src/resolvers/ciResolver/impl/nvmHandler.spec.ts b/test/src/resolvers/ciResolver/impl/nvmHandler.spec.ts
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/naming-convention */
 import { NvmHandler } from '../../../../../src/resolvers/ciResolver/impl/nvmHandler';
 import { mock, mockClear } from 'jest-mock-extended';
 import { ITargetMatcher } from '../../../../../src/resolvers/ciResolver';
diff --git a/test/src/resolvers/ciResolver/impl/resolvers/appveyor/appVeyorConfigParser.spec.ts b/test/src/resolvers/ciResolver/impl/resolvers/appveyor/appVeyorConfigParser.spec.ts
@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/camelcase */
+/* eslint-disable @typescript-eslint/naming-convention */
 /* eslint-disable camelcase */
 import { loggerFactory } from '../../../../../../common/logger';
 import { AppVeyorConfigParser } from '../../../../../../../src/resolvers/ciResolver/impl/resolvers/appveyor/appVeyorConfigParser';
diff --git a/test/src/resolvers/ciResolver/impl/resolvers/appveyor/appVeyorResolver.spec.ts b/test/src/resolvers/ciResolver/impl/resolvers/appveyor/appVeyorResolver.spec.ts
@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/camelcase */
+/* eslint-disable @typescript-eslint/naming-convention */
 /* eslint-disable camelcase */
 import { AppVeyorResolver } from '../../../../../../../src/resolvers/ciResolver/impl/resolvers/appveyor/appVeyorResolver';
 import { FS } from '../../../../../../../src/container/nodeModulesContainer';
diff --git a/test/src/resolvers/ciResolver/impl/resolvers/circleci/circleCiConfigParser.spec.ts b/test/src/resolvers/ciResolver/impl/resolvers/circleci/circleCiConfigParser.spec.ts
@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/camelcase */
+/* eslint-disable @typescript-eslint/naming-convention */
 /* eslint-disable camelcase */
 import { loggerFactory } from '../../../../../../common/logger';
 import { CircleCiConfigParser } from '../../../../../../../src/resolvers/ciResolver/impl/resolvers/circleci/circleCiConfigParser';
diff --git a/test/src/resolvers/ciResolver/impl/resolvers/circleci/circleCiResolver.spec.ts b/test/src/resolvers/ciResolver/impl/resolvers/circleci/circleCiResolver.spec.ts
@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/camelcase */
+/* eslint-disable @typescript-eslint/naming-convention */
 /* eslint-disable camelcase */
 import { FS } from '../../../../../../../src/container/nodeModulesContainer';
 import { normalize } from 'path';
diff --git a/test/src/resolvers/ciResolver/impl/resolvers/githubActions/githubActionsConfigParser.spec.ts b/test/src/resolvers/ciResolver/impl/resolvers/githubActions/githubActionsConfigParser.spec.ts
@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/camelcase */
+/* eslint-disable @typescript-eslint/naming-convention */
 /* eslint-disable camelcase */
 import { loggerFactory } from '../../../../../../common/logger';
 import { ITargetMatcher } from '../../../../../../../src/resolvers/ciResolver';
diff --git a/test/src/resolvers/ciResolver/impl/resolvers/githubActions/githubActionsResolver.spec.ts b/test/src/resolvers/ciResolver/impl/resolvers/githubActions/githubActionsResolver.spec.ts
@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/camelcase */
+/* eslint-disable @typescript-eslint/naming-convention */
 /* eslint-disable camelcase */
 import { FS } from '../../../../../../../src/container/nodeModulesContainer';
 import { normalize } from 'path';
@@ -56,6 +56,7 @@ describe(`Github Actions Resolver`, () => {
       when(fsMock.promises.readdir)
         // @ts-ignore
         .calledWith(normalize(`placeholder/.github/workflows`))
+        // @ts-ignore
         .mockResolvedValue([config1FileName, config2FileName, config3FileName, `nonYamlFile.sh`]);
       when(fsMock.promises.readFile)
         .calledWith(normalize(`placeholder/.github/workflows/${config1FileName}`), `utf-8`)
diff --git a/test/src/resolvers/ciResolver/impl/resolvers/travisci/travisCiConfigParser.spec.ts b/test/src/resolvers/ciResolver/impl/resolvers/travisci/travisCiConfigParser.spec.ts
@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/camelcase */
+/* eslint-disable @typescript-eslint/naming-convention */
 /* eslint-disable camelcase */
 import { loggerFactory } from '../../../../../../common/logger';
 import { TravisCiConfigParser } from '../../../../../../../src/resolvers/ciResolver/impl/resolvers/travisci/travisCiConfigParser';
diff --git a/test/src/resolvers/ciResolver/impl/resolvers/travisci/travisCiResolver.spec.ts b/test/src/resolvers/ciResolver/impl/resolvers/travisci/travisCiResolver.spec.ts
@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/camelcase */
+/* eslint-disable @typescript-eslint/naming-convention */
 /* eslint-disable camelcase */
 import { FS } from '../../../../../../../src/container/nodeModulesContainer';
 import { normalize } from 'path';
diff --git a/test/src/utils/logger/impl/jsonLogReporter.spec.ts b/test/src/utils/logger/impl/jsonLogReporter.spec.ts
@@ -50,6 +50,27 @@ describe(`json log reporter`, () => {
     });
   });
 
+  it(`should log without args`, async () => {
+    const date = moment();
+    const { mockedStream, streamPromise, closeStream } = getMockedStream();
+    const logReporter = new JsonLogReporter({
+      stream: mockedStream,
+    });
+    logReporter.log({
+      level: LogLevel.Info,
+      type: `info`,
+      date: date.toDate(),
+    });
+    closeStream();
+    const result = await streamPromise;
+    expect(JSON.parse(result)).toEqual({
+      date: date.toJSON(),
+      level: LogLevel.Info,
+      message: ``,
+      type: `info`,
+    });
+  });
+
   it(`should log with error`, async () => {
     const date = moment();
     const { mockedStream, streamPromise, closeStream } = getMockedStream();
diff --git a/test/src/utils/logger/impl/logLevel.spec.ts b/test/src/utils/logger/impl/logLevel.spec.ts
@@ -11,7 +11,8 @@ describe(`log level`, () => {
       expect(getConoslaLogLevel(LogLevel.INFO)).toEqual(ConsolaLogLevel.Info);
       expect(getConoslaLogLevel(LogLevel.DEBUG)).toEqual(ConsolaLogLevel.Debug);
       expect(getConoslaLogLevel(LogLevel.TRACE)).toEqual(ConsolaLogLevel.Trace);
-      expect(getConoslaLogLevel(LogLevel.SILENT)).toEqual(-ConsolaLogLevel.Silent);
+      expect(getConoslaLogLevel(LogLevel.SILENT)).toEqual(ConsolaLogLevel.Silent);
+      expect(getConoslaLogLevel(LogLevel.VERBOSE)).toEqual(ConsolaLogLevel.Verbose);
     });
   });
 });
diff --git a/test/src/utils/logger/impl/logReporter.spec.ts b/test/src/utils/logger/impl/logReporter.spec.ts
diff --git a/test/src/utils/logger/impl/loggerFactory.spec.ts b/test/src/utils/logger/impl/loggerFactory.spec.ts
diff --git a/tools/generateContributors.ts b/tools/generateContributors.ts
diff --git a/yarn.lock b/yarn.lock
