Skip to content

[WIP]Fragments: Separate out Server-Side-Character#1647

Closed
AxeelAnder wants to merge 11 commits into
Pryaxis:general-develfrom
AxeelAnder:ssc
Closed

[WIP]Fragments: Separate out Server-Side-Character#1647
AxeelAnder wants to merge 11 commits into
Pryaxis:general-develfrom
AxeelAnder:ssc

Conversation

@AxeelAnder

Copy link
Copy Markdown
Contributor

@maka-albarn

maka-albarn Bot commented Oct 29, 2018

Copy link
Copy Markdown

Thanks for the pull request! TShock's maintainers would like you to go ahead and give yourself credit by updating the CHANGELOG.md as soon as you can. Your pull request will likely not be accepted without this. This both helps us document changes to TShock, as well as give you credit for your work. You deserve it, so go take credit! ✨

@AxeelAnder

Copy link
Copy Markdown
Contributor Author

Should 'CharacterDB' and 'PlayerData' be components of this subsystem?
PlayerData is widely used in many things, if it's a part of this, ssc will be indispensable.

@ivanbiljan

Copy link
Copy Markdown
Contributor

@AxeelAnder are you still working on this? As far as your previous question goes; yes, those files should be a part of the SSC subsystem imo (given that they handle SSC data).

@AxeelAnder

Copy link
Copy Markdown
Contributor Author

Give up. It's too hard for me, I have no enough experience or talent on software architecture design.

@AxeelAnder AxeelAnder closed this Jun 28, 2019
@QuiCM

QuiCM commented Jul 18, 2019

Copy link
Copy Markdown
Member

Hi, I'm going to reopen this for visibility so it hopefully doesn't get forgotten next time one of the team has capacity for development

@QuiCM QuiCM reopened this Jul 18, 2019
@hakusaro

hakusaro commented May 9, 2020

Copy link
Copy Markdown
Member

@AxeelAnder hi, I think you're very talented xoxo

@hakusaro hakusaro marked this pull request as draft May 12, 2020 08:22
@AxeelAnder

Copy link
Copy Markdown
Contributor Author

@QuiCM started his work in #1982, so pls let me close this pr, it's my kurorekishi 😭

@AxeelAnder AxeelAnder closed this Jun 3, 2020
@AxeelAnder AxeelAnder deleted the ssc branch June 3, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants