Skip to content

Commit 7f08a03

Browse files
committed
docs(devfactory): update CONTRIBUTING guide with PR label workflow and reviewer instructions
1 parent cfff54b commit 7f08a03

1 file changed

Lines changed: 17 additions & 3 deletions

File tree

โ€ŽCONTRIBUTING.mdโ€Ž

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,27 @@ DevFactory๋Š” **๋ชจ๋…ธ๋ ˆํฌ(Monorepo)** ๊ตฌ์กฐ๋ฅผ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค.
9595

9696
- **์ง์ ‘ push ๊ธˆ์ง€** (`main` ๋ธŒ๋žœ์น˜ ํฌํ•จ)
9797
- ๋ชจ๋“  ๋ณ€๊ฒฝ์€ **Pull Request(PR)**๋ฅผ ํ†ตํ•ด ์ง„ํ–‰
98+
- **์„œ๋น„์Šค ๊ตฌ๋ถ„ ๋ผ๋ฒจ(`์นœํ•ด์ง€๊ธธ๋ฐ”๋ผ`, `์ˆ˜๋ฃŒ์ฆ`, `devfactory`, `Bingo`) ์ˆ˜๋™ ์ถ”๊ฐ€ ํ•„์ˆ˜**
9899
- **๋ฆฌ๋ทฐ์–ด 1์ธ ์ด์ƒ ์Šน์ธ ํ•„์ˆ˜**
99100
- **PR ์ž‘์„ฑ์ž๊ฐ€ ์ง์ ‘ ๋ณ‘ํ•ฉ (rebase merge ๊ถŒ์žฅ)**
100101
- **๋ณ‘ํ•ฉ ํ›„ ๋ธŒ๋žœ์น˜ ์‚ญ์ œ ๊ถŒ์žฅ**
101-
- **CI ํ†ต๊ณผ ํ•„์ˆ˜** (`lint`, `test`, `build`)
102102

103-
> ๐Ÿ’ก PR ์ƒ์„ฑ ์‹œ needs-review, ๋ณ‘ํ•ฉ ์‹œ merged ๋ผ๋ฒจ์ด ์ž๋™์œผ๋กœ ๋ถ€์—ฌ๋ฉ๋‹ˆ๋‹ค.
104-
>
103+
๐Ÿ’ก **PR ์ƒํƒœ๋Š” ๋ผ๋ฒจ์„ ํ†ตํ•ด ๊ด€๋ฆฌ๋ฉ๋‹ˆ๋‹ค.**
104+
105+
| ๋ผ๋ฒจ | ์„ค๋ช… | ๋ถ€์—ฌ ๋ฐฉ์‹ |
106+
| --- | --- | --- |
107+
| ๐ŸŸจ `needs-review` | ์ƒˆ PR ์ƒ์„ฑ ์‹œ ์ž๋™ ๋ถ€์—ฌ (๋ฆฌ๋ทฐ ๋Œ€๊ธฐ ์ƒํƒœ) | ์ž๋™ |
108+
| ๐ŸŸง `changes-requested` | ๋ฆฌ๋ทฐ์–ด๊ฐ€ ์ฝ”๋“œ ์ˆ˜์ • ์š”์ฒญ์„ ๋‚จ๊ธด ์ƒํƒœ | ๋ฆฌ๋ทฐ์–ด๊ฐ€ ์ˆ˜๋™ ๋ณ€๊ฒฝ |
109+
| ๐ŸŸฉ `approved` | ๋ฆฌ๋ทฐ์–ด ์Šน์ธ ์™„๋ฃŒ, ๋ณ‘ํ•ฉ ๊ฐ€๋Šฅํ•œ ์ƒํƒœ | ๋ฆฌ๋ทฐ์–ด๊ฐ€ ์ˆ˜๋™ ๋ณ€๊ฒฝ |
110+
| ๐ŸŸช `merged` | PR ๋ณ‘ํ•ฉ ์™„๋ฃŒ ์‹œ ์ž๋™ ๋ถ€์—ฌ | ์ž๋™ |
111+
112+
๐Ÿ”– **๋ฆฌ๋ทฐ์–ด ๊ฐ€์ด๋“œ**
113+
- ์ฝ”๋“œ ์ˆ˜์ •์ด ํ•„์š”ํ•  ๊ฒฝ์šฐ โ†’ `changes-requested`
114+
- ์ˆ˜์ • ํ™•์ธ ํ›„ ์Šน์ธ ์‹œ โ†’ `approved`
115+
116+
๐Ÿ”ง **PR ์ž‘์„ฑ์ž ๊ฐ€์ด๋“œ**
117+
- PR์ด **`approved` ์ƒํƒœ**๊ฐ€ ๋˜๋ฉด **rebase merge** ๋ฐฉ์‹์œผ๋กœ ์ง์ ‘ ๋ณ‘ํ•ฉํ•ฉ๋‹ˆ๋‹ค.
118+
- ๋ณ‘ํ•ฉ์ด ์™„๋ฃŒ๋˜๋ฉด `merged` ๋ผ๋ฒจ์ด ์ž๋™์œผ๋กœ ์ถ”๊ฐ€๋ฉ๋‹ˆ๋‹ค.
105119

106120
---
107121

0 commit comments

Comments
ย (0)