WIP: Accesible Map#232
Conversation
zoltan-dulac
left a comment
zoltan-dulac
left a comment
There was a problem hiding this comment.
Just a bit of housekeeping to do in your PR so far.
| </main> | ||
|
|
||
| <script src="https://unpkg.com/leaflet@1.7.1/dist/leaflet.js"></script> | ||
| <script> |
There was a problem hiding this comment.
Just want to comment on common practice throughout the project (you may know this already, but I thought I'd better write this down just in case you don't).
- we should have script tags in the bottom/maps.php file.
- Scripts should be modules (e.g.
<script type="module">). Is it possible to include leaflet.js as an import? Look atjs/demos/dialog-example.jsto see how we import modules into that file. - Instead of using unpkg to include leaflet, we should include it in the project. Please follow our documentation in README.md on including npm modules in the front-end to see what we need to do here.
|
|
||
| </main> | ||
|
|
||
| <script src="https://maps.googleapis.com/maps/api/js?key=YOUR_API_KEY&callback=initMap" async defer></script> |
| </head> | ||
| <body> | ||
| <main> | ||
| <h1>Interactive Map and Accessible List View</h1> |
There was a problem hiding this comment.
If you take a look at the other pages in the body directory, you'll see that you only need the stuff inside
.The CSS above should be linked from content/head/maps.php via the tag. Please make a LESS file to store this. It will be converted to CSS by our build scripts.
JS should be included in the content/bottom/maps.php file.
The aside directory would have notes on the top of the page like the table.php page
Can you please add this information to the README.md for this project? I think if you didn't know this, others wouldn't as well (I missed putting this in the docuementation).
2 participants
No description provided.