Skip to content

Commit 5a0139f

Browse files
OmriBarZikMichalPorag
authored andcommitted
chore: fix lint
1 parent d60c9f0 commit 5a0139f

49 files changed

Lines changed: 220 additions & 257 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ about: Create a report to help us improve
44
title: ''
55
labels: ''
66
assignees: ''
7-
87
---
98

109
**Describe the bug**
1110
A clear and concise description of what the bug is.
1211

1312
**To Reproduce**
1413
Steps to reproduce the behavior:
14+
1515
1. Go to '...'
1616
2. Click on '....'
1717
3. Scroll down to '....'
@@ -24,15 +24,17 @@ A clear and concise description of what you expected to happen.
2424
If applicable, add screenshots to help explain your problem.
2525

2626
**Desktop (please complete the following information):**
27-
- OS: [e.g. iOS]
28-
- Browser [e.g. chrome, safari]
29-
- Version [e.g. 22]
27+
28+
- OS: [e.g. iOS]
29+
- Browser [e.g. chrome, safari]
30+
- Version [e.g. 22]
3031

3132
**Smartphone (please complete the following information):**
32-
- Device: [e.g. iPhone6]
33-
- OS: [e.g. iOS8.1]
34-
- Browser [e.g. stock browser, safari]
35-
- Version [e.g. 22]
33+
34+
- Device: [e.g. iPhone6]
35+
- OS: [e.g. iOS8.1]
36+
- Browser [e.g. stock browser, safari]
37+
- Version [e.g. 22]
3638

3739
**Additional context**
3840
Add any other context about the problem here.

.github/ISSUE_TEMPLATE/feature_request.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ about: Suggest an idea for this project
44
title: ''
55
labels: ''
66
assignees: ''
7-
87
---
98

109
**Is your feature request related to a problem? Please describe.**

.github/auto_assign.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ addReviewers: true
55
addAssignees: true
66

77
# A list of reviewers to be added to pull requests (GitHub user name)
8-
reviewers:
8+
reviewers:
99
- MichalPorag
1010
- ozizhakGT
1111
- abrl91

.github/workflows/e2e-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: "Tests: E2E"
1+
name: 'Tests: E2E'
22
on: [pull_request]
33
jobs:
44
tests_e2e:

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
with:
2323
node-version: 16
2424
cache: 'npm'
25-
25+
2626
- name: Install dependencies
2727
run: npm ci
2828

CODE_OF_CONDUCT.md

Lines changed: 19 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -20,28 +20,28 @@ If you see someone who is making an extra effort to ensure our community is welc
2020

2121
The following behaviors are expected and requested of all community members:
2222

23-
* Participate in an authentic and active way. In doing so, you contribute to the health and longevity of this community.
24-
* Exercise consideration and respect in your speech and actions.
25-
* Attempt collaboration before conflict.
26-
* Refrain from demeaning, discriminatory, or harassing behavior and speech.
27-
* Be mindful of your surroundings and of your fellow participants. Alert community leaders if you notice a dangerous situation, someone in distress, or violations of this Code of Conduct, even if they seem inconsequential.
28-
* Remember that community event venues may be shared with members of the public; please be respectful to all patrons of these locations.
23+
- Participate in an authentic and active way. In doing so, you contribute to the health and longevity of this community.
24+
- Exercise consideration and respect in your speech and actions.
25+
- Attempt collaboration before conflict.
26+
- Refrain from demeaning, discriminatory, or harassing behavior and speech.
27+
- Be mindful of your surroundings and of your fellow participants. Alert community leaders if you notice a dangerous situation, someone in distress, or violations of this Code of Conduct, even if they seem inconsequential.
28+
- Remember that community event venues may be shared with members of the public; please be respectful to all patrons of these locations.
2929

3030
## 4. Unacceptable Behavior
3131

3232
The following behaviors are considered harassment and are unacceptable within our community:
3333

34-
* Violence, threats of violence or violent language directed against another person.
35-
* Sexist, racist, homophobic, transphobic, ableist or otherwise discriminatory jokes and language.
36-
* Posting or displaying sexually explicit or violent material.
37-
* Posting or threatening to post other people's personally identifying information ("doxing").
38-
* Personal insults, particularly those related to gender, sexual orientation, race, religion, or disability.
39-
* Inappropriate photography or recording.
40-
* Inappropriate physical contact. You should have someone's consent before touching them.
41-
* Unwelcome sexual attention. This includes, sexualized comments or jokes; inappropriate touching, groping, and unwelcomed sexual advances.
42-
* Deliberate intimidation, stalking or following (online or in person).
43-
* Advocating for, or encouraging, any of the above behavior.
44-
* Sustained disruption of community events, including talks and presentations.
34+
- Violence, threats of violence or violent language directed against another person.
35+
- Sexist, racist, homophobic, transphobic, ableist or otherwise discriminatory jokes and language.
36+
- Posting or displaying sexually explicit or violent material.
37+
- Posting or threatening to post other people's personally identifying information ("doxing").
38+
- Personal insults, particularly those related to gender, sexual orientation, race, religion, or disability.
39+
- Inappropriate photography or recording.
40+
- Inappropriate physical contact. You should have someone's consent before touching them.
41+
- Unwelcome sexual attention. This includes, sexualized comments or jokes; inappropriate touching, groping, and unwelcomed sexual advances.
42+
- Deliberate intimidation, stalking or following (online or in person).
43+
- Advocating for, or encouraging, any of the above behavior.
44+
- Sustained disruption of community events, including talks and presentations.
4545

4646
## 5. Weapons Policy
4747

@@ -59,15 +59,11 @@ If a community member engages in unacceptable behavior, the community organizers
5959

6060
If you are subject to or witness unacceptable behavior, or have any other concerns, please notify a community organizer as soon as possible. miporagi@gmail.com.
6161

62-
63-
6462
Additionally, community organizers are available to help community members engage with local law enforcement or to otherwise help those experiencing unacceptable behavior feel safe. In the context of in-person events, organizers will also provide escorts as desired by the person experiencing distress.
6563

6664
## 8. Addressing Grievances
6765

68-
If you feel you have been falsely or unfairly accused of violating this Code of Conduct, you should notify Pull-Request-Community with a concise description of your grievance. Your grievance will be handled in accordance with our existing governing policies.
69-
70-
66+
If you feel you have been falsely or unfairly accused of violating this Code of Conduct, you should notify Pull-Request-Community with a concise description of your grievance. Your grievance will be handled in accordance with our existing governing policies.
7167

7268
## 9. Scope
7369

@@ -81,7 +77,7 @@ miporagi@gmail.com
8177

8278
## 11. License and attribution
8379

84-
The Citizen Code of Conduct is distributed by [Stumptown Syndicate](http://stumptownsyndicate.org) under a [Creative Commons Attribution-ShareAlike license](http://creativecommons.org/licenses/by-sa/3.0/).
80+
The Citizen Code of Conduct is distributed by [Stumptown Syndicate](http://stumptownsyndicate.org) under a [Creative Commons Attribution-ShareAlike license](http://creativecommons.org/licenses/by-sa/3.0/).
8581

8682
Portions of text derived from the [Django Code of Conduct](https://www.djangoproject.com/conduct/) and the [Geek Feminism Anti-Harassment Policy](http://geekfeminism.wikia.com/wiki/Conference_anti-harassment/Policy).
8783

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ npm run dev
8888

8989
Open [http://localhost:3000](http://localhost:3000) with your browser to see the result.
9090

91+
# Contributing to the project:
9192

92-
93-
# Contributing to the project:
9493
If you are interested in contributing to the project, please follow this [guide](https://github.com/Pull-Request-Community/pull-request-community-website/blob/master/docs/contributing.md).

docs/contributing.md

Lines changed: 22 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,25 @@
11
# Contribution To The Pull Request Website
2+
23
Thank you, it is not obvious that you are devoting your time to contributing to our community.
34
We appreciate it very much.❤️🙏🏻
45

56
Before jumping into the deep water, it's essential to discuss a bit of communication.
67
One of the biggest challenges on each project (especially on open-source projects) is communication.
78
Good communication can lead to great achievements, effective teamwork, time efficiency and make the working process fun and easy.
8-
It is important to remember that all contributions are made voluntarily by people that devote their time and hard work. We are all part of a team, so *please be passionate and polite to each other*.
9+
It is important to remember that all contributions are made voluntarily by people that devote their time and hard work. We are all part of a team, so _please be passionate and polite to each other_.
910

1011
Please follow this guide to make your experience as pleasant and easy as possible.
1112

1213
## The Ways You Can Contribute To The Pull Request Website:
13-
* Opening a [new issue](https://github.com/Pull-Request-Community/pull-request-community-website/issues/new) with a bug or a feature proposal.
14-
* Add documentation for existing features.
15-
* Improvement of our tests.
16-
* Solving an issue or adding a new feature.
14+
15+
- Opening a [new issue](https://github.com/Pull-Request-Community/pull-request-community-website/issues/new) with a bug or a feature proposal.
16+
- Add documentation for existing features.
17+
- Improvement of our tests.
18+
- Solving an issue or adding a new feature.
1719

1820
## The Preferred Way To Contribute:
19-
1. Pick an issue from the [issues list](https://github.com/Pull-Request-Community/pull-request-community-website/issues) or [open a new issue](https://github.com/Pull-Request-Community/pull-request-community-website/issues/new) and *ask*, by writing a new comment on the issue's page, to own the task.
21+
22+
1. Pick an issue from the [issues list](https://github.com/Pull-Request-Community/pull-request-community-website/issues) or [open a new issue](https://github.com/Pull-Request-Community/pull-request-community-website/issues/new) and _ask_, by writing a new comment on the issue's page, to own the task.
2023
2. Wait for the maintainer's ownership approval. Keep in mind that they may not approve that. Like we said at the beggining, communication is everything.
2124
3. Fork the project. For more details, please read this article: [My first contribution to open source: Make a fork of the repo / Galen Corey](https://opensource.com/article/19/11/first-open-source-contribution-fork-clone).
2225
4. Clone the forked project to your local machine (see instructions below).
@@ -25,21 +28,26 @@ Please follow this guide to make your experience as pleasant and easy as possibl
2528
7. While working on an issue, feel free to ask any questions on the issue's page.
2629
8. Open pull request (make sure you open the pull requset on the original project and not on the forked project).
2730
9. Make sure all the tests are passing.
28-
10. Merge to the *main* branch.
31+
10. Merge to the _main_ branch.
2932

30-
## Working On Issue:
31-
Having a clear work flow of code development can be very useful. Therefore, please work on branches that are linked to a relevant issue.
33+
## Working On Issue:
34+
35+
Having a clear work flow of code development can be very useful. Therefore, please work on branches that are linked to a relevant issue.
3236
Don't you know how to connect a branch to an issue? no problem, follow this [guid](https://docs.github.com/en/issues/tracking-your-work-with-issues/creating-a-branch-for-an-issue).
33-
37+
3438
## Developing In A Branch:
39+
3540
Please make sure you follow this list:
36-
1) Link your branch to the relevant issue.
37-
2) Use meaningful names for commits.
38-
3) Create small commits for each logic unit at a time.
39-
4) Use a [tasks list](https://docs.github.com/en/issues/tracking-your-work-with-issues/about-task-lists) to manage your work.
41+
42+
1. Link your branch to the relevant issue.
43+
2. Use meaningful names for commits.
44+
3. Create small commits for each logic unit at a time.
45+
4. Use a [tasks list](https://docs.github.com/en/issues/tracking-your-work-with-issues/about-task-lists) to manage your work.
4046

4147
## TSX Specifications:
48+
4249
Please follow this functional component pattern:
50+
4351
```
4452
interface Props {
4553
prop: <type>

e2e/home.spec.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1-
import { test, expect } from '@playwright/test'
1+
import { test, expect } from '@playwright/test';
22

3-
test('page should have title of "קהילת Pull Request"', async ({page}) => {
4-
await page.goto('http://localhost:3000/')
5-
const title = await page.title()
6-
expect(title).toBe('קהילת Pull Request')
3+
test('page should have title of "קהילת Pull Request"', async ({ page }) => {
4+
await page.goto('http://localhost:3000/');
5+
const title = await page.title();
6+
expect(title).toBe('קהילת Pull Request');
77
});
8-

people/AdirSlutzki.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@
55
"linkedin": "https://www.linkedin.com/in/adir-slutzki-1686189",
66
"twitter": "https://twitter.com/adircode",
77
"description": "מעצב UI/UX ומאסטר ב-CSS מרצה במכללות ברחבי הארץ ומכין שקשוקה מעולה, אוהב לעשות אנימציות ופרויקטים אישיים."
8-
}
8+
}

0 commit comments

Comments
 (0)