fix(infra): address CodeRabbit review + E2E test cleanup (STA-195) (#182)

* fix(infra): align WireMock stubs with real external API payloads (STA-195)

- Onfido: fix camelCase to snake_case (applicant_id, report_ids)
- Chainalysis: fix rating case (lowRisk to LOW), remove cluster field
- WorldCheck: replace matchedLists with sources, status to screeningState
- Modulr: add payout initiation adapter and WireMock stub
- Stripe: enrich stub with metadata and payment_method_types

Closes STA-195, STA-196, STA-197, STA-198, STA-199, STA-200

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(s5): pass appliedFxRate to RedemptionRequest for correct fallback fiat calculation (STA-195)

FallbackAdaptersConfig returned amount * 1.0 instead of amount * fxRate,
causing PayoutOrder tolerance check to reject the fiat amount in ITs.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(s5): apply spotless formatting to ModulrPayoutAdapterTest (STA-195)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* chore(infra): add make check excluding E2E + make e2e commands (STA-195)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(infra): address CodeRabbit review — field mapping, cache, scheme routing (STA-195)

- Modulr: use partnerName for destination.name (not bankCode/BIC)
- Modulr: resolve permittedScheme by PaymentRail (null for Faster Payments)
- Modulr: remove hardcoded default credentials, use empty defaults
- Onfido: fix cache verification bug (SENDER_CACHE_KEY used as both key and value)
- Modulr test: fix display name, use BIC for bankCode field

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(s2): remove unused never import from OnfidoKycAdapterTest (STA-195)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(infra): use --rerun flag for e2e-test to bypass Gradle cache (STA-195)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* refactor(infra): clean up Phase3PaymentE2ETest — remove unused code, add verification (STA-195)

- Remove unused fields: wireMockAdminClient, modulrWebhookSender
- Remove unused helpers: extractFieldFromPayment, waitForPaymentState(single)
- Add ledger journal entry verification (best-effort, non-blocking)
- Add Kafka payment.completed event verification (best-effort, non-blocking)
- Add response field assertions (paymentId, senderId, recipientId)
- Simplify waitForPaymentState to single expected state
- Second payment test now verifies ledger entries too

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* refactor(infra): align Phase3PaymentE2ETest with coding standards (STA-195)

- Extract magic values to named constants (amounts, currencies, timeouts)
- Add // given / when / then comment markers per testing standards
- Replace String[] with CollectionOrderInfo record for type safety
- Use ifPresentOrElse for Kafka event verification
- Remove verbose logging between assertions
- Simplify redundant conditional in waitForPaymentState

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: Puneethkumarck

Makefile

@@ -167,6 +167,6 @@ e2e-build: ## Build all service Docker images for E2E
 	$(GRADLE) $(foreach s,$(SERVICES),:$(s):$(s):jibDockerBuild) --parallel
 
 e2e-test: ## Run Phase 3 E2E tests (stack must be running)
-	PHASE3_TESTS_ENABLED=true $(GRADLE) :phase3-integration-tests:cleanTest :phase3-integration-tests:test
+	PHASE3_TESTS_ENABLED=true $(GRADLE) :phase3-integration-tests:test --rerun
 
 e2e: e2e-build e2e-up e2e-test ## Build images, start stack, run E2E tests