feat(infra): add external API request/response logging interceptor (STA-242)#247
Merged
Puneethkumarck merged 1 commit intoMar 22, 2026
Merged
Conversation
…TA-242) Add ExternalApiLoggingInterceptor in platform-infra that logs HTTP method, URL, headers (redacted), request/response bodies, and latency for all external API calls. Activated via app.external-api.logging.enabled=true (disabled by default — zero overhead in production). Wired into all 17 RestClient adapters across 6 services via @nullable constructor injection. Enabled in all 10 sandbox profiles. Closes #246 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Puneethkumarck
added
enhancement
WalkthroughThis PR introduces a unified HTTP request/response logging interceptor ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 19
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
merchant-onboarding/merchant-onboarding/src/main/java/com/stablecoin/payments/merchant/onboarding/infrastructure/kyb/OnfidoKybAdapter.java (2)
66-68:⚠️ Potential issue | 🟠 MajorMerchant PII
legalNamemust not appear in logs.Line 67 logs
legalNamedirectly, violating the coding guideline that KYB and merchant PII data must never appear in logs. Use only themerchantId.🔒 Proposed fix
- log.info("[ONFIDO] Creating applicant for merchant={} legalName={}", merchantId, legalName); + log.info("[ONFIDO] Creating applicant for merchant={}", merchantId);As per coding guidelines: "KYB and merchant PII data must never appear in logs".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@merchant-onboarding/merchant-onboarding/src/main/java/com/stablecoin/payments/merchant/onboarding/infrastructure/kyb/OnfidoKybAdapter.java` around lines 66 - 68, The log in OnfidoKybAdapter.submit currently includes merchant PII (legalName); remove legalName from the log and only log non-PII identifiers (merchantId) or a fixed message indicating PII omitted; update the log statement in the submit method so it does not reference legalName but preserves merchantId and context (e.g., log.info("[ONFIDO] Creating applicant for merchant={}", merchantId) or similar).
7-62:⚠️ Potential issue | 🟠 MajorRemove merchant PII from both adapter and interceptor logging.
The adapter logs
legalNamedirectly at line 67, violating the guideline that "KYB and merchant PII data must never appear in logs." Additionally,ExternalApiLoggingInterceptorperforms only size-based truncation (2000 chars default) with no field-level PII redaction—merchant names in the request body will be logged in full unless they exceed the truncation limit.Required fixes:
- Remove
legalNamefrom the adapter's log statement at line 67; use onlymerchantIdandapplicantId.- Implement field-level PII redaction in
ExternalApiLoggingInterceptorfor JSON body content (e.g., maskfirst_name,last_namefields) rather than relying on size-based truncation alone.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@merchant-onboarding/merchant-onboarding/src/main/java/com/stablecoin/payments/merchant/onboarding/infrastructure/kyb/OnfidoKybAdapter.java` around lines 7 - 62, Remove merchant PII from logs and add JSON field-level redaction: in OnfidoKybAdapter remove or change the log that currently includes legalName so it only logs merchantId and applicantId (reference: OnfidoKybAdapter constructor/wherever the log call with legalName is emitted); in ExternalApiLoggingInterceptor implement JSON-aware redaction before logging request/response bodies—when Content-Type is application/json parse the body and mask or replace sensitive keys (e.g., "first_name", "last_name", "legalName", "merchantName", "company_name") with a fixed redaction token like "[REDACTED]" prior to size truncation and writing to logs (reference: ExternalApiLoggingInterceptor.applyTo / logging methods) so field-level PII is never emitted.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@api-gateway-iam/api-gateway-iam/src/main/resources/application-sandbox.yml`:
- Around line 9-11: Update the sandbox configuration to disable generic external
API interceptor logging by setting the external-api.logging.enabled flag to
false (or remove the flag) so the gateway does not log OAuth/API-key traffic;
keep it off until a full secret-suppression implementation is in place or strict
masking/no-auth-header logging is enforced for the external-api logging path.
In
`@blockchain-custody/blockchain-custody/src/main/resources/application-sandbox.yml`:
- Around line 25-27: The external-api logging flag
(external-api.logging.enabled) is turned on and will cause interceptors to log
full RPC URLs containing the ${ALCHEMY_API_KEY} secret; change the configuration
to disable this logging (set external-api.logging.enabled to false) or implement
URL redaction in the request-logging interceptor so RPC URLs containing
${ALCHEMY_API_KEY} are masked before being written to logs; update the config
and/or the interceptor that emits RPC URL logs so it either respects
external-api.logging.enabled or strips/masks the ALCHEMY_API_KEY token from any
logged URL.
In
`@blockchain-custody/blockchain-custody/src/test/java/com/stablecoin/payments/custody/infrastructure/provider/solana/SolanaRpcAdapterRetryTest.java`:
- Line 145: The test currently constructs SolanaRpcAdapter with a null
RestClient (return new SolanaRpcAdapter(properties, null)); add an additional
test path that constructs a SolanaRpcAdapter using a non-null RestClient wired
with an interceptor to exercise the interceptor branch. Specifically, create or
reuse a RestClient/mock RestClient configured with at least one interceptor and
pass it into the SolanaRpcAdapter constructor in the test (e.g., instantiate a
RestClient with an interceptor or a Mockito mock that returns an
interceptor-enabled client) and assert normal adapter behavior to ensure the
interceptor-applied branch is exercised.
In
`@compliance-travel-rule/compliance-travel-rule/src/main/java/com/stablecoin/payments/compliance/infrastructure/provider/notabene/NotabeneTravelRuleAdapter.java`:
- Around line 57-61: mapToRequest is currently populating PII
(originator/beneficiary names and addresses) which will be captured by the
RestClient loggingInterceptor used to build apiClient; change mapToRequest to
include only non-PII identifiers (e.g., originatorId, beneficiaryId) and remove
names/addresses from the request payload, and/or update the loggingInterceptor
usage so request bodies are not logged (disable body logging or mask PII fields)
when building apiClient via applyTo(RestClient.builder(...),
loggingInterceptor). Ensure the Notabene request DTOs/fields referenced in
mapToRequest are adjusted accordingly and any downstream code expects IDs
instead of names/addresses.
- Around line 63-66: The authClient is built with the loggingInterceptor
applied, which will record sensitive OAuth fields (clientSecret in the token
request and accessToken in the response). Fix by not attaching the interceptor
to authClient: when constructing authClient (the RestClient built via
RestClient.builder() passed into applyTo(..., loggingInterceptor).build()),
create a separate RestClient for auth flows that uses the same requestFactory
and headers but omits applyTo/loggingInterceptor, or alternatively extend the
loggingInterceptor to redact body fields named clientSecret and accessToken
before logging; update the NotabeneTravelRuleAdapter construction to use the
non-intercepted client for token requests (authClient) or a redacting variant so
secrets are never emitted.
In
`@compliance-travel-rule/compliance-travel-rule/src/main/java/com/stablecoin/payments/compliance/infrastructure/provider/worldcheck/WorldCheckSanctionsAdapter.java`:
- Around line 49-54: The ExternalApiLoggingInterceptor attached to the
RestClient in WorldCheckSanctionsAdapter risks logging PII from WorldCheck
responses; either remove/disable the loggingInterceptor when building the
restClient in WorldCheckSanctionsAdapter, or replace it with/update it to a
redacting variant that masks names/addresses/other PII before logging (implement
field-level redaction inside the interceptor or add a
RedactingExternalApiLoggingInterceptor used here); if you choose to keep a
logging option, add a clear comment in WorldCheckSanctionsAdapter that the
interceptor must never be enabled in production and ensure tests cover the
redaction behavior.
In
`@compliance-travel-rule/compliance-travel-rule/src/main/resources/application-sandbox.yml`:
- Around line 12-14: The external-api logging toggle
(external-api.logging.enabled) must not be enabled while PII-safe logging is not
guaranteed; change external-api.logging.enabled from true to false (or
remove/guard the setting) and add a follow-up task to implement PII
redaction/ID-only logging before re-enabling; ensure any code that reads
external-api.logging.enabled enforces redaction (i.e., only logs IDs) before
allowing the flag to be true.
In
`@compliance-travel-rule/compliance-travel-rule/src/test/java/com/stablecoin/payments/compliance/infrastructure/provider/notabene/NotabeneTravelRuleAdapterTest.java`:
- Line 64: Add a new unit test in NotabeneTravelRuleAdapterTest that constructs
NotabeneTravelRuleAdapter with a non-null interceptor (instead of null) and
invokes the adapter path that processes IVMS payloads (same method exercised
elsewhere in the test class). Provide an IVMS payload containing PII
(names/addresses) and an ID-only variant, capture logs using the existing test
logging helper or a TestAppender, and assert that the captured logs do NOT
contain the PII strings but DO contain the IDs (e.g.,
assertFalse(logs.contains("Alice")/addresses) and
assertTrue(logs.contains("payerId"/"beneficiaryId")). Ensure the test name
clearly indicates interceptor-enabled redaction (e.g.,
testInterceptorRedactsPII) and reuse the existing properties and adapter
construction pattern.
In
`@fx-liquidity-engine/fx-liquidity-engine/src/test/java/com/stablecoin/payments/fx/infrastructure/provider/frankfurter/FrankfurterRateAdapterTest.java`:
- Line 42: Add a unit test that constructs FrankfurterRateAdapter with a
non-null ExternalApiLoggingInterceptor (instead of null) to cover the
interceptor constructor path; instantiate the interceptor (or a mock) and pass
it to new FrankfurterRateAdapter(properties, interceptor), then call a public
adapter method (e.g., the rate-fetching method exposed by
FrankfurterRateAdapter) to ensure the RestClient is wired with the interceptor
and request behavior is unchanged—assert expected response or interaction (use a
mock RestClient/HTTP transport or verify logs/interceptor invocation) so the
non-null-interceptor branch is exercised.
In
`@ledger-accounting/ledger-accounting/src/main/resources/application-sandbox.yml`:
- Around line 9-11: Remove the misleading external-api toggle from the sandbox
config when there are no outbound HTTP clients: delete the
external-api.logging.enabled property (app.external-api.logging.enabled) from
application-sandbox.yml, or explicitly set it to false and add a short comment
that it only applies when RestClient/ outbound HTTP calls are present; update
any related docs or config readers that expect this flag to avoid confusion.
In `@merchant-iam/merchant-iam/src/main/resources/application-sandbox.yml`:
- Around line 9-11: The property external-api.logging.enabled is currently true
and must be disabled until secret-safe redaction is implemented; change
external-api.logging.enabled to false (or remove the setting) in the
configuration so request/response logging is not enabled for the IAM service,
and add a TODO comment referencing implementing secret-safe redaction before
re-enabling logging for external-api.
In
`@merchant-onboarding/merchant-onboarding/src/main/resources/application-sandbox.yml`:
- Around line 9-11: The configuration enables raw external API logging via the
external-api.logging.enabled property which may leak KYB/merchant PII; change
external-api.logging.enabled to false (or remove the key) in sandbox config to
disable outbound API logging, or if logging must remain on implement and
reference a sanitization filter that strips/scrubs PII from request/response
bodies and headers before logging (e.g., wire in a logging sanitizer middleware
used by the external API client) and ensure the sanitizer is invoked wherever
external-api logging is emitted.
In
`@payment-orchestrator/payment-orchestrator/src/main/resources/application-sandbox.yml`:
- Around line 9-11: The external-api logging block currently enables body
logging via external-api.logging.enabled: true; add an explicit conservative
payload cap by introducing external-api.logging.max-body-length with a small
integer (e.g., 1024 or 2048) to limit logged request/response bodies, so update
the external-api -> logging section (the external-api.logging.enabled and new
external-api.logging.max-body-length keys) to enforce the max-body-length
alongside enabled: true.
In
`@platform-infra/src/main/java/com/stablecoin/payments/platform/infrastructure/http/ExternalApiLoggingConfig.java`:
- Around line 18-24: In ExternalApiLoggingConfig, replace the fully-qualified
type in the bean method signature by importing Environment and using it
directly: change the method
externalApiLoggingInterceptor(org.springframework.core.env.Environment env) to
use Environment env (after adding an import for
org.springframework.core.env.Environment) so the code is stylistically
consistent with other Spring imports; keep the rest of the method (retrieving
"app.external-api.logging.max-body-length" and constructing
ExternalApiLoggingInterceptor) unchanged.
In
`@platform-infra/src/main/java/com/stablecoin/payments/platform/infrastructure/http/ExternalApiLoggingInterceptor.java`:
- Around line 55-65: The intercept method currently always constructs
BufferedResponse (which eagerly reads the body) causing overhead; guard that
creation with the logger: call execution.execute(request, body) first, compute
latency, then if log.isDebugEnabled() create new BufferedResponse(response) and
call logResponse(request, buffered, latency) and return buffered; otherwise skip
creating BufferedResponse, call a lightweight logResponseSummary or
logResponse(request, response, latency) variant that does not read the body, and
return the original response. Update or add a non-buffering
logResponseSummary/logResponse overload if needed and remove any eager reads in
BufferedResponse when debugging is disabled.
- Around line 55-66: The intercept method in ExternalApiLoggingInterceptor
currently doesn't log failures when execution.execute(request, body) throws;
wrap the call to execution.execute in a try/catch, capture elapsed time using
startMs, and in the catch block log the request method/URI and elapsed
milliseconds before rethrowing the exception; use the existing logResponse or a
dedicated error log path consistent with logRequest/logResponse semantics and
return a BufferedResponse only on success (retain BufferedResponse wrapping for
the successful response path).
- Around line 79-88: The logResponse method currently only logs status and body;
update it to also log response headers using the existing logHeaders redaction
path so headers are redacted consistently. Inside logResponse(HttpRequest
request, BufferedResponse response, long latencyMs) call the same
logHeaders(...) helper (passing response.headers() or equivalent) before/after
logging the body, ensuring you reuse the redact logic and keep the debug-level
guard (log.isDebugEnabled()). Reference BufferedResponse, logResponse, and
logHeaders to locate and apply the change.
In
`@platform-infra/src/test/java/com/stablecoin/payments/platform/infrastructure/http/ExternalApiLoggingInterceptorTest.java`:
- Around line 9-51: Add unit tests covering
ExternalApiLoggingInterceptor.intercept to verify request/response logging,
header handling, and body truncation; create tests that register the interceptor
with a RestTemplate and use MockRestServiceServer (or
MockRestServiceServer-like) to simulate responses, assert that the logger
received redacted values via ExternalApiLoggingInterceptor.redact for sensitive
headers/bodies and that long bodies are truncated (reference intercept in
ExternalApiLoggingInterceptor and helper methods like redact and any
truncateBody/formatting logic), include cases for null bodies, short values,
headers present/missing, and non-2xx responses so logging paths are exercised.
- Around line 18-21: The test should avoid using a realistic-looking API key;
update the fixture in shouldRedactLongValue to use an obviously synthetic secret
(e.g., "sk_test_FAKE_KEY_12345" or similar) instead of
"sk_test_51TCRge3nnME1dfOB" so secret scanners won’t flag it; locate the
assertion that calls ExternalApiLoggingInterceptor.redact and replace only the
input string while keeping the expected output ("sk_test_***") unchanged.
---
Outside diff comments:
In
`@merchant-onboarding/merchant-onboarding/src/main/java/com/stablecoin/payments/merchant/onboarding/infrastructure/kyb/OnfidoKybAdapter.java`:
- Around line 66-68: The log in OnfidoKybAdapter.submit currently includes
merchant PII (legalName); remove legalName from the log and only log non-PII
identifiers (merchantId) or a fixed message indicating PII omitted; update the
log statement in the submit method so it does not reference legalName but
preserves merchantId and context (e.g., log.info("[ONFIDO] Creating applicant
for merchant={}", merchantId) or similar).
- Around line 7-62: Remove merchant PII from logs and add JSON field-level
redaction: in OnfidoKybAdapter remove or change the log that currently includes
legalName so it only logs merchantId and applicantId (reference:
OnfidoKybAdapter constructor/wherever the log call with legalName is emitted);
in ExternalApiLoggingInterceptor implement JSON-aware redaction before logging
request/response bodies—when Content-Type is application/json parse the body and
mask or replace sensitive keys (e.g., "first_name", "last_name", "legalName",
"merchantName", "company_name") with a fixed redaction token like "[REDACTED]"
prior to size truncation and writing to logs (reference:
ExternalApiLoggingInterceptor.applyTo / logging methods) so field-level PII is
never emitted.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: f099d731-c254-4a05-b86d-f7a3878dc5c0
📒 Files selected for processing (65)
api-gateway-iam/api-gateway-iam/src/main/resources/application-sandbox.ymlblockchain-custody/blockchain-custody/src/main/java/com/stablecoin/payments/custody/infrastructure/provider/dev/DevCustodyAdapter.javablockchain-custody/blockchain-custody/src/main/java/com/stablecoin/payments/custody/infrastructure/provider/evm/EvmRpcAdapter.javablockchain-custody/blockchain-custody/src/main/java/com/stablecoin/payments/custody/infrastructure/provider/fireblocks/FireblocksCustodyAdapter.javablockchain-custody/blockchain-custody/src/main/java/com/stablecoin/payments/custody/infrastructure/provider/solana/SolanaRpcAdapter.javablockchain-custody/blockchain-custody/src/main/resources/application-sandbox.ymlblockchain-custody/blockchain-custody/src/test/java/com/stablecoin/payments/custody/infrastructure/provider/evm/EvmRpcAdapterRetryTest.javablockchain-custody/blockchain-custody/src/test/java/com/stablecoin/payments/custody/infrastructure/provider/evm/EvmRpcAdapterSandboxTest.javablockchain-custody/blockchain-custody/src/test/java/com/stablecoin/payments/custody/infrastructure/provider/evm/EvmRpcAdapterTest.javablockchain-custody/blockchain-custody/src/test/java/com/stablecoin/payments/custody/infrastructure/provider/fireblocks/FireblocksCustodyAdapterRetryTest.javablockchain-custody/blockchain-custody/src/test/java/com/stablecoin/payments/custody/infrastructure/provider/fireblocks/FireblocksCustodyAdapterSandboxTest.javablockchain-custody/blockchain-custody/src/test/java/com/stablecoin/payments/custody/infrastructure/provider/fireblocks/FireblocksCustodyAdapterTest.javablockchain-custody/blockchain-custody/src/test/java/com/stablecoin/payments/custody/infrastructure/provider/solana/SolanaRpcAdapterRetryTest.javablockchain-custody/blockchain-custody/src/test/java/com/stablecoin/payments/custody/infrastructure/provider/solana/SolanaRpcAdapterSandboxTest.javablockchain-custody/blockchain-custody/src/test/java/com/stablecoin/payments/custody/infrastructure/provider/solana/SolanaRpcAdapterTest.javacompliance-travel-rule/compliance-travel-rule/src/main/java/com/stablecoin/payments/compliance/infrastructure/provider/chainalysis/ChainalysisAmlAdapter.javacompliance-travel-rule/compliance-travel-rule/src/main/java/com/stablecoin/payments/compliance/infrastructure/provider/notabene/NotabeneTravelRuleAdapter.javacompliance-travel-rule/compliance-travel-rule/src/main/java/com/stablecoin/payments/compliance/infrastructure/provider/ofacsdn/SdnListDownloader.javacompliance-travel-rule/compliance-travel-rule/src/main/java/com/stablecoin/payments/compliance/infrastructure/provider/onfido/OnfidoKycAdapter.javacompliance-travel-rule/compliance-travel-rule/src/main/java/com/stablecoin/payments/compliance/infrastructure/provider/persona/PersonaKycAdapter.javacompliance-travel-rule/compliance-travel-rule/src/main/java/com/stablecoin/payments/compliance/infrastructure/provider/worldcheck/WorldCheckSanctionsAdapter.javacompliance-travel-rule/compliance-travel-rule/src/main/resources/application-sandbox.ymlcompliance-travel-rule/compliance-travel-rule/src/test/java/com/stablecoin/payments/compliance/infrastructure/provider/chainalysis/ChainalysisAmlAdapterRetryTest.javacompliance-travel-rule/compliance-travel-rule/src/test/java/com/stablecoin/payments/compliance/infrastructure/provider/chainalysis/ChainalysisAmlAdapterTest.javacompliance-travel-rule/compliance-travel-rule/src/test/java/com/stablecoin/payments/compliance/infrastructure/provider/notabene/NotabeneTravelRuleAdapterTest.javacompliance-travel-rule/compliance-travel-rule/src/test/java/com/stablecoin/payments/compliance/infrastructure/provider/ofacsdn/OfacSdnSanctionsAdapterTest.javacompliance-travel-rule/compliance-travel-rule/src/test/java/com/stablecoin/payments/compliance/infrastructure/provider/onfido/OnfidoKycAdapterRetryTest.javacompliance-travel-rule/compliance-travel-rule/src/test/java/com/stablecoin/payments/compliance/infrastructure/provider/onfido/OnfidoKycAdapterSandboxTest.javacompliance-travel-rule/compliance-travel-rule/src/test/java/com/stablecoin/payments/compliance/infrastructure/provider/onfido/OnfidoKycAdapterTest.javacompliance-travel-rule/compliance-travel-rule/src/test/java/com/stablecoin/payments/compliance/infrastructure/provider/persona/PersonaKycAdapterTest.javacompliance-travel-rule/compliance-travel-rule/src/test/java/com/stablecoin/payments/compliance/infrastructure/provider/worldcheck/WorldCheckSanctionsAdapterRetryTest.javacompliance-travel-rule/compliance-travel-rule/src/test/java/com/stablecoin/payments/compliance/infrastructure/provider/worldcheck/WorldCheckSanctionsAdapterTest.javafiat-off-ramp/fiat-off-ramp/src/main/java/com/stablecoin/payments/offramp/infrastructure/provider/circle/CircleRedemptionAdapter.javafiat-off-ramp/fiat-off-ramp/src/main/java/com/stablecoin/payments/offramp/infrastructure/provider/modulr/ModulrPayoutAdapter.javafiat-off-ramp/fiat-off-ramp/src/main/resources/application-sandbox.ymlfiat-off-ramp/fiat-off-ramp/src/test/java/com/stablecoin/payments/offramp/infrastructure/provider/circle/CircleRedemptionAdapterRetryTest.javafiat-off-ramp/fiat-off-ramp/src/test/java/com/stablecoin/payments/offramp/infrastructure/provider/circle/CircleRedemptionAdapterSandboxTest.javafiat-off-ramp/fiat-off-ramp/src/test/java/com/stablecoin/payments/offramp/infrastructure/provider/circle/CircleRedemptionAdapterTest.javafiat-off-ramp/fiat-off-ramp/src/test/java/com/stablecoin/payments/offramp/infrastructure/provider/modulr/ModulrPayoutAdapterRetryTest.javafiat-off-ramp/fiat-off-ramp/src/test/java/com/stablecoin/payments/offramp/infrastructure/provider/modulr/ModulrPayoutAdapterSandboxTest.javafiat-off-ramp/fiat-off-ramp/src/test/java/com/stablecoin/payments/offramp/infrastructure/provider/modulr/ModulrPayoutAdapterTest.javafiat-on-ramp/fiat-on-ramp/src/main/java/com/stablecoin/payments/onramp/infrastructure/provider/stripe/StripePspAdapter.javafiat-on-ramp/fiat-on-ramp/src/main/resources/application-sandbox.ymlfiat-on-ramp/fiat-on-ramp/src/test/java/com/stablecoin/payments/onramp/infrastructure/provider/stripe/StripePspAdapterRetryTest.javafiat-on-ramp/fiat-on-ramp/src/test/java/com/stablecoin/payments/onramp/infrastructure/provider/stripe/StripePspAdapterTest.javafx-liquidity-engine/fx-liquidity-engine/src/main/java/com/stablecoin/payments/fx/infrastructure/provider/frankfurter/FrankfurterRateAdapter.javafx-liquidity-engine/fx-liquidity-engine/src/main/java/com/stablecoin/payments/fx/infrastructure/provider/refinitiv/RefinitivRateAdapter.javafx-liquidity-engine/fx-liquidity-engine/src/main/resources/application-sandbox.ymlfx-liquidity-engine/fx-liquidity-engine/src/test/java/com/stablecoin/payments/fx/infrastructure/provider/frankfurter/FrankfurterRateAdapterSandboxTest.javafx-liquidity-engine/fx-liquidity-engine/src/test/java/com/stablecoin/payments/fx/infrastructure/provider/frankfurter/FrankfurterRateAdapterTest.javafx-liquidity-engine/fx-liquidity-engine/src/test/java/com/stablecoin/payments/fx/infrastructure/provider/refinitiv/RefinitivRateAdapterRetryTest.javafx-liquidity-engine/fx-liquidity-engine/src/test/java/com/stablecoin/payments/fx/infrastructure/provider/refinitiv/RefinitivRateAdapterTest.javaledger-accounting/ledger-accounting/src/main/resources/application-sandbox.ymlmerchant-iam/merchant-iam/src/main/resources/application-sandbox.ymlmerchant-onboarding/merchant-onboarding/src/main/java/com/stablecoin/payments/merchant/onboarding/infrastructure/kyb/CompaniesHouseAdapter.javamerchant-onboarding/merchant-onboarding/src/main/java/com/stablecoin/payments/merchant/onboarding/infrastructure/kyb/OnfidoKybAdapter.javamerchant-onboarding/merchant-onboarding/src/main/resources/application-sandbox.ymlmerchant-onboarding/merchant-onboarding/src/test/java/com/stablecoin/payments/merchant/onboarding/infrastructure/kyb/CompaniesHouseAdapterSandboxTest.javamerchant-onboarding/merchant-onboarding/src/test/java/com/stablecoin/payments/merchant/onboarding/infrastructure/kyb/CompaniesHouseAdapterTest.javamerchant-onboarding/merchant-onboarding/src/test/java/com/stablecoin/payments/merchant/onboarding/infrastructure/kyb/OnfidoKybAdapterSandboxTest.javamerchant-onboarding/merchant-onboarding/src/test/java/com/stablecoin/payments/merchant/onboarding/infrastructure/kyb/OnfidoKybAdapterTest.javapayment-orchestrator/payment-orchestrator/src/main/resources/application-sandbox.ymlplatform-infra/src/main/java/com/stablecoin/payments/platform/infrastructure/http/ExternalApiLoggingConfig.javaplatform-infra/src/main/java/com/stablecoin/payments/platform/infrastructure/http/ExternalApiLoggingInterceptor.javaplatform-infra/src/test/java/com/stablecoin/payments/platform/infrastructure/http/ExternalApiLoggingInterceptorTest.java
Comment on lines
+9
to
+11
| external-api: | ||
| logging: | ||
| enabled: true |
There was a problem hiding this comment.
Disable generic external API logging for gateway sandbox until full secret suppression is enforced.
Line 9 enables interceptor logging in the gateway, which processes OAuth/API-key traffic. Partial masking is not sufficient for this module; keep this toggle off here or enforce strict full masking/no-auth-header logging before enabling.
As per coding guidelines, "API keys and OAuth secrets must never be logged."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@api-gateway-iam/api-gateway-iam/src/main/resources/application-sandbox.yml`
around lines 9 - 11, Update the sandbox configuration to disable generic
external API interceptor logging by setting the external-api.logging.enabled
flag to false (or remove the flag) so the gateway does not log OAuth/API-key
traffic; keep it off until a full secret-suppression implementation is in place
or strict masking/no-auth-header logging is enforced for the external-api
logging path.
Comment on lines
+25
to
+27
| external-api: | ||
| logging: | ||
| enabled: true |
There was a problem hiding this comment.
Enabling logging here can leak Alchemy credentials via URL logging.
With Lines 25-27 enabled, interceptor URL logs will include RPC URLs containing ${ALCHEMY_API_KEY} (e.g., Line 34), exposing secrets.
Suggested immediate mitigation
external-api:
logging:
- enabled: true
+ enabled: false📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| external-api: | |
| logging: | |
| enabled: true | |
| external-api: | |
| logging: | |
| enabled: false |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@blockchain-custody/blockchain-custody/src/main/resources/application-sandbox.yml`
around lines 25 - 27, The external-api logging flag
(external-api.logging.enabled) is turned on and will cause interceptors to log
full RPC URLs containing the ${ALCHEMY_API_KEY} secret; change the configuration
to disable this logging (set external-api.logging.enabled to false) or implement
URL redaction in the request-logging interceptor so RPC URLs containing
${ALCHEMY_API_KEY} are masked before being written to logs; update the config
and/or the interceptor that emits RPC URL logs so it either respects
external-api.logging.enabled or strips/masks the ALCHEMY_API_KEY token from any
logged URL.
| @Bean | ||
| SolanaRpcAdapter solanaRpcAdapter(SolanaChainProperties properties) { | ||
| return new SolanaRpcAdapter(properties); | ||
| return new SolanaRpcAdapter(properties, null); |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Add one interceptor-enabled test path for wiring safety.
Line 145 always passes null, so this suite does not exercise the interceptor-applied RestClient branch. Add one test configuration path that injects a non-null interceptor to catch wiring regressions early.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@blockchain-custody/blockchain-custody/src/test/java/com/stablecoin/payments/custody/infrastructure/provider/solana/SolanaRpcAdapterRetryTest.java`
at line 145, The test currently constructs SolanaRpcAdapter with a null
RestClient (return new SolanaRpcAdapter(properties, null)); add an additional
test path that constructs a SolanaRpcAdapter using a non-null RestClient wired
with an interceptor to exercise the interceptor branch. Specifically, create or
reuse a RestClient/mock RestClient configured with at least one interceptor and
pass it into the SolanaRpcAdapter constructor in the test (e.g., instantiate a
RestClient with an interceptor or a Mockito mock that returns an
interceptor-enabled client) and assert normal adapter behavior to ensure the
interceptor-applied branch is exercised.
Comment on lines
+57
to
61
| this.apiClient = applyTo(RestClient.builder() | ||
| .baseUrl(properties.baseUrl()) | ||
| .defaultHeader(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON_VALUE) | ||
| .requestFactory(requestFactory) | ||
| .requestFactory(requestFactory), loggingInterceptor) | ||
| .build(); |
There was a problem hiding this comment.
Travel Rule request bodies contain PII that will be logged.
The mapToRequest() method (lines 143-189) includes originator/beneficiary names and addresses in the request body. The interceptor will log these, violating the compliance-travel-rule module's PII logging prohibition.
As per coding guidelines: "PII data (names, addresses) must never appear in logs — use IDs only."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@compliance-travel-rule/compliance-travel-rule/src/main/java/com/stablecoin/payments/compliance/infrastructure/provider/notabene/NotabeneTravelRuleAdapter.java`
around lines 57 - 61, mapToRequest is currently populating PII
(originator/beneficiary names and addresses) which will be captured by the
RestClient loggingInterceptor used to build apiClient; change mapToRequest to
include only non-PII identifiers (e.g., originatorId, beneficiaryId) and remove
names/addresses from the request payload, and/or update the loggingInterceptor
usage so request bodies are not logged (disable body logging or mask PII fields)
when building apiClient via applyTo(RestClient.builder(...),
loggingInterceptor). Ensure the Notabene request DTOs/fields referenced in
mapToRequest are adjusted accordingly and any downstream code expects IDs
instead of names/addresses.
Comment on lines
+63
to
66
| this.authClient = applyTo(RestClient.builder() | ||
| .defaultHeader(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON_VALUE) | ||
| .requestFactory(requestFactory) | ||
| .requestFactory(requestFactory), loggingInterceptor) | ||
| .build(); |
There was a problem hiding this comment.
OAuth credentials may be logged in request/response bodies.
The authClient will log the token request containing clientSecret (line 119) and the response containing accessToken. Header redaction doesn't cover body content. Consider:
- Not applying the interceptor to
authClient, or - Extending the interceptor to redact sensitive body fields.
Option 1: Skip interceptor for authClient
this.authClient = applyTo(RestClient.builder()
.defaultHeader(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON_VALUE)
- .requestFactory(requestFactory), loggingInterceptor)
+ .requestFactory(requestFactory), null)
.build();📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| this.authClient = applyTo(RestClient.builder() | |
| .defaultHeader(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON_VALUE) | |
| .requestFactory(requestFactory) | |
| .requestFactory(requestFactory), loggingInterceptor) | |
| .build(); | |
| this.authClient = applyTo(RestClient.builder() | |
| .defaultHeader(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON_VALUE) | |
| .requestFactory(requestFactory), null) | |
| .build(); |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@compliance-travel-rule/compliance-travel-rule/src/main/java/com/stablecoin/payments/compliance/infrastructure/provider/notabene/NotabeneTravelRuleAdapter.java`
around lines 63 - 66, The authClient is built with the loggingInterceptor
applied, which will record sensitive OAuth fields (clientSecret in the token
request and accessToken in the response). Fix by not attaching the interceptor
to authClient: when constructing authClient (the RestClient built via
RestClient.builder() passed into applyTo(..., loggingInterceptor).build()),
create a separate RestClient for auth flows that uses the same requestFactory
and headers but omits applyTo/loggingInterceptor, or alternatively extend the
loggingInterceptor to redact body fields named clientSecret and accessToken
before logging; update the NotabeneTravelRuleAdapter construction to use the
non-intercepted client for token requests (authClient) or a redacting variant so
secrets are never emitted.
Comment on lines
+55
to
+65
| public ClientHttpResponse intercept(HttpRequest request, byte[] body, | ||
| ClientHttpRequestExecution execution) throws IOException { | ||
| var startMs = System.currentTimeMillis(); | ||
| logRequest(request, body); | ||
|
|
||
| var response = execution.execute(request, body); | ||
|
|
||
| var latencyMs = System.currentTimeMillis() - startMs; | ||
| var buffered = new BufferedResponse(response); | ||
| logResponse(request, buffered, latencyMs); | ||
| return buffered; |
There was a problem hiding this comment.
DEBUG guard is too late; full response buffering runs on every call.
On Line 63, BufferedResponse is always created, and on Line 124 it eagerly reads all bytes. This happens even when DEBUG logging is off, adding avoidable latency/memory pressure to all outbound calls.
Proposed fix
`@Override`
public ClientHttpResponse intercept(HttpRequest request, byte[] body,
ClientHttpRequestExecution execution) throws IOException {
+ if (!log.isDebugEnabled()) {
+ return execution.execute(request, body);
+ }
+
var startMs = System.currentTimeMillis();
logRequest(request, body);
var response = execution.execute(request, body);
var latencyMs = System.currentTimeMillis() - startMs;
var buffered = new BufferedResponse(response);
logResponse(request, buffered, latencyMs);
return buffered;
}Also applies to: 122-125
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@platform-infra/src/main/java/com/stablecoin/payments/platform/infrastructure/http/ExternalApiLoggingInterceptor.java`
around lines 55 - 65, The intercept method currently always constructs
BufferedResponse (which eagerly reads the body) causing overhead; guard that
creation with the logger: call execution.execute(request, body) first, compute
latency, then if log.isDebugEnabled() create new BufferedResponse(response) and
call logResponse(request, buffered, latency) and return buffered; otherwise skip
creating BufferedResponse, call a lightweight logResponseSummary or
logResponse(request, response, latency) variant that does not read the body, and
return the original response. Update or add a non-buffering
logResponseSummary/logResponse overload if needed and remove any eager reads in
BufferedResponse when debugging is disabled.
Comment on lines
+55
to
+66
| public ClientHttpResponse intercept(HttpRequest request, byte[] body, | ||
| ClientHttpRequestExecution execution) throws IOException { | ||
| var startMs = System.currentTimeMillis(); | ||
| logRequest(request, body); | ||
|
|
||
| var response = execution.execute(request, body); | ||
|
|
||
| var latencyMs = System.currentTimeMillis() - startMs; | ||
| var buffered = new BufferedResponse(response); | ||
| logResponse(request, buffered, latencyMs); | ||
| return buffered; | ||
| } |
There was a problem hiding this comment.
Failure path is not logged with latency.
If execution.execute(...) throws, the interceptor emits no response/failure log, which makes external-call triage harder. Add a catch block to log method/URI/elapsed time before rethrowing.
Proposed fix
`@Override`
public ClientHttpResponse intercept(HttpRequest request, byte[] body,
ClientHttpRequestExecution execution) throws IOException {
if (!log.isDebugEnabled()) {
return execution.execute(request, body);
}
var startMs = System.currentTimeMillis();
logRequest(request, body);
-
- var response = execution.execute(request, body);
-
- var latencyMs = System.currentTimeMillis() - startMs;
- var buffered = new BufferedResponse(response);
- logResponse(request, buffered, latencyMs);
- return buffered;
+ try {
+ var response = execution.execute(request, body);
+ var latencyMs = System.currentTimeMillis() - startMs;
+ var buffered = new BufferedResponse(response);
+ logResponse(request, buffered, latencyMs);
+ return buffered;
+ } catch (IOException ex) {
+ var latencyMs = System.currentTimeMillis() - startMs;
+ log.debug("<-- HTTP FAILED {} {} ({}ms): {}",
+ request.getMethod(), request.getURI(), latencyMs, ex.getMessage());
+ throw ex;
+ }
}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@platform-infra/src/main/java/com/stablecoin/payments/platform/infrastructure/http/ExternalApiLoggingInterceptor.java`
around lines 55 - 66, The intercept method in ExternalApiLoggingInterceptor
currently doesn't log failures when execution.execute(request, body) throws;
wrap the call to execution.execute in a try/catch, capture elapsed time using
startMs, and in the catch block log the request method/URI and elapsed
milliseconds before rethrowing the exception; use the existing logResponse or a
dedicated error log path consistent with logRequest/logResponse semantics and
return a BufferedResponse only on success (retain BufferedResponse wrapping for
the successful response path).
Comment on lines
+79
to
+88
| private void logResponse(HttpRequest request, BufferedResponse response, long latencyMs) { | ||
| if (!log.isDebugEnabled()) { | ||
| return; | ||
| } | ||
| log.debug("<-- {} {} ({}ms)", response.statusCode().value(), request.getURI(), latencyMs); | ||
| var responseBody = new String(response.bodyBytes, StandardCharsets.UTF_8); | ||
| if (!responseBody.isEmpty()) { | ||
| log.debug("<-- Body: {}", truncate(responseBody)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Response headers are missing from response logs.
logResponse(...) logs status/body only. The stated acceptance criteria includes response headers, and this method currently omits them. Reuse the same logHeaders(...) redaction path for response headers as well.
Proposed fix
private void logResponse(HttpRequest request, BufferedResponse response, long latencyMs) {
if (!log.isDebugEnabled()) {
return;
}
log.debug("<-- {} {} ({}ms)", response.statusCode().value(), request.getURI(), latencyMs);
+ logHeaders("<--", response.getHeaders());
var responseBody = new String(response.bodyBytes, StandardCharsets.UTF_8);
if (!responseBody.isEmpty()) {
log.debug("<-- Body: {}", truncate(responseBody));
}
}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@platform-infra/src/main/java/com/stablecoin/payments/platform/infrastructure/http/ExternalApiLoggingInterceptor.java`
around lines 79 - 88, The logResponse method currently only logs status and
body; update it to also log response headers using the existing logHeaders
redaction path so headers are redacted consistently. Inside
logResponse(HttpRequest request, BufferedResponse response, long latencyMs) call
the same logHeaders(...) helper (passing response.headers() or equivalent)
before/after logging the body, ensuring you reuse the redact logic and keep the
debug-level guard (log.isDebugEnabled()). Reference BufferedResponse,
logResponse, and logHeaders to locate and apply the change.
Comment on lines
+9
to
+51
| @DisplayName("ExternalApiLoggingInterceptor") | ||
| class ExternalApiLoggingInterceptorTest { | ||
|
|
||
| @Nested | ||
| @DisplayName("redact") | ||
| class Redact { | ||
|
|
||
| @Test | ||
| @DisplayName("should redact long value keeping first 8 chars") | ||
| void shouldRedactLongValue() { | ||
| assertThat(ExternalApiLoggingInterceptor.redact("sk_test_51TCRge3nnME1dfOB")) | ||
| .isEqualTo("sk_test_***"); | ||
| } | ||
|
|
||
| @Test | ||
| @DisplayName("should fully redact short value") | ||
| void shouldFullyRedactShortValue() { | ||
| assertThat(ExternalApiLoggingInterceptor.redact("short")) | ||
| .isEqualTo("***"); | ||
| } | ||
|
|
||
| @Test | ||
| @DisplayName("should return *** for null") | ||
| void shouldReturnStarsForNull() { | ||
| assertThat(ExternalApiLoggingInterceptor.redact(null)) | ||
| .isEqualTo("***"); | ||
| } | ||
|
|
||
| @Test | ||
| @DisplayName("should redact exactly 8-char boundary") | ||
| void shouldRedactExactBoundary() { | ||
| assertThat(ExternalApiLoggingInterceptor.redact("12345678")) | ||
| .isEqualTo("***"); | ||
| } | ||
|
|
||
| @Test | ||
| @DisplayName("should keep first 8 chars for 9-char value") | ||
| void shouldKeepFirstEightForNineChars() { | ||
| assertThat(ExternalApiLoggingInterceptor.redact("123456789")) | ||
| .isEqualTo("12345678***"); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider adding tests for intercept() method.
Current coverage validates redact() only. The interceptor's core functionality (request/response logging, body truncation, header handling) lacks unit test coverage. MockRestServiceServer or similar could verify logging behavior.
Want me to draft tests for the intercept() method using MockRestServiceServer?
🧰 Tools
🪛 Betterleaks (1.1.1)
[high] 19-19: Found a Stripe Access Token, posing a risk to payment processing services and sensitive financial data.
(stripe-access-token)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@platform-infra/src/test/java/com/stablecoin/payments/platform/infrastructure/http/ExternalApiLoggingInterceptorTest.java`
around lines 9 - 51, Add unit tests covering
ExternalApiLoggingInterceptor.intercept to verify request/response logging,
header handling, and body truncation; create tests that register the interceptor
with a RestTemplate and use MockRestServiceServer (or
MockRestServiceServer-like) to simulate responses, assert that the logger
received redacted values via ExternalApiLoggingInterceptor.redact for sensitive
headers/bodies and that long bodies are truncated (reference intercept in
ExternalApiLoggingInterceptor and helper methods like redact and any
truncateBody/formatting logic), include cases for null bodies, short values,
headers present/missing, and non-2xx responses so logging paths are exercised.
Comment on lines
+18
to
+21
| void shouldRedactLongValue() { | ||
| assertThat(ExternalApiLoggingInterceptor.redact("sk_test_51TCRge3nnME1dfOB")) | ||
| .isEqualTo("sk_test_***"); | ||
| } |
There was a problem hiding this comment.
Replace realistic-looking API key with obviously fake fixture.
"sk_test_51TCRge3nnME1dfOB" matches the Stripe test key pattern and triggers secret scanners. Use a clearly synthetic value.
Proposed fix
`@Test`
`@DisplayName`("should redact long value keeping first 8 chars")
void shouldRedactLongValue() {
- assertThat(ExternalApiLoggingInterceptor.redact("sk_test_51TCRge3nnME1dfOB"))
- .isEqualTo("sk_test_***");
+ assertThat(ExternalApiLoggingInterceptor.redact("AAAABBBB_secret_value_here"))
+ .isEqualTo("AAAABBBB***");
}As per coding guidelines: "No hardcoded secrets or real PII in test fixtures."
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| void shouldRedactLongValue() { | |
| assertThat(ExternalApiLoggingInterceptor.redact("sk_test_51TCRge3nnME1dfOB")) | |
| .isEqualTo("sk_test_***"); | |
| } | |
| void shouldRedactLongValue() { | |
| assertThat(ExternalApiLoggingInterceptor.redact("AAAABBBB_secret_value_here")) | |
| .isEqualTo("AAAABBBB***"); | |
| } |
🧰 Tools
🪛 Betterleaks (1.1.1)
[high] 19-19: Found a Stripe Access Token, posing a risk to payment processing services and sensitive financial data.
(stripe-access-token)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@platform-infra/src/test/java/com/stablecoin/payments/platform/infrastructure/http/ExternalApiLoggingInterceptorTest.java`
around lines 18 - 21, The test should avoid using a realistic-looking API key;
update the fixture in shouldRedactLongValue to use an obviously synthetic secret
(e.g., "sk_test_FAKE_KEY_12345" or similar) instead of
"sk_test_51TCRge3nnME1dfOB" so secret scanners won’t flag it; locate the
assertion that calls ExternalApiLoggingInterceptor.redact and replace only the
input string while keeping the expected output ("sk_test_***") unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExternalApiLoggingInterceptorinplatform-infra— logs HTTP method, URL, headers (redacted), request/response bodies, and latency@ConditionalOnProperty(app.external-api.logging.enabled=true)— disabled by default in production@Nullableconstructor injectionapplication-sandbox.ymlprofilesDesign
app.external-api.logging.enabled=true→ interceptor injected → full DEBUG loggingFiles Changed (65)
ExternalApiLoggingInterceptor,ExternalApiLoggingConfigExternalApiLoggingInterceptorTest@Nullable ExternalApiLoggingInterceptorconstructor paramnullfor new constructor paramapp.external-api.logging.enabled: trueTest plan
ExternalApiLoggingInterceptorTest— 5 redaction tests passCloses #246
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
app.external-api.logging.enabled: trueconfiguration.Chores