Handle WKS mission score field rename#118
Draft
endfish wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScoreUIntandScorefield names are supported.MissingFieldExceptionfrom abortingWorldStateUpdater.Update()every framework tick when the active FFXIVClientStructs build exposes the score field asScore.Root cause
On a CN Dalamud environment using
FFXIVClientStructs.dllfromXIVLauncherCN\addon\Hooks\15.0.2.1,WKSMissionModule.MissionStateexposes these fields:The current direct reference to
CurrentMission.ScoreUIntthrows continuously:Because this happens before later fishing update handling, the plugin can still start/cast in some paths but fails to reliably process bite/hook behavior.
Validation
ScoreUIntcompile/runtime incompatibility against the local CN DalamudFFXIVClientStructs.dll.dotnet build AutoHook.slnwithDALAMUD_HOMEpointed atXIVLauncherCN\addon\Hooks\15.0.2.1; the previousScoreUInterror is gone.main:AutoHook/Ui/SubTabAutoCast.cs(9,71): error CS0103: The name 'with' does not exist in the current context.