[Enhance][AutoVoteMvp] Allow manual commendation selection/override and exclusions via context menu#150
Open
StrawberryClover wants to merge 8 commits into
Open
[Enhance][AutoVoteMvp] Allow manual commendation selection/override and exclusions via context menu#150StrawberryClover wants to merge 8 commits into
StrawberryClover wants to merge 8 commits into
Conversation
- Added context menu items for party list for both selecting someone for commend, along with excluding members from being commended - Added config option to show context menu items
- Made auto-commend and exclude from commend mutually exclusive - can no longer be both as that makes no sense - If there are no party members left to pick from (excluded all party members, for some reason), it will make one final attempt to pick a member at random as a fallback condition.
Also, removed fallback logic in case no valid members exist, as there are situations where you don't want to commend anybody. Cleaned up some of the log.
Removed validPartyMembers fallback list I previously created, as since it is no longer being used for fallback in cases of no members available in the list, it is unnecessary.
StrawberryClover
changed the title
StrawberryClover
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds manual control over commendation behavior via new context menu options.
✨ Features:
🔎 Motivation:
AutoVoteMvp previously only allowed random or condition-based commendations (such as prioritizing tanks, DPS, or avoiding players who died).
However, there was no way for the user to exercise manual control mid-duty — for example, to commend someone who was especially helpful, friendly, or performed very well.
If a specific commendation was desired, the only option was to temporarily disable the auto-commend feature entirely mid-run.
Similarly, if a party member behaved poorly, users had no way to exclude them from being randomly selected without also disabling the feature.
This change introduces simple, in-duty options to manually select a player to commend or exclude a player from being commended, without having to open configuration menus mid-run.
Example of context menu:
