Fixed segmentation fault caused by accessing nonexistent child

acezxn · acezxn · commit fb99a4dd2c3a · 2025-10-04T21:50:37.000-04:00
diff --git a/.gitmodules b/.gitmodules
@@ -13,3 +13,12 @@
 [submodule "benchmark/Javascript/microlight"]
 	path = benchmark/Javascript/microlight
 	url = https://github.com/asvd/microlight.git
+[submodule "benchmark/Javascript/mocha"]
+	path = benchmark/Javascript/mocha
+	url = https://github.com/mochajs/mocha.git
+[submodule "squish"]
+	path = squish
+	url = https://github.com/shgysk8zer0/squish.git
+[submodule "benchmark/Javascript/squish"]
+	path = benchmark/Javascript/squish
+	url = https://github.com/shgysk8zer0/squish.git
diff --git a/benchmark/Javascript/mocha b/benchmark/Javascript/mocha
@@ -0,0 +1 @@
+Subproject commit d643105aa6f3fbac9d13e8a44f4c4c7302512193
diff --git a/benchmark/Javascript/squish b/benchmark/Javascript/squish
@@ -0,0 +1 @@
+Subproject commit fd5e5640eeee8e521201a6d0975de9cbd7301536
diff --git a/squish b/squish
@@ -0,0 +1 @@
+Subproject commit fd5e5640eeee8e521201a6d0975de9cbd7301536
diff --git a/src/tstool/dfbscan_extractor/Javascript/Javascript_NPD_extractor.py b/src/tstool/dfbscan_extractor/Javascript/Javascript_NPD_extractor.py
@@ -61,6 +61,10 @@ def is_global_source(self, global_declaration_node: Tree) -> bool:
         sibling = global_declaration_node.next_sibling
 
         while sibling is not None:
+            if len(sibling.children) == 0:
+                sibling = sibling.next_sibling
+                continue
+
             expr = sibling.child(0)
             
             if self.is_expression_delete(expr):
@@ -72,7 +76,7 @@ def is_global_source(self, global_declaration_node: Tree) -> bool:
             if self.is_expression_nullable(expr) and expr.child(0).text == global_name:
                 return True
 
-            return False
+            sibling = sibling.next_sibling
         return False
 
     def is_global_sink(self, global_declarator_node: Tree) -> bool:
