Fix viewing an app with a Git source where the installation has been removed

Author: FluxCapacitor2

backend/src/service/getDeployment.ts

@@ -5,7 +5,10 @@ import type { OrganizationRepo } from "../db/repo/organization.ts";
 import type { KubernetesClientService } from "./common/cluster/kubernetes.ts";
 import type { DeploymentConfigService } from "./common/deploymentConfig.ts";
 import type { GitProviderFactoryService } from "./common/git/gitProvider.ts";
-import { DeploymentNotFoundError } from "./errors/index.ts";
+import {
+  DeploymentNotFoundError,
+  InstallationNotFoundError,
+} from "./errors/index.ts";
 
 export class GetDeploymentService {
   private orgRepo: OrganizationRepo;
@@ -57,11 +60,17 @@ export class GetDeploymentService {
     let repositoryURL: string | null = null;
     let pods: V1PodList | null = null;
     if (config.source === "GIT") {
-      const gitProvider = await this.gitProviderFactoryService.getGitProvider(
-        org.id,
-      );
-      const repo = await gitProvider?.getRepoById(config.repositoryId);
-      repositoryURL = repo?.htmlURL;
+      try {
+        const gitProvider = await this.gitProviderFactoryService.getGitProvider(
+          org.id,
+        );
+        const repo = await gitProvider?.getRepoById(config.repositoryId);
+        repositoryURL = repo?.htmlURL;
+      } catch (e) {
+        if (!(e instanceof InstallationNotFoundError)) {
+          throw e;
+        }
+      }
     }
     if (config.appType === "workload") {
       pods = await api

frontend/src/pages/DashboardView.tsx

@@ -135,10 +135,15 @@ const AppCard = ({ app }: { app: components["schemas"]["AppSummary"] }) => {
           </Link>
         </p>
         {app.source === "GIT" ? (
-          <p className="text-black-4 z-10 text-sm">
+          <p className="text-black-4 text-sm">
             Commit <code>{app.commitHash?.slice(0, 8)}</code> on{" "}
             <a
-              href={`${app.repositoryURL}/tree/${app.branch}`}
+              className="relative z-10"
+              href={
+                app.repositoryURL
+                  ? `${app.repositoryURL}/tree/${app.branch}`
+                  : "#"
+              }
               target="_blank"
               rel="noreferrer"
             >

frontend/src/pages/DeploymentView.tsx

@@ -80,7 +80,11 @@ export const DeploymentView = () => {
         {deployment.config.source === "git" && deployment.commitHash ? (
           <a
             className="flex gap-1"
-            href={`${app.repositoryURL}/commit/${deployment.commitHash}`}
+            href={
+              app.repositoryURL
+                ? `${app.repositoryURL}/commit/${deployment.commitHash}`
+                : "#"
+            }
           >
             <GitCommit /> {deployment.commitHash.substring(0, 7)}
           </a>

frontend/src/pages/app/OverviewTab.tsx

@@ -133,7 +133,11 @@ export const OverviewTab = ({
             " a workflow "
           ) : (
             <a
-              href={`${app.repositoryURL}/tree/${app.config.branch}/${workflow.path}`}
+              href={
+                app.repositoryURL
+                  ? `${app.repositoryURL}/tree/${app.config.branch}/${workflow.path}`
+                  : "#"
+              }
               target="_blank"
               className="underline"
               rel="noreferrer"
@@ -174,15 +178,24 @@ export const OverviewTab = ({
               Git repository
             </p>
             <p>
-              <a
-                href={app.repositoryURL}
-                className="flex items-center gap-1 underline"
-                target="_blank"
-                rel="noopener noreferrer"
-              >
-                {URL.parse(app.repositoryURL!)?.pathname?.substring(1)}
-                <ExternalLink size={14} />
-              </a>
+              {app.repositoryURL ? (
+                <a
+                  href={app.repositoryURL ?? "#"}
+                  className="flex items-center gap-1 underline"
+                  target="_blank"
+                  rel="noopener noreferrer"
+                >
+                  {URL.parse(app.repositoryURL)?.pathname?.substring(1)}
+                  <ExternalLink size={14} />
+                </a>
+              ) : (
+                <p>
+                  Disconnected.{" "}
+                  <Link to="?tab=configuration" className="underline">
+                    Reconnect
+                  </Link>
+                </p>
+              )}
             </p>
           </>
         ) : app.config.source === "image" ? (

frontend/src/pages/app/overview/RedeployModal.tsx

@@ -222,7 +222,11 @@ export const RedeployModal = ({
                       <div className="my-2 ml-6">
                         {pastDeployment.config.source === "git" ? (
                           <a
-                            href={`${pastDeployment.repositoryURL}/commit/${pastDeployment.commitHash}`}
+                            href={
+                              pastDeployment.repositoryURL
+                                ? `${pastDeployment.repositoryURL}/commit/${pastDeployment.commitHash}`
+                                : "#"
+                            }
                             className="flex items-start gap-2"
                             target="_blank"
                             rel="noreferrer"