Fix lint

Author: skkra0

frontend/src/components/config/workload/EnvVarGrid.tsx

@@ -3,7 +3,7 @@ import { Button } from "@/components/ui/button";
 import { Checkbox } from "@/components/ui/checkbox";
 import { Input } from "@/components/ui/input";
 import { Trash2 } from "lucide-react";
-import { Fragment, useEffect, useState } from "react";
+import { Fragment } from "react";
 
 type EnvVars = { name: string; value: string | null; isSensitive: boolean }[];
 
@@ -18,29 +18,7 @@ export const EnvVarGrid = ({
   fixedSensitiveVars: Record<string, number>;
   disabled: boolean;
 }) => {
-  const [error, setError] = useState("");
-  useEffect(() => {
-    const names = new Set<string>();
-    const duplicates = new Set<string>();
-
-    envVars.forEach((env) => {
-      if (env.name === "") return;
-
-      if (names.has(env.name)) {
-        duplicates.add(env.name);
-      } else {
-        names.add(env.name);
-      }
-    });
-
-    if (duplicates.size !== 0) {
-      setError(
-        `Duplicate environment variable(s): ${[...duplicates.values()].join(", ")}`,
-      );
-    } else {
-      setError("");
-    }
-  }, [envVars, setEnvironmentVariables]);
+  const error = getEnvError(envVars);
 
   return (
     <div className="grid grid-cols-[1fr_min-content_1fr_min-content_min-content] items-center gap-2">
@@ -165,3 +143,28 @@ export const getCorrectEnvBlanks = (envVars: EnvVars): EnvVars => {
   }
   return cleanedVars;
 };
+
+const getDuplicates = (values: string[]) => {
+  const unique = new Set<string>();
+  const duplicates = new Set<string>();
+
+  values.forEach((value) => {
+    if (unique.has(value)) {
+      duplicates.add(value);
+    } else {
+      unique.add(value);
+    }
+  });
+
+  return duplicates;
+};
+
+export const getEnvError = (env: EnvVars) => {
+  const duplicates = getDuplicates(env.map((ev) => ev.name).filter(Boolean));
+
+  if (duplicates.size !== 0) {
+    return `Duplicate environment variable(s): ${[...duplicates.values()].join(", ")}`;
+  }
+
+  return "";
+};

frontend/src/components/diff/workload/EnvsWithDiffs.tsx

@@ -1,10 +1,13 @@
-import { getCorrectEnvBlanks } from "@/components/config/workload/EnvVarGrid";
+import {
+  getCorrectEnvBlanks,
+  getEnvError,
+} from "@/components/config/workload/EnvVarGrid";
 import HelpTooltip from "@/components/HelpTooltip";
 import { Button } from "@/components/ui/button";
 import { Checkbox } from "@/components/ui/checkbox";
 import { Input } from "@/components/ui/input";
 import { Trash2 } from "lucide-react";
-import { Fragment, useEffect, useState } from "react";
+import { Fragment } from "react";
 
 type EnvVars = { name: string; value: string | null; isSensitive: boolean }[];
 
@@ -21,29 +24,7 @@ export const EnvsWithDiffs = ({
   fixedSensitiveVars: Record<string, number>;
   disabled?: boolean;
 }) => {
-  const [error, setError] = useState("");
-  useEffect(() => {
-    const names = new Set<string>();
-    const duplicates = new Set<string>();
-
-    envVars.forEach((env) => {
-      if (env.name === "") return;
-
-      if (names.has(env.name)) {
-        duplicates.add(env.name);
-      } else {
-        names.add(env.name);
-      }
-    });
-
-    if (duplicates.size !== 0) {
-      setError(
-        `Duplicate environment variable(s): ${[...duplicates.values()].join(", ")}`,
-      );
-    } else {
-      setError("");
-    }
-  }, [envVars, setEnvironmentVariables]);
+  const error = getEnvError(envVars);
 
   const currentEnv = envVars.reduce(
     (obj, current) => {

frontend/src/pages/app/OverviewTab.tsx

@@ -113,12 +113,13 @@ export const OverviewTab = ({
     }
   }, [workflows, app.config.source]);
 
+  const firstDeploymentStatus = deployments?.[0]?.status;
   useEffect(() => {
     // When the first deployment's status changes to Complete, refetch the app to update the "current" deployment
-    if (deployments?.[0]?.status === "COMPLETE") {
+    if (firstDeploymentStatus === "COMPLETE") {
       refetchApp();
     }
-  }, [deployments?.[0]?.status]);
+  }, [firstDeploymentStatus]);
 
   let deployTrigger = null;
   if (app.config.source === "git") {