Text styling modifiers - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First parity tier: text styling. Adds the text-attribute modifiers and applies them as parameters of the Compose
Textcomposable (they describe the text, not the layoutModifierchain, so they are read off a Text node's modifier list rather than folded).New modifiers
.font(_:)— named styles (.largeTitle….caption2, resolved to point sizes by the interpreter) and.system(size:weight:).foregroundColor(_:)/.foregroundStyle(_:).bold()/.fontWeight(_:).italic().lineLimit(_:).multilineTextAlignment(_:)Multiple text modifiers compose on one Text; later (innermost) entries win for scalar attributes, and layout modifiers in the same chain still apply normally.
Verification
swift test— 6 new emission tests, 35 total passingtitle + bold + green, andlineLimit(2)truncation vs. full multilineDeferred
Container-level font/color environment propagation (styling only applies when set directly on a Text). Tracked for a later tier.