Appearance: border, shadow, clipShape, and overlay - #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sixth tier: appearance modifiers.
What's new
.border(_:width:),.shadow(radius:…),.clipShape(_:)— fold into the Compose Modifier chain (border,shadow,clipwith the shape mapped fromRectangle/Circle/Capsule/RoundedRectangle)..overlay(alignment:content:)— an Overlay node whose base and overlay stack in a Box, the overlay sized to the base viamatchParentSizeand positioned by alignment.Also fixed
Colornow fills the width offered it (SwiftUI semantics) — height-only colors previously collapsed to zero width (visible once an overlay's base was aColor.frame(height:)).fillMaxWidthis applied after the modifier chain so an explicit frame width still constrains. Same correction applied to the gradient path.Verification
swift test— 4 new tests (border, clipShape, shadow, overlay base/overlay children + alignment), 52 total passingDeferred
.tint(control theming); custom shadow color/offset (radius → elevation only); stroked shapes.