DatePicker - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the controls tier: a date picker bound to a Foundation
Date.What's new
DatePicker—DatePicker("Title", selection: $date)withBinding<Date>(Foundation'sDate; the core now imports Foundation rather than defining its own date type). The selection crosses the bridge as milliseconds since the Unix epoch — ComposeDatePickerState's native currency — so the conversion is a single multiply on each side.Jan 15, 2000); tapping opens a Material3DatePickerDialog, and confirming fires the double callback with the picked millis.Verification
swift test— DatePicker emission + round-trip test (invoking the change callback updates the emitted millis), 53 total passingJan 1, 2000from the initialDate; tapping opens the calendar dialog seeded to January 2000 with day 1 selected; picking 15 and confirming updates the row toJan 15, 2000— full state round-trip through@State var birthday: DateNotes
Date-only (UTC midnight semantics, matching the Material date picker);
displayedComponents/time selection not modeled. Dialog date formatting is a fixedMMM d, yyyy-style abbreviation, locale-neutral for now.