Flexible frames: min/max/ideal, fill, and alignment#37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the biggest day-to-day layout gap:
.frameonly supported fixedwidth/height.What's new
.frame—minWidth/idealWidth/maxWidth/minHeight/idealHeight/maxHeightplusalignment.maxWidth/maxHeightof.infinityfills the available space..framenow takesalignment:— positions the content within the frame.Alignmentpreset set — added.leading/.trailing/.top/.bottom/.topTrailing/.bottomLeading(only.center/.topLeading/.bottomTrailingexisted)..infinitycan't cross the bridge as a JSON number, so it's carried as afillWidth/fillHeightflag; the interpreter maps tofillMaxWidth/fillMaxHeight, finite bounds towidthIn/heightIn, and alignment towrapContentSize.Verification
swift test— 4 new frame tests (default-alignment omission, fill flag, bounds), 61 passingmin 120/max 200box whose text wraps at the cap — all render as SwiftUI wouldIncidental
Adds a core-package
.gitignorefor strayswiftcbuild outputs (*.swiftmodule,*.dia, …) that had accumulated untracked in the package root.Deferred
idealWidth/idealHeightare emitted but only inform bounds today (no ideal-size negotiation); per-axis alignment guides beyond the 9 presets.