ComposableView actions: callbacks back into Swift - #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the custom-view mechanism (#39) with the "coordinator" half — a custom composable can now send events back into Swift state, so interop is two-way.
API
ComposableViewgains anactions:parameter — a dictionary of namedComposableActions, each a typed closure matching the fixed bridge surface:Each action registers a callback in the resolve context (exactly like
Button's tap) and crosses as an id prop. On the Kotlin side,Propsexposes typed action lambdas —props.doubleAction("onRatingChanged")returns a(Double) -> Unitthat dispatches back to Swift; the factory never sees the id or the bridge:Verification
swift test— new test invoking a registered action through the callback registry, 61 total passingRatingBaris now interactive — dragging the stars updates Swift@State(drag → 1.5, and the siblingTextreads "1.5 / 5"), while the ±½ buttons drive it the other way. Both directions share one state with no feedback loop (thefromUserguard filters programmatic updates).Deferred
Actions are per-event fire-and-forget (no return values back to the composable); coordinator-style object state lives in the Kotlin factory's
remember.