Add Label and labelStyle#62
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Label("title", systemImage:)(and the customtitle:/icon:builder), plus.labelStyle(.automatic / .titleAndIcon / .titleOnly / .iconOnly).Shape
Emitted as its own
Labelnode with children[icon, title]rather than desugared to anHStack— that fixed order is what letslabelStyledrop either half. The style rides the same inherited-CompositionLocalmechanism the control styles use (#55):.labelStyleon a container styles every label beneath it, and each label readsLocalLabelStyleto decide whether to show its icon, its title, or both.Verification
swift test— 3 new tests, 110 passing: icon-then-title order (the interpreter depends on it), the custom title/icon builder, and — the load-bearing one — that a container carries the style while the labels beneath it carry none of their own, which is what makes inheritance real rather than per-node..titleOnlyshows only the text,.iconOnlyshows only the star; and both hearts under one container-level.labelStyle(.iconOnly)drop their titles — inheritance working end to end. The dropped titles are also absent from the accessibility tree, not just hidden.Scope
Built-in style spellings only — the
LabelStyleprotocol for custom layouts isn't modeled..automaticand.titleAndIconboth show both halves.