Add contextMenu#66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.contextMenu { … }— a menu of actions revealed by long-pressing a view.Shape
The menu items are views, so — like
.sheetand.toolbar— they can't ride on a scalar modifier. The wrapper emits aContextMenunode whose children are[content…, menuItem…], with acontentCountprop marking the split. The interpreter wraps the content in acombinedClickable(onLongClick =)and anchors aDropdownMenuof the items to it — reusing the exact item-dispatch logic fromMenu, so each item is aButtonthat fires its own callback and dismisses.Verification
swift test— new test, 116 passing: the wrapper carriescontentCount = 1, holds1 content + 2 menu items, and a menu item's callback still reaches the closure through the hidden-child path.Scope
Buttons as menu items (the common case); no submenus, no
.contextMenu(menuItems:preview:)preview variant, and no primary-action overload.