Add popover#67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.popover(isPresented:content:)— a small piece of content floated next to a view while a bound flag is true.Shape
Unlike
.sheet(screen-level, picked up byRenderSheetsAndAlerts), a popover is anchored to a specific view, so it uses the wrapper-node structure fromcontextMenurather than the hidden-screen-child one: aPopovernode whose children are[anchor…, body…], withanchorCountsplitting them. The body is resolved only while presented. The interpreter renders the anchor and, when presented, a ComposePopup(focusable, elevatedSurfacebubble) offset just below it, whoseonDismissRequestwrites the bound flag back — so tapping off the bubble dismisses, and the popover's own buttons can dismiss by setting the binding false.Verification
swift test— new test, 117 passing: collapsed emits the anchor only with no body resolved; presenting adds the body as a second child; and the dismiss callback flipsisPresentedback to false (dropping the body again).Scope
The plain
isPresentedform; nopopover(item:), noattachmentAnchor/arrowEdgepositioning (the bubble anchors top-start below the view). On a phone SwiftUI itself often falls back to a sheet — this always shows the floating bubble.