Skip to content

add dependabot#189

Closed
zunda-pixel wants to merge 1 commit into
PureSwift:masterfrom
zunda-pixel:add-dependabot
Closed

add dependabot#189
zunda-pixel wants to merge 1 commit into
PureSwift:masterfrom
zunda-pixel:add-dependabot

Conversation

@zunda-pixel

Copy link
Copy Markdown
Contributor
  • add dependabot
  • add Package.resolved to make bot recognize dependency

@colemancda

Copy link
Copy Markdown
Member

I'm fine adding dependabot but I don't want to add the Package.resolved file

@zunda-pixel

Copy link
Copy Markdown
Contributor Author

Dependabot can detect major version updates in Package.resolved if the file exists in the repository.
However, if Package.resolved is not present, Dependabot cannot detect updates — except for major version changes.
Example:
If Package.resolved contains version 7.1.0, Dependabot can create a pull request when an update is available, as long as the file is committed.
But if the repository does not include Package.resolved, Dependabot cannot detect library updates, even if a newer version exists.

This seems to be a limitation of Dependabot, but I think it’s better to explicitly add Package.resolved to the repository so that minor version updates can also be detected.

Please let me know if there are any issues with including Package.resolved in the repository.

@colemancda

Copy link
Copy Markdown
Member

This library is supposed to have 0 dependencies, outside of the standard Apple ones. The dependencies it does have are conditional on the build mode, e.g. docs, embedded, code generation, so I don't think it's a good idea to add the Package.resolved file.

@colemancda colemancda closed this Jun 7, 2025
@zunda-pixel zunda-pixel deleted the add-dependabot branch June 7, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants