fixed gmtime() crash on Linux

colemancda · colemancda · commit 6a29f3017d28 · 2016-05-19T22:11:02.000-05:00
diff --git a/Sources/SwiftFoundation/POSIXTime.swift b/Sources/SwiftFoundation/POSIXTime.swift
@@ -80,10 +80,11 @@ public extension tm {
         
         var seconds = UTCSecondsSince1970
         
+        // don't free!
+        // The return value points to a statically allocated struct which might be overwritten by subsequent calls to any of the date and time functions.
+        // http://linux.die.net/man/3/gmtime
         let timePointer = gmtime(&seconds)!
         
-        defer { free(timePointer) }
-        
         self = timePointer.pointee
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -80,10 +80,11 @@ public extension tm {`
`80`	`80`
`81`	`81`	`var seconds = UTCSecondsSince1970`
`82`	`82`
	`83`	`+ // don't free!`
	`84`	`+ // The return value points to a statically allocated struct which might be overwritten by subsequent calls to any of the date and time functions.`
	`85`	`+ // http://linux.die.net/man/3/gmtime`
`83`	`86`	`let timePointer = gmtime(&seconds)!`
`84`	`87`
`85`		`- defer { free(timePointer) }`
`86`		`-`
`87`	`88`	`self = timePointer.pointee`
`88`	`89`	`}`
`89`	`90`	`}`