Fix review findings: track successful workers, don't skip cleanup

- Track only successfully completed workers (not just dispatched) so
  failed workers don't count as having participated
- Replace continue statements with flow-through logic so stall
  detection, SaveOrganization, and UI updates always run
- Add comment documenting HashSet sequential access safety

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: PureWeen

PolyPilot/Services/CopilotService.Organization.cs

@@ -1681,6 +1681,8 @@ private async Task SendViaOrchestratorReflectAsync(string groupId, List<string>
         }
 
         var workerNames = members.Where(m => m != orchestratorName).ToList();
+        // Tracks workers that have successfully completed at least once across all iterations.
+        // Access is sequential (single async flow, no concurrent modification).
         var dispatchedWorkers = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
 
         try
@@ -1761,9 +1763,9 @@ private async Task SendViaOrchestratorReflectAsync(string groupId, List<string>
             var workerTasks = assignments.Select(a => ExecuteWorkerAsync(a.WorkerName, a.Task, prompt, ct));
             var results = await Task.WhenAll(workerTasks);
 
-            // Track which workers have been dispatched across all iterations
-            foreach (var a in assignments)
-                dispatchedWorkers.Add(a.WorkerName);
+            // Track only workers that succeeded across all iterations
+            foreach (var r in results.Where(r => r.Success))
+                dispatchedWorkers.Add(r.WorkerName);
 
             // Phase 4: Synthesize + Evaluate
             InvokeOnUI(() => OnOrchestratorPhaseChanged?.Invoke(groupId, OrchestratorPhase.Synthesizing, iterDetail));
@@ -1799,18 +1801,21 @@ private async Task SendViaOrchestratorReflectAsync(string groupId, List<string>
                     AddOrchestratorSystemMessage(orchestratorName, $"✅ {reflectState.BuildCompletionSummary()} (score: {score:F1})");
                     break;
                 }
-                else if (!allWorkersDispatched)
+
+                if (!allWorkersDispatched)
                 {
                     var missing = workerNames.Where(w => !dispatchedWorkers.Contains(w)).ToList();
                     Debug($"Reflection: overriding completion — workers not yet dispatched: {string.Join(", ", missing)}");
                     reflectState.LastEvaluation = $"Not all workers have participated yet. Missing: {string.Join(", ", missing)}. " +
                         "Dispatch to the remaining workers before completing.";
                     AddOrchestratorSystemMessage(orchestratorName,
                         $"🔄 Overriding completion — {string.Join(", ", missing)} haven't participated yet.");
-                    continue;
+                }
+                else
+                {
+                    reflectState.LastEvaluation = rationale;
                 }
 
-                reflectState.LastEvaluation = rationale;
                 if (trend == Models.QualityTrend.Degrading)
                     reflectState.PendingAdjustments.Add("📉 Quality degrading — consider changing worker models or refining the goal.");
             }
@@ -1828,7 +1833,8 @@ private async Task SendViaOrchestratorReflectAsync(string groupId, List<string>
                     AddOrchestratorSystemMessage(orchestratorName, $"✅ {reflectState.BuildCompletionSummary()}");
                     break;
                 }
-                else if (synthesisResponse.Contains("[[GROUP_REFLECT_COMPLETE]]", StringComparison.OrdinalIgnoreCase)
+
+                if (synthesisResponse.Contains("[[GROUP_REFLECT_COMPLETE]]", StringComparison.OrdinalIgnoreCase)
                     && !allWorkersDispatched)
                 {
                     // Override premature completion — not all workers have participated
@@ -1840,16 +1846,17 @@ private async Task SendViaOrchestratorReflectAsync(string groupId, List<string>
                         $"🔄 Overriding completion — {string.Join(", ", missing)} haven't participated yet.");
                     reflectState.RecordEvaluation(reflectState.CurrentIteration, 0.3,
                         reflectState.LastEvaluation, GetEffectiveModel(orchestratorName));
-                    continue;
                 }
+                else
+                {
+                    // Extract evaluation for next iteration
+                    reflectState.LastEvaluation = ExtractIterationEvaluation(synthesisResponse);
 
-                // Extract evaluation for next iteration
-                reflectState.LastEvaluation = ExtractIterationEvaluation(synthesisResponse);
-
-                // Record a self-eval score (estimated from sentinel presence)
-                var selfScore = synthesisResponse.Contains("[[NEEDS_ITERATION]]", StringComparison.OrdinalIgnoreCase) ? 0.4 : 0.7;
-                reflectState.RecordEvaluation(reflectState.CurrentIteration, selfScore,
-                    reflectState.LastEvaluation ?? "", GetEffectiveModel(orchestratorName));
+                    // Record a self-eval score (estimated from sentinel presence)
+                    var selfScore = synthesisResponse.Contains("[[NEEDS_ITERATION]]", StringComparison.OrdinalIgnoreCase) ? 0.4 : 0.7;
+                    reflectState.RecordEvaluation(reflectState.CurrentIteration, selfScore,
+                        reflectState.LastEvaluation ?? "", GetEffectiveModel(orchestratorName));
+                }
             }
 
             // Auto-adjustment: analyze worker results and suggest/apply changes