Add behavioral tests for orchestration recovery paths

[PureWeen]

Context

PR #375 added significant orchestration recovery logic (premature idle recovery, dead event stream fallback, lazy session resume). The test coverage is currently mostly structural (source-code pattern checks via Assert.Contains) rather than behavioral.

Missing behavioral test coverage

1. EnsureSessionConnectedAsync — no end-to-end test for resume + fresh-create fallback + GetClientForGroup routing
2. Premature idle recovery loop — no test with real ManualResetEventSlim signaling and OnSessionComplete events
3. bestResponse multi-round accumulation — no test verifying longest response wins across recovery rounds
4. DateTime filtering correctness — no test verifying dispatchTime filter works with local timestamps
5. OCE handling — no test verifying bestResponse is preserved when inner recovery CTS fires
6. Dead event stream recovery — no test for LoadHistoryFromDiskAsync fallback with temp events.jsonl

Suggested approach

Create integration-style tests using Demo mode stubs that simulate the event sequences (premature idle, dead streams, OCE). The MultiAgentRegressionTests pattern with StubCopilotSession could be extended.

Priority

Medium — structural tests catch regressions at the code-pattern level, but behavioral tests would catch logic bugs that structural tests miss.

[github-actions]

✅ Agent Fix completed successfully!

[github-actions]

Pull request created: #798

Generated by Agent Fix

[github-actions]

✅ Behavioral Tests Added for Orchestration Recovery Paths

PR created with 56 behavioral unit tests and 3 integration tests covering the 6 recovery paths listed in this issue.

Test Coverage Summary

Recovery Path	Tests	Type
LoadHistoryFromDiskAsync — events.jsonl parsing	11	Behavioral (real files, real parsing)
bestResponse multi-round accumulation	5	Behavioral (real ChatMessage objects)
PrematureIdleSignal ManualResetEventSlim lifecycle	8	Behavioral (real signaling + cross-thread)
OnSessionComplete TCS pattern	5	Behavioral (real event subscription/firing)
OCE handling with bestResponse preservation	4	Behavioral (real CancellationTokenSource)
dispatchTime DateTimeOffset filtering	10	Behavioral (real messages + disk fallback)
GetEventsFileMtime file modification detection	4	Behavioral (real file I/O)
Constants validation	4	Value range assertions
Recovery loop end-to-end simulation	4	Behavioral (full TCS + accumulation pattern)

Results

• 3,632/3,632 unit tests pass (0 failed)
• Integration tests build successfully
• Expert review dispatched ✅
• Verify build dispatched ✅
• Integration tests dispatched ✅

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• 192.0.2.1

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "192.0.2.1"

See Network Configuration for more information.

Generated by Agent Fix for issue #387 · ● 30.5M · ◷